[porting-issues] [Issue 115619] introduce osl_setThreadNa me
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115619 User sb changed the following: What|Old value |New value Status|NEW |STARTED Target milestone|--- |OOo 3.4 --- Additional comments from s...@openoffice.org Wed Nov 17 08:31:52 + 2010 --- Pthreads does not support naming threads, AFAIK. There may be platform specific solutions, however (reportedly, prctl(PR_SET_NAME) can be used for this on Linux 2.6); the question, then, is whether all those platform specific solutions can set a name after the thread is created, i.e., whether an additional osl_setThreadName is OK or we rather need an enhanced osl_createThread. Investigation needed. Apart from that: - Not sure returning a sal_Bool (instead of void) from osl_setThreadName is worth it, given the function will be relevant for debugging purposes only, anyway. - The Windows patch differs slightly from what is suggested at http://msdn.microsoft.com/en-us/library/xcb2z8hs.aspx (0x406D1388 vs. MS_VC_EXCEPTION, DWORD vs. ULONG_PTR). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 115619] introduce osl_setThreadNa me
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115619 --- Additional comments from f...@openoffice.org Wed Nov 17 10:13:28 + 2010 --- The windows version was taken from http://blogs.msdn.com/b/stevejs/archive/2005/12/19/505815.aspx. As I understood comments around this page, the actual exception code does not really matter, except that no other place should use that specific code. Thanks for taking that! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 115619] introduce osl_setThreadNa me
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115619 Issue #|115619 Summary|introduce osl_setThreadName Component|porting Version|OOo 3.3 RC4 Platform|Unknown URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|sb Reported by|fs --- Additional comments from f...@openoffice.org Tue Nov 16 22:33:03 + 2010 --- For debugging purpose, it would sometimes be useful if all the dozens of threads running in an ordinary OOo process would be distinguishable, to a higher degree than they are currently. For this, given a thread a name would be pretty handy - client code which starts a thread for a given purpose could express this purpose in the thread's name. I know that Windows supports naming threads, I don't know about other platforms. The to-be-attached patch introduces a osl_setThreadName function, returning a sal_Bool for success, implemented for Win32 at the moment, not implemented (i.e. returning sal_False) for the other platforms. I am well aware that this is a debug-only feature, nonetheless I think it could be justified to add this function to sal's official API. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 115619] introduce osl_setThreadNa me
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115619 User fs changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |75025) patch implementing | |the suggested function --- Additional comments from f...@openoffice.org Tue Nov 16 22:34:13 + 2010 --- Created an attachment (id=75025) patch implementing the suggested function - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 115619] introduce osl_setThreadNa me
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115619 --- Additional comments from f...@openoffice.org Tue Nov 16 22:34:58 + 2010 --- fs-sb: kindly asking for your review here. I'm willing to commit the patch to a CWS of mine, in case it survives your review :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
