[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User rt changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Tue Nov 8 03:36:23 -0800 2005 --- Got mails that this one is verified. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User rt changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from [EMAIL PROTECTED] Tue Nov 8 03:37:03 -0800 2005 --- closing - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=54458
--- Additional comments from [EMAIL PROTECTED] Thu Oct 27 00:23:13 -0700
2005 ---
Simon Hogg reported a break with m135, and we absolutly have to fix it...
copy-paste of his post on [EMAIL PROTECTED] ml follows :
Hi,
I'm trying to build 680_M135 on Mac OS X 10.4.2 with XCode 2.1/gcc 4
now that the cws macosxgcc4 has been merged. However I'm having a bit
of trouble in psprint.
In issue i54458 there was a patch to source/fontmanager/fontconfig.cxx
that cast m_plib to _oslModule* in the call to osl_getSymbol().
In the milestone this has been modified to cast to oslModule* because
using _oslModule* caused build issues on other platforms.
Unfortunately this seems to break my build again.
For my purposes I've rolled fontconfig.cxx back from revision 1.13 to
1.12 and the build now continues, but obviously this isn't the way to
fix this.
I've traced the symbol back to sal/osl/module.h where we have, on lines 78-86:
#ifdef MACOSX
struct _oslModule
{
void* pModule;
sal_Char* pModuleName;
};
typedef struct _oslModule * oslModule;
#else
typedef void* oslModule;
#endif
I think we can alter fontconfig.cxx and salplug.cxx to cast to
oslModule rather than oslModule*. This shouldn't make any difference
to other platforms because oslModule is typedef'ed to void*, which in
both of these files is a noop and returns them to the previous
behaviour, rather than casting void* to void**.
Could someone please verify this?
If this is really an issue, should issue i54458 be reopened or should
I create a new issue?
Thanks,
Simon
ps It seems that this also shows up in vcl/source/unx/plugadapt/salplug.cxx.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User rt changed the following: What|Old value |New value Status|REOPENED |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Thu Oct 27 01:06:15 -0700 2005 --- Fixed now on CVS HEAD as proposed by nephila and ericb. Will get into milestone m137. For now please update those two files psprint/source/fontmanager/fontconfig.cxx vcl/unx/source/plugadapt/salplug.cxx to continue your build. And again, sorry for my mistake. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User rt changed the following: What|Old value |New value Status|RESOLVED |REOPENED Resolution|FIXED | --- Additional comments from [EMAIL PROTECTED] Thu Oct 27 01:07:50 -0700 2005 --- Eric, could you please verify? re-open issue and reassign to [EMAIL PROTECTED] - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User rt changed the following: What|Old value |New value Assigned to|fheckl|ericb Status|REOPENED |NEW --- Additional comments from [EMAIL PROTECTED] Thu Oct 27 01:07:54 -0700 2005 --- reassign to [EMAIL PROTECTED] - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User rt changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Thu Oct 27 01:07:58 -0700 2005 --- reset resolution to FIXED - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 --- Additional comments from [EMAIL PROTECTED] Wed Oct 26 09:06:41 -0700 2005 --- The code in build 680 milestone 135 alters some of the lines changed by the patch i54458_psprint_source_patch.diff, breaking the compatability with Mac OS X/gcc 4 again. I'm now getting error: cannot convert '_oslModule**' to '_oslModule*' for argument '1' to 'void osl_unloadModule(_oslModule*)' and error: cannot convert '_oslModule**' to '_oslModule*' for argument '1' to 'void osl_getSymbol(_oslModule*)' messages. The difference seems to be that the code in v 1.13 of fontconfig.cxx casts m_plib to oslModule* and not _oslModule* as it does in the patch attached to this issue. On other platforms this cast has the effect of casting void* to void** which may cause issues elsewhere. I believe that the correct thing to do would be to change all instances of the cast from (oslModule*) to (oslModule) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User rt changed the following: What|Old value |New value CC|''|'rt' Status|VERIFIED |REOPENED Resolution|FIXED | --- Additional comments from [EMAIL PROTECTED] Wed Oct 26 09:32:33 -0700 2005 --- Oops, sorry, seems to be my fault. I changed what I've got from CWS macosxgcc4 because it broke all platforms except macosx. Obviously I did not check thoroughly enough, you're right with your analysis. Could you please check whether your proposed changes works for macosx? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User ericb changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Sun Oct 16 01:41:43 -0700 2005 --- Build is ok using macosxgcc4 cws is following cases : - Tiger + gcc-4.0.x - no break Panther + gcc-3.3 Issue verified for me - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User ericb changed the following: What|Old value |New value Target milestone|--- |OOo 2.0.1 --- Additional comments from [EMAIL PROTECTED] Sun Oct 16 01:48:37 -0700 2005 --- set target - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User fheckl changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Fri Sep 23 12:55:51 -0700 2005 --- Fixed in cws macosxgcc4. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 54458] psprint: Changes needed f or gcc4/MacOSX
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=54458 User fheckl changed the following: What|Old value |New value Attachment is patch| |Created an attachment | |(id=29467) solves | |compilability with | |gcc4/MacOSX --- Additional comments from [EMAIL PROTECTED] Sun Sep 11 08:21:00 -0700 2005 --- Created an attachment (id=29467) solves compilability with gcc4/MacOSX - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
