[porting-issues] [Issue 73768] rtl-Instance so unpleasant it's not used ...

2008-11-06 Thread mechtilde
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=73768


User mechtilde changed the following:

What|Old value |New value

  Status|RESOLVED  |CLOSED





--- Additional comments from [EMAIL PROTECTED] Thu Nov  6 08:56:15 + 
2008 ---
close the invalid issue

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[porting-issues] [Issue 73768] rtl-Instance so unpleasant it's not used ...

2007-01-23 Thread mmeeks
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=73768


User mmeeks changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |INVALID





--- Additional comments from [EMAIL PROTECTED] Tue Jan 23 01:22:36 -0800 
2007 ---
fair enough in the random case: my mistake. Though, the point is still valid
IMHO, the unique Instance code is grotesque to use; will file another issue with
suggested new variant.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[porting-issues] [Issue 73768] rtl-Instance so unpleasant it's not used ...

2007-01-23 Thread sb
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=73768


User sb changed the following:

What|Old value |New value

 Assigned to|sb|mmeeks





--- Additional comments from [EMAIL PROTECTED] Tue Jan 23 00:49:30 -0800 
2007 ---
@mmeeks:  rtl_createUuid needs to lock a mutex anyway so that no two threads
simultaneously call on the same random pool, so it can easily and cheaply use
that locked mutex to also make sure that only one thread initializes the pool. 
The rtl/instance.hxx stuff is for cases where (it is assumed that) it is too
expensive to make a get-or-create atomic by simply wrapping it in a mutex lock.

If the documentation in rtl/instance.hxx does not give you a clue, either please
improve it, or simply do not use rtl/instance.hxx but instead make your
get-or-creates atomic with a mutex lock (which IMO is the cleaner and better
alternative in almost all cases, anyway).

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[porting-issues] [Issue 73768] rtl-Instance so unpleasant it's not used ...

2007-01-22 Thread mmeeks
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=73768
 Issue #|73768
 Summary|rtl-Instance so unpleasant it's not used ...
   Component|porting
 Version|680m199
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|sb
 Reported by|mmeeks





--- Additional comments from [EMAIL PROTECTED] Mon Jan 22 13:05:23 -0800 
2007 ---
It -seems- that some people (even it's author?) prefer not to use it (?):

eg.

extern "C" void SAL_CALL rtl_createUuid( sal_uInt8 *pTargetUUID ,
 const sal_uInt8 *, sal_Bool )
{
{
osl::MutexGuard g(osl::Mutex::getGlobalMutex());
static rtlRandomPool pool = NULL;
if (pool == NULL) {
pool = rtl_random_createPool();
if (pool == NULL) {
abort(); //TODO
}
}

Why is it so fierce ? why does the first code you read in rtl/instance.hxx take 
6 template parameters ? is this useful ? can it not be simpler ?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]