[porting-issues] [Issue 75808] to-be-m207: sfx2/source/ap pl/shutdownicon.cxx:886: warning: 'bState' may be used uninitialized in this function

2007-03-28 Thread as
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=75808





--- Additional comments from [EMAIL PROTECTED] Wed Mar 28 08:47:13 + 
2007 ---
a) default value of sal_Bool is sal_false ... right
b) it doesnt matter which value is used initial for bState here. Why? We do
nothing in case the any value could not be extracted (see return statement). And
in case some value could be extracted successfully the initial default value was
overwritten by the new value.

Anyway: patch can be accepted ... even it does not fix any actual problem
(excepting warnings).

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[porting-issues] [Issue 75808] to-be-m207: sfx2/source/ap pl/shutdownicon.cxx:886: warning: 'bState' may be used uninitialized in this function

2007-03-28 Thread pjanik
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=75808


User pjanik changed the following:

What|Old value |New value

  Status|RESOLVED  |CLOSED





--- Additional comments from [EMAIL PROTECTED] Wed Mar 28 08:41:53 + 
2007 ---
verified, closing.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[porting-issues] [Issue 75808] to-be-m207: sfx2/source/ap pl/shutdownicon.cxx:886: warning: 'bState' may be used uninitialized in this function

2007-03-28 Thread rt
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=75808


User rt changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from [EMAIL PROTECTED] Wed Mar 28 08:38:30 + 
2007 ---
Fixed for SRC680 m207.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[porting-issues] [Issue 75808] to-be-m207: sfx2/source/ap pl/shutdownicon.cxx:886: warning: 'bState' may be used uninitialized in this function

2007-03-28 Thread pjanik
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=75808





--- Additional comments from [EMAIL PROTECTED] Wed Mar 28 08:31:14 + 
2007 ---
new sal_Bool is always sal_False anyway.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[porting-issues] [Issue 75808] to-be-m207: sfx2/source/ap pl/shutdownicon.cxx:886: warning: 'bState' may be used uninitialized in this function

2007-03-28 Thread rt
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=75808


User rt changed the following:

What|Old value |New value

  CC|''|'as'





--- Additional comments from [EMAIL PROTECTED] Wed Mar 28 08:27:46 + 
2007 ---
Andreas, can you confirm that 'false' is the correct initialization value here?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[porting-issues] [Issue 75808] to-be-m207: sfx2/source/ap pl/shutdownicon.cxx:886: warning: 'bState' may be used uninitialized in this function

2007-03-28 Thread pjanik
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=75808
 Issue #|75808
 Summary|to-be-m207: sfx2/source/appl/shutdownicon.cxx:886: war
|ning: 'bState' may be used uninitialized in this funct
|ion
   Component|porting
 Version|680m206
Platform|All
 URL|
  OS/Version|Mac OS X
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|TASK
Priority|P3
Subcomponent|MacOSX
 Assigned to|rt
 Reported by|pjanik





--- Additional comments from [EMAIL PROTECTED] Wed Mar 28 08:14:17 + 
2007 ---
/Users/pavel/BUILD/X11/BuildDir/ooo_SRC680_m207_src/sfx2/source/appl/shutdownicon.cxx:886:
 
warning: 'bState' may be used uninitialized in this function

This fixes it:

--- shutdownicon.cxx27 Mar 2007 20:35:07 +0200  1.55
+++ shutdownicon.cxx28 Mar 2007 10:12:44 +0200  
@@ -883,7 +883,7 @@
 case PROPHANDLE_TERMINATEVETOSTATE :
  {
 // use new value in case it's a valid information only
-::sal_Bool bState;
+::sal_Bool bState = sal_False;
 if (! (aValue >>= bState))
 return;

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]