[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User pjanik changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from [EMAIL PROTECTED] Fri Dec 21 20:33:06 + 2007 --- Closing. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User cloph changed the following: What|Old value |New value CC|'fme,mba,mod' |'cloph,fme,mba,mod' Status|RESOLVED |VERIFIED Keywords| |oooqa --- Additional comments from [EMAIL PROTECTED] Sun Nov 11 12:56:15 + 2007 --- verified. No breaker when warnings=errors when building sw on Mac OSX (Tiger), change of CurTOXType is in the cws as discussed in this issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Sat Nov 3 12:48:50 + 2007 --- OK, the work is finished now. Any volunteer for QA? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=81574
--- Additional comments from [EMAIL PROTECTED] Tue Oct 30 08:54:49 +
2007 ---
fme-pjanik: Looks good for me. Just one (minor) issue: Couldn't we use
CurTOXType () : eType (TOX_INDEX), nIndex (0) {};
instead of
CurTOXType () : eType (static_castTOXTypes(0)), nIndex (0) {};?
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User pjanik changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Tue Oct 30 09:07:34 + 2007 --- fme: definitely. Fixed in pj86. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 29 12:05:25 + 2007 --- mba, fme: what do you think about the change done in cws pj86? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 29 13:02:40 + 2007 --- Pavel, you shouldn't work on issues while watching the ESC meeting. :-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 29 13:08:25 + 2007 --- I was actually waching you eating the sandwich ;-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Thu Oct 25 11:08:50 + 2007 --- fme, mba: what is your opinion on the proposed patch in the previous comment? Let's move this forward. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Thu Oct 25 11:13:16 + 2007 --- Frank has already commented on that: without providing a useful default ctor the problem wouldn't go away, just the compiler would be silenced. I think that making code warning free shouldn't mean just to get rid of the warnings but also to improve the code. So I second Frank's opinion. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Thu Oct 25 11:20:55 + 2007 --- So you are OK if this particular change affects all users of it? I was maybe trying to be very safe ;-) But the patch in the last comment even fixes the initialization... None commented it. I'd like to be on the safe side... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Thu Oct 25 11:26:55 + 2007 --- It can't be wrong to remove the usage of uninitialized variables. So I prefer the complete solution (implement ctor for CurTOXType that sets all members to a proper value). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=81574
--- Additional comments from [EMAIL PROTECTED] Thu Oct 25 12:53:00 +
2007 ---
OK, so I have did the following in pj86 now (compared to the base milestone of
the cws):
1. added implicit constructors:
+CurTOXType () : eType (static_castTOXTypes(0)), nIndex (0) {};
+CurTOXType (TOXTypes t, USHORT i) : eType (t), nIndex (i) {};
2. I changed one definition to use the constructor instead of struct
initialization, because that is an
error now with constructor:
- CurTOXType eCurType = {eSet, 0};
+ CurTOXType eCurType (eSet, 0);
3. removed extra (now it is extra ;-) initialization:
CurTOXType eRet;
- eRet.nIndex = 0;
Please review in pj86. Touched files:
sw/source/ui/inc/cnttab.hxx
sw/source/ui/index/cnttab.cxx
Thanks for your help. I think it is now even better solution ;-)
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User mod changed the following: What|Old value |New value CC|'fme,mba' |'fme,mba,mod' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 15 07:16:56 + 2007 --- fme: I still don't know what was the compiler's error message in cnttab.cxx (see 2007-10-08)? My proposal was to add an inline default constructor. What is CurTOXType eRet = CurTOXType(); supposed to do, anyway? It creates a temporary CurTOXType object and assigns the temporary object to eRet. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 15 07:20:50 + 2007 --- fme: ah :-) The original warning is that eRet's eType might be used uninitialized: /Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m233_src/sw/source/ui/index/cnttab.cxx: In function 'CurTOXType lcl_UserData2TOXTypes(sal_uInt16)': /Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m233_src/sw/source/ui/index/cnttab.cxx:1235: warning: 'eRet$eType' may be used uninitialized in this function Thus CurTOXType eRet = CurTOXType(); properly initializes it. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 15 07:40:00 + 2007 --- fme-pjanik: Well, from my point of view eRet.eType is still uninitialized after CurTOXType eRet = CurTOXType(), only the compiler doesn't complain anymore. So I still suggest to add a default inline constructor for struct CurTOXType. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=81574
--- Additional comments from [EMAIL PROTECTED] Mon Oct 15 07:54:50 +
2007 ---
I didn't want to change the struct for all its users, but if you think it is
better... :-)
The other, most safest way is:
Index: cnttab.cxx
===
RCS file: /cvs/sw/sw/source/ui/index/cnttab.cxx,v
retrieving revision 1.73
diff -u -u -r1.73 cnttab.cxx
--- cnttab.cxx 27 Sep 2007 12:17:04 - 1.73
+++ cnttab.cxx 15 Oct 2007 07:53:44 -
@@ -1234,6 +1234,7 @@
{
CurTOXType eRet;
eRet.nIndex = 0;
+ eRet.eType = static_castTOXTypes(0);
switch(nData0xff)
{
case TO_INDEX : eRet.eType = TOX_INDEX; break;
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User pjanik changed the following: What|Old value |New value Status|NEW |STARTED --- Additional comments from [EMAIL PROTECTED] Sat Oct 13 13:07:29 + 2007 --- CWS pj86 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Sat Oct 13 14:06:06 + 2007 --- It seems that fme didn't follow up on the CurTOXType, we should clarify this. Besides that there are no more questions from our side and you can go ahead. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Fri Oct 12 20:18:17 + 2007 --- mba, fme: so? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 10:55:50 + 2007 --- fme-pjanik: What milestone does this patch base on? swtable.cxx does not need to be patched, since the bFirst parameter has been renamed to bFirstPart. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User pjanik changed the following: What|Old value |New value CC|'mba' |'fme,mba' --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 11:11:33 + 2007 --- fme: please read cws, not the attached patch which is old. CWS is based on m231 and the rename is reflected there. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 11:29:25 + 2007 --- fme-pjanik: Two remarks from my side: 1. Can't we use 0 instead of sal_Unicode() as proposed by ericb? 2. cnttab.cxx: Add an inline default constructor to CurTOXType - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 11:34:20 + 2007 --- fme: 1. no problem. Using T() is always safer though. 2. why? 8) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 11:58:34 + 2007 --- Pavel, I hope you don't mind: it's unfortunate to have only a patch attached that doesn't reflect the real code in the CWS. Perhaps having a current patch attached would be better. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 12:01:48 + 2007 --- Attaching the current state of pj86 is useless, because it is in the cws pj86 anyway. But ok, I'll attach it 8) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User pjanik changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |48752) current status of p | |j86 - patch --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 12:09:10 + 2007 --- Created an attachment (id=48752) current status of pj86 - patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 12:20:36 + 2007 --- fme-pjanik: Sorry, looks like I missed the point. So what was the problem with cnttab.cxx? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 12:24:30 + 2007 --- fme: there were no problems ;-) I just wanted to review pj86's changes in module sw as I wrote at Sat Oct 6 18:40:04 + 2007. Then mba thought I wanted to review the patch, etc.etc. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 12:41:21 + 2007 --- Pavel, you confuse me. :-) How do the changes in the CWS differ from the attached patch? I just asked for the patch as it can be reviewed easier and faster than checking out the CWS and do the diffs manually. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 12:45:57 + 2007 --- mba :-)) The second attached patch is a manually done diff from the cws approx. 1 minute before the time of attaching it. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Mon Oct 8 13:50:28 + 2007 --- That was my understanding also. But obviously I misunderstood your latest comment because it seemed to differentiate between the CWS and the patch. Now it's clear. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Sun Oct 7 08:31:16 + 2007 --- *** Issue 82344 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User pjanik changed the following: What|Old value |New value CC|''|'mba' --- Additional comments from [EMAIL PROTECTED] Sat Oct 6 18:40:04 + 2007 --- mba: Can you or someone else from Word Processor team review the changes in module sw in pj86? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Sat Oct 6 18:48:05 + 2007 --- Thanks for the patch. I will try to get that reviewed as fast as possible as we want to have such big changes integrated as early in the release cycle as possible. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Fri Oct 5 14:21:11 + 2007 --- *** Issue 82310 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Fri Oct 5 14:21:41 + 2007 --- *** Issue 82310 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Fri Oct 5 14:21:33 + 2007 --- *** Issue 82310 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Fri Oct 5 14:18:54 + 2007 --- *** Issue 82310 has been marked as a duplicate of this issue. *** --- Additional comments from [EMAIL PROTECTED] Fri Oct 5 14:20:26 + 2007 --- *** Issue 82310 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=81574
--- Additional comments from [EMAIL PROTECTED] Fri Oct 5 19:20:47 +
2007 ---
@pkjanik :
In
sw/source/core/doc/number.cxx ( @@ -1263,7 +1263,7 @@ )
sw/source/core/unocore/unoobj2.cxx ( @@ -582,7 +582,7 @@ )
You used :
-sal_Unicode cChar;
+sal_Unicode cChar = sal_Unicode();
And I don't understand the initialization using Sal_Unicode()
Reading sal/inc/sal/types.h, and if I'm not wrong, I understand Sal_Unicode is
sal_uInt16, and the first
initialization value I have in mind is 0 (NULL works, but probably not on all
systems)
Good catch in sw/source/core/table/swtable.cxx ( @@ -1500,7 +1500,7 @@ )
sw/source/filter/xml/xmltexte.cxx ( @@ -392,7 +392,7 @@ ), instead of :
-sal_Bool bIsAutoScroll, bIsScrollingMode;
+sal_Bool bIsAutoScroll = sal_False, bIsScrollingMode;
I used :
-sal_Bool bIsAutoScroll, bIsScrollingMode;
+ sal_Bool bIsAutoScroll = sal_False;
+ sal_Bool bIsScrollingMode = sal_False;
But this is cosmetic change
Same a bit later, in the same file ( @@ -401,7 +401,7 @@ )
-sal_Bool bIsBorderSet, bIsAutoBorder;
+sal_Bool bIsBorderSet, bIsAutoBorder = sal_False;
Good catch too for:
sw/source/ui/index/cnttab.cxx 2007-09-14 11:58:31.0 +0200
@@ -1232,7 +1232,7 @@
//-
CurTOXType lcl_UserData2TOXTypes(sal_uInt16 nData)
{
- CurTOXType eRet;
+ CurTOXType eRet = CurTOXType();
(I was stuck with it )
For all other changes, I completely agree ( I did the same in my own patch )
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User ericb changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |48717) The log of pj86 bui | |ld in sw --- Additional comments from [EMAIL PROTECTED] Fri Oct 5 19:21:36 + 2007 --- Created an attachment (id=48717) The log of pj86 build in sw - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 --- Additional comments from [EMAIL PROTECTED] Fri Oct 5 19:22:50 + 2007 --- To comment the log, they are still some warnings, but most of the work has been done. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 Issue #|81574 Summary|WaE on Mac OS X: sw Component|porting Version|680m222 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|MacOSX Assigned to|pjanik Reported by|pjanik --- Additional comments from [EMAIL PROTECTED] Fri Sep 14 08:16:22 + 2007 --- After swwarnings cws integration, make sw WaE free on Mac OS X as well. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User pjanik changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |48234) tentative patch --- Additional comments from [EMAIL PROTECTED] Fri Sep 14 11:02:33 + 2007 --- Created an attachment (id=48234) tentative patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 81574] WaE on Mac OS X: sw
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81574 User pjanik changed the following: What|Old value |New value Issue type|DEFECT|PATCH Target milestone|--- |OOo 2.4 --- Additional comments from [EMAIL PROTECTED] Fri Sep 14 11:04:08 + 2007 --- Tentative patch attached. TODO: 1. Once swwarnings cws is integrated, create proper patch and let Word Processor people review it. 2. patch-out sw from unxmacx.mk - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
