[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User amy2008 changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from amy2...@openoffice.org Tue Apr 14 07:01:39 + 2009 --- Verified in Ooo310m9 on WinXP and Fedora Closing Li Meiying - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User oc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from o...@openoffice.org Wed Dec 17 09:55:46 + 2008 --- verified in internal build cws_odff05 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from o...@openoffice.org Wed Dec 17 09:55:08 + 2008 --- Created an attachment (id=58881) Testdocuments for Test Case Specification - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from o...@openoffice.org Wed Dec 17 09:53:56 + 2008 --- Created an attachment (id=58880) TestCaseSpecification - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User er changed the following: What|Old value |New value Assigned to|er|oc --- Additional comments from [EMAIL PROTECTED] Thu Dec 11 14:22:57 + 2008 --- Reassigning to QA for verification. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User er changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Tue Dec 9 13:53:38 + 2008 --- Fixed in CWS odff05. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Fri Nov 28 11:19:46 + 2008 --- *** Issue 96682 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Fri Oct 24 01:29:47 + 2008 --- Tested issue 95176, the result is right in the version with patch of i46681. :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Thu Oct 23 13:50:15 + 2008 --- Test case from issue 95176: http://www.openoffice.org/nonav/issues/showattachment.cgi/57284/Example.xls - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Thu Oct 23 13:48:24 + 2008 --- *** Issue 95176 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Thu Sep 11 10:10:08 + 2008 --- FYI: cleaned up naming, meaning and usage of ScMatrix::Is...Type(ScMatValType) sc/inc/scmatrix.hxx 1.11.148.2 sc/source/core/data/validat.cxx 1.24.110.1 sc/source/core/tool/interpr1.cxx 1.60.54.2 sc/source/core/tool/interpr4.cxx 1.57.98.1 sc/source/core/tool/interpr5.cxx 1.33.36.2 sc/source/core/tool/scmatrix.cxx 1.17.136.2 sc/source/filter/excel/xehelper.cxx 1.31.148.1 sc/source/filter/xml/XMLExportDDELinks.cxx 1.18.148.1 Please cvs update your CWS. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Thu Sep 11 01:47:41 + 2008 --- Hi Eike, yes, I checked those Is...(). since they are changed, I thought they should also be checked. don't worry. :) Yue - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Wed Sep 10 22:31:05 + 2008 --- Hi Yue, great! I think I did not mention it explicitly, but did you also check for places that use IsEmpty(), IsEmptyPath(), IsString(), IsValue() and such , without Get...() being near around? Anyway, I applied the latest revision of the patch in cws odff05: sc/inc/scmatrix.hxx 1.11.148.1 sc/source/core/inc/jumpmatrix.hxx 1.6.148.1 sc/source/core/tool/interpr1.cxx 1.60.54.1 sc/source/core/tool/interpr5.cxx 1.33.36.1 sc/source/core/tool/scmatrix.cxx 1.17.136.1 maybe this will need some further correction for new findings. Please cvs update your cws odff05 and base new patches on the update. Thanks Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Tue Sep 9 08:52:26 + 2008 --- Hi Eike, I have checked all functions in ScInterpreter that call Put... and Get... and I did not find a function that need to be changed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Wed Aug 27 13:07:23 + 2008 --- @lvyue: forgot to mention that I also negated the logic in ScInterpreter::ScMatRef() to simplify the condition for the PushNA(). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User er changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |56049) fixes, enhancements | | and comments --- Additional comments from [EMAIL PROTECTED] Wed Aug 27 13:03:14 + 2008 --- Created an attachment (id=56049) fixes, enhancements and comments - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User er changed the following: What|Old value |New value Subcomponent|code |programming --- Additional comments from [EMAIL PROTECTED] Wed Aug 27 13:01:45 + 2008 --- @lvyue: I'll attach a patch created against CWS odff05 based on DEV300_m29, please checkout CWS odff05 and continue further work based on the new patch. As discussed on IRC, please investigate interpreter methods whether special handling similar to MatAdd() and such is needed for other functions as well. Changes I did in the patch: In ScInterpreter::JumpMatrix() the conditions to check for replication were overcomplicated, at least in the case of svMatrix that was wrong and lead to access of invalid matrix positions. Btw, this was caught by an assertion about a matrix dimension error, I strongly suggest you use a non-product build to get assertions displayed, please invoke configure with --enable-dbgutil before a clean build from scratch. I changed the condition, for example, to if ((nCols <= nC && nCols != 1) || (nRows <= nR && nRows != 1)) to catch the case for NOTAVAILABLE, also changed errNoValue to NOTAVAILABLE for these cases to be consistent with MatRef() and Excel. Similar for svDoubleRef, also the original range must not be changed by using ScAddress& rAdr = aRange.aStart; rAdr.SetCol(...); see also the comments I added there. Introduced ScMatrix::ValidColRowOrReplicated(nCol,nRow) to replace (ValidColRow(nCol,nRow) || ValidColRowReplicated(nCol,nRow)) for better readability and less typing effort ;-) Simplified the conditionals in ValidColRowReplicated(), some checks were done twice. Same in ScJumpMatrix::GetJump(), also added cleanup and an assertion there for the case that invalid nCol/nRow was passed, otherwise arbitrary memory could had been accessed in pJump[]. In interpr5.cxx introduced lcl_GetMinExtent() to not repeat all the conditionals for nMinC=..., nMinR=... over and over again in MatAdd() and the like. Looking forward to your findings whether further changes are necessary in other interpreter functions. Thanks Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Wed Aug 13 03:53:29 + 2008 --- Created an attachment (id=55731) patch 6, slightly changed from patch 5. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Mon Aug 4 11:40:05 + 2008 --- Issue 92402 has another fine test case example attached, http://www.openoffice.org/nonav/issues/showattachment.cgi/55506/Issue%2092402.ods - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Sat Aug 2 14:37:54 + 2008 --- *** Issue 92402 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User maoyg changed the following: What|Old value |New value OtherIssuesDependingOnTh| |72764 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Wed Jul 2 07:45:14 + 2008 --- Created an attachment (id=54878) patch 5. :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Thu Jun 12 02:37:27 + 2008 --- Created an attachment (id=54412) patch4. Filled the regions that remain after copying. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Wed Jun 11 02:46:38 + 2008 --- Hi Eike, This is the third patch, including all the changes I made. And, so far, I found these affected functions: +, -, * , /, ^, &, =, <>, >, <, >=, <=, TRANSPOSE(), and IF(). Please check this patch. Thanks. PS: I have add 'd' to 'Ajust'. :P Yue - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Wed Jun 11 01:53:45 + 2008 --- Created an attachment (id=54383) patch 3. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User er changed the following: What|Old value |New value Target milestone|OOo 3.0 |OOo 3.1 --- Additional comments from [EMAIL PROTECTED] Wed Jun 4 09:01:20 + 2008 --- This may need more time than available until QA for 3.0 code freeze, retargeting to 3.1 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Tue Jun 3 21:58:39 + 2008 --- Hi Yue, The approach looks viable in general. Some comments: In real life (see remarks further down about copying methods), the implementation of SetNewResMat() in the final version should not be in the header file, but in a newly to be created jumpmatrix.cxx instead. Header files should contain only relatively short inline methods. The nested for() loops wouldn't necessarily be inlined by most compilers anyway. The method is also quite rarely called, so we wouldn't gain anything but increase compile time instead each time the header file is parsed. Instead of ScMatrix* pNewMat = new ScMatrix(... [...] ScMatrix* p = pMat; pMat = pNewMat; p->Delete(); use ScMatrixRef xNewMat = new ScMatrix(... [...] pMat = xNewMat; Reason is that ScMatrixRef does refcount the ScMatrix, the pMat member variable is also a ScMatrixRef, and by directly calling Delete() on the pointer you interfere with the refcounting mechanism and may actually doubly delete the matrix that was already released during the assignment to pMat. The copying code for (SCSIZE nC = 0; nC < nResMatCols; nC++) for (SCSIZE nR = 0; nR < nResMatRows; nR++) is error prone; in case we added more type functionality to ScMatrix it would had to be adapted and might easily get overlooked. It already omits the IsEmptyPath() case ;-) Better create a ScMatrix member method that copies the desired portion similar to ScMatrix::MatCopy(), which would be faster as well. If you also add a method ScMatrix::CloneAndExtend(nNewCols,nNewRows) or so, similar to ScMatrix::Clone(), most code of ScJumpMatrix::SetNewResMat() could be moved into these two methods, and SetNewResMat() could remain inline in the header file. Btw, last nitpick for now is a spelling error, Ajust should be written with a 'd': Adjust ;) Hope that helps. Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Tue Jun 3 07:59:53 + 2008 --- Hi Eike, In patch 2, I made some change for IF(). Applied the dynamic way to decide dimensions. the biggest change is in class ScJumpMatrix, I don't know if such change is acceptable. It works well in IF() now. :) Please check this patch. Thanks. Yue - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Tue Jun 3 07:50:12 + 2008 --- Created an attachment (id=54198) patch 2. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Fri May 9 21:09:38 + 2008 --- Strange request ;-) anyway, replied per mail. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Fri May 9 11:55:58 + 2008 --- Hi Eike, I have a question about my system, but I'm not in office, so I can only ask you here. :) I'm thinking about switching my operating system to Linux, and change the milestone together. But there are so many Linux, I wonder which is better for our development, and which one are you using. And about ODFF, which milestone should I use? I hope I didn't bring you many trouble. :P Thank you! :) Yue - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 --- Additional comments from [EMAIL PROTECTED] Tue May 6 08:35:50 + 2008 --- Created an attachment (id=53407) Changed a few functions, just for checking. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User lvyue changed the following: What|Old value |New value CC|'drking' |'drking,lvyue' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 46681] ODFF: Repeat values of sin gle array vector if used in second array dimen sion
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46681 User er changed the following: What|Old value |New value Summary|Repeat values of single ar|ODFF: Repeat values of sin |ray vector if used in seco|gle array vector if used i |nd array dimension|n second array dimension --- Additional comments from [EMAIL PROTECTED] Mon Mar 3 11:56:06 + 2008 --- Yes, this is about that ;) Adding ODFF to summary. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
