[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 User oc changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from [EMAIL PROTECTED] Fri Oct 17 09:18:14 + 2008 --- closed because fix available in builds OOO300_m9 and DEV300_m33 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 User oc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Mon Jun 9 11:26:26 + 2008 --- verified in internal build cws_odff3 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 User er changed the following: What|Old value |New value Assigned to|er|oc --- Additional comments from [EMAIL PROTECTED] Fri May 9 16:38:17 + 2008 --- Reassigning to QA for verification. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=74245
User er changed the following:
What|Old value |New value
Status|STARTED |RESOLVED
Resolution| |FIXED
--- Additional comments from [EMAIL PROTECTED] Wed Apr 23 21:19:38 +
2008 ---
In cws odff03:
sc/source/core/tool/interpr1.cxx 1.56.20.6
Several changes were necessary:
Loading the attached test case document in a non-product gave lots of
Error: ScMatrix::GetDouble: dimension error
From File .../odff03/DEV300/src.m3/sc/source/core/tool/scmatrix.cxx at Line 430
because nDelta==-1 if no value was found (already the first item greater
than query) and nFirst==0
if (nLen == 1) // first and last items are next to each other.
{
nDelta = nCmp 0 ? nLast - 1 : nFirst - 1;
These cases then showed up as not being identical to Excel results.
In case the result array was shorter than the lookup array an off-bounds
memory access happened with pResMat-Get...(nDelta), returning an
arbitrary value if lucky ;-) and pResMat-IsValue(nDelta) returned TRUE
before. Also showed up as not being identical to Excel results in cells
B70:B71 (0 displayed instead of #N/A).
Introduced handling of mixed numeric/string of both query and matrix
element and empty matrix element in lcl_CompareMatrix2Query()
Introduced handling of mixed numeric/string/empty matrix elements in
lcl_GetLastMatch(), also there the result was arbitrary for
a rMat.GetDouble() if the element was a string instead, usually not
identical though to the value to be matched, so it wasn't obvious.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 --- Additional comments from [EMAIL PROTECTED] Mon Apr 14 05:00:24 + 2008 --- I guess there shouldn't be any negative impact by these changes, correct? I think the change you're suggesting is the right one. Please go ahead with the change. :-) Kohei - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 --- Additional comments from [EMAIL PROTECTED] Fri Apr 11 18:48:58 + 2008 --- Hi Kohei, I have some doubt about a detail of the latest patch. In lcl_CompareMatrix2Query() this if (rStr1 == rStr2) return 0; return rStr1 rStr2 ? -1 : 1; changed to return rStr1.CompareIgnoreCaseToAscii(rStr2); // case-insensitive As the method name says that works only for ASCII strings. To make that work with Unicode, either collation or transliteration have to be used. As the comparison is done in a binary search on data that is assumed to be sorted, using ScGlobal::pCollator-compareString() should be appropriate. lcl_CompareMatrix2Query() is also used in ScInterpreter::ScMatch(), I guess there shouldn't be any negative impact by these changes, correct? Thanks Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 --- Additional comments from [EMAIL PROTECTED] Wed Feb 13 12:33:44 + 2008 --- Thank you, Kohei! You mentioned cases that are probably not covered by the ODFF spec. Could you please give details, so I can add those to the specification? Thanks Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 --- Additional comments from [EMAIL PROTECTED] Wed Feb 13 16:28:31 + 2008 --- Ok, here is my note. Let me just copy-n-paste. --- * 2-parameter case ([lookup value], [lookup-result matrix]) * The search direction, either horizontal-search or vertical-search, is determined from the dimensions of the matrix; if the data matrix is wider than taller, the search direction is horizontal, and if it is taller than wider, the direction is vertical. If the data matrix is a square, the search direction is vertical. * In vertical search mode, only the first column gets searched, and the last column is used as the result array. Those columns that are not either the first nor the last are simply not used. In case of a one-column matrix, the search column and the result column are identical. These rules also apply in horizontal search mode but to rows instead of columns. * 3-parameter case ([lookup value], [lookup matrix], [result matrix(vector)]) * The result matrix must be a vector, or it raises an error. * The lookup matrix does not need to be a vector. If it's not a vector only the first column or row gets searched (= search vector). [NOTE: the ODFF spec requires this to be a vector, but Excel does not.] * The search direction is determined from the dimensions of the lookup matrix. The same rules as the 2-parameter case apply. * The directions of the lookup matrix and the result matrix can differ. [NOTE: the ODFF spec does not mention this.] * The lengths of the search vector and the result vector do not need to be identical; however, when the match position falls outside the length of the result vector, an error is raised if the result vector is given as an array object. If it's a cell range, it gets automatically extended to the length of the searched vector. If the cell range cannot be extended due to size limit, then '0' is displayed. [NOTE: the ODFF spec requires the search vector and the result vector to be of the same length.] --- The spec covers the 2-parameter case pretty well, and my note reveals nothing new here. But for the 3-parameter case there are some behaviors of Excel that are not mentioned or not accurately depicted in the ODFF spec. Actually I have a new patch to cover the last item of my note. I'll attach it here shortly. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 User kohei changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |51498) revised patch --- Additional comments from [EMAIL PROTECTED] Wed Feb 13 16:29:53 + 2008 --- Created an attachment (id=51498) revised patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 --- Additional comments from [EMAIL PROTECTED] Wed Feb 13 18:04:53 + 2008 --- I wish to thank all of you for efforts in resolving this. We are hoping to migrate to the NeoOffice flavor of OpenOffice within the next year. It is efforts like these that make this more possible. Karl - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 User kohei changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |51485) patch --- Additional comments from [EMAIL PROTECTED] Wed Feb 13 04:13:17 + 2008 --- Created an attachment (id=51485) patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 User kohei changed the following: What|Old value |New value Issue type|DEFECT|PATCH --- Additional comments from [EMAIL PROTECTED] Wed Feb 13 04:17:45 + 2008 --- This patch is against CWS odff (base m244). Hopefully I've covered all the Excel's behaviors. That test document covers a wide range of scenarios, and with this patch, Calc's LOOKUP behave identically to Excel's under the scenarios tested in the document. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 --- Additional comments from [EMAIL PROTECTED] Wed Feb 13 04:11:32 + 2008 --- Created an attachment (id=51484) test document - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 --- Additional comments from [EMAIL PROTECTED] Tue Feb 12 01:22:08 + 2008 --- I'm working on this currently. There are more undocumented behaviors of Excel than just the column vs row direction. I'm trying to uncover all that. Since this involves a matrix handling, it will be a bit tricky to get it all covered. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 User pagalmes changed the following: What|Old value |New value CC|'cianoz,kohei'|'cianoz,kohei,pagalmes' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 User kohei changed the following: What|Old value |New value CC|'cianoz' |'cianoz,kohei' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 74245] ODFF: LOOKUP in columns if range is wider than tall
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=74245 User er changed the following: What|Old value |New value Keywords| |ms_interoperability Summary|LOOKUP in columns if range|ODFF: LOOKUP in columns if | is wider than tall | range is wider than tall Target milestone|OOo 3.x |OOo 3.0 --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 16:26:32 + 2007 --- ODFF relevant. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
