[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=83367 User iha changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from i...@openoffice.org Wed Aug 25 11:25:01 + 2010 --- seen ok in ooo330m4 - closing - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=83367 User mba changed the following: What|Old value |New value Assigned to|mba |iha --- Additional comments from m...@openoffice.org Thu Jun 3 09:58:06 + 2010 --- please verify - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=83367 --- Additional comments from i...@openoffice.org Thu Jun 3 17:14:25 + 2010 --- Created an attachment (id=69795) example document with macro showing the problem - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=83367 User iha changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from i...@openoffice.org Thu Jun 3 17:16:54 + 2010 --- Verified in CWS mba33issues01 as follows: Run the macro in the attached document. It adds a chart with an empty name. With this fix the Navigator does list the chart and it is still available after save and reload. Thanks! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=83367 User mba changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from m...@openoffice.org Tue May 18 13:12:55 + 2010 --- Hm, seems that we forgot about this one. The reason for the change was that the aNameString was a const String, so it needed to be copied first. Of course then the assignment of aObjName is wrong, it should be an assignment to aTmp; - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=83367 User mba changed the following: What|Old value |New value Target milestone|--- |OOo 3.3 --- Additional comments from m...@openoffice.org Tue May 18 15:53:29 + 2010 --- target 3.3 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=83367
User bm changed the following:
What|Old value |New value
Assigned to|bm|mba
--- Additional comments from [EMAIL PROTECTED] Mon Nov 26 09:57:12 +
2007 ---
-MBA: Well, the old code was:
if ( SvtModuleOptions().IsChart() )
xObj = pDocShell-GetEmbeddedObjectContainer().CreateEmbeddedObject(
SvGlobalName( SO3_SCH_CLASSID ).GetByteSequence(), aNameString );
if ( xObj.is() )
{
String aObjName = aNameString; // wirklich eingefuegter Name...
The code after your change is:
::rtl::OUString aTmp( aNameString ); // ! Copy aNameString to a new stack
variable !
if ( SvtModuleOptions().IsChart() )
xObj = pDocShell-GetEmbeddedObjectContainer().CreateEmbeddedObject(
SvGlobalName( SO3_SCH_CLASSID ).GetByteSequence(), aTmp ); // ! Now uses aTmp
instead of aNameString !
if ( xObj.is() )
{
String aObjName = aNameString; // wirklich eingefuegter Name...
So, this was an explicit change NOT to use aNameString in the call to
CreateEmbeddedObject. (aNameString is not used later in the code, and is a
stack-variable, too. That means, introducing aTmp must have had the intention to
apply an unmodified, in the current situation an empty, aNameString in the last
line of this code fragment).
I ask myself: why? And as you did the change, I suppose at least at the time you
did the change, you knew why this was done.
If you don't remember, please forward the issue to Niklas.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=83367 --- Additional comments from [EMAIL PROTECTED] Mon Nov 26 10:06:24 + 2007 --- The general idea is that the internal object name shall not be used before the object is inserted as before that you can't know for sure that this name is unique. So each code that relies on a particular internal object name is broken. So *this* code needs to be fixed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=83367 User mba changed the following: What|Old value |New value Assigned to|mba |bm --- Additional comments from [EMAIL PROTECTED] Thu Nov 15 15:23:39 + 2007 --- I'm not sure if I understand correctly. But if I do - it looks as if String aObjName = aNameString; must be changed to String aObjName = aTmp; aTmp is the name of the object, either as requested or as automatically created. So from what you describe it seems that this is the name that should be used for further treatment. I recommend to hand this over to your favorite Calc developer. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 83367] XTableCharts::addNewByName does not work with empty name
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=83367
Issue #|83367
Summary|XTableCharts::addNewByName does not work with empty na
|me
Component|Spreadsheet
Version|680m235
Platform|All
URL|
OS/Version|All
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|programming
Assigned to|mba
Reported by|bm
--- Additional comments from [EMAIL PROTECTED] Tue Nov 6 13:48:49 +
2007 ---
The API methods XTableCharts::addNewByName() is implemented such that you can
pass an empty string as first parameter. In this case an auto-generated unique
name is used. This no longer works. There is a change in
sc/source/ui/unoobj/chartuno.cxx:237ff :
::rtl::OUString aTmp( aNameString );
if ( SvtModuleOptions().IsChart() )
xObj = pDocShell-GetEmbeddedObjectContainer().CreateEmbeddedObject(
SvGlobalName( SO3_SCH_CLASSID ).GetByteSequence(), aTmp );
if ( xObj.is() )
{
String aObjName = aNameString; // wirklich eingefuegter Name...
[...]
done with revision 1.11.138.2 that drops the auto-generated name in a stack
variable aTmp, and assigns the empty string as object name (wirklich
eingefügter Name).
As a result the chart is visible, but not shown in the navigator. And it can not
be saved.
-mba: I am not sure why you did this change. I believe it is wrong like this,
but as it seems to be an explicit change (and no oversight), you might know why
this was done.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
