[sw-issues] [Issue 106576] wbutton.cxx: bad call to erase

2010-09-23 Thread thorstenziehm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106576


User thorstenziehm changed the following:

What|Old value |New value

Target milestone|OOo 3.3   |OOo 3.x





--- Additional comments from thorstenzi...@openoffice.org Thu Sep 23 
14:22:26 + 2010 ---
OOo 3.3 is in showstopper-mode. This issue doesn't look like a stopper for the
current release. I change the target to OOo 3.x. Please change the target
accordingly when a fix is near to be integrated into a code line or promote it
as stopper issues at the mailing list relea...@openoffice.org, when it is urgent
enough for OOo 3.3.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 106576] wbutton.cxx: bad call to erase

2010-05-22 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106576


User cmc changed the following:

What|Old value |New value

  CC|''|'pl'





--- Additional comments from c...@openoffice.org Sat May 22 16:41:59 + 
2010 ---
poke, do we have a fix for this or will I cook one up ?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 106576] wbutton.cxx: bad call to erase

2010-01-12 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106576


User cmc changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |106602
  is|  |

Target milestone|---   |OOo 3.3





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 106576] wbutton.cxx: bad call to erase

2009-11-03 Thread dcb314
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106576
 Issue #|106576
 Summary|wbutton.cxx: bad call to erase
   Component|Word processor
 Version|DEV300m63
Platform|All
 URL|
  OS/Version|Linux
  Status|UNCONFIRMED
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|DEFECT
Priority|P3
Subcomponent|code
 Assigned to|writerneedsconfirm
 Reported by|dcb314





--- Additional comments from dcb...@openoffice.org Tue Nov  3 12:02:05 
+ 2009 ---
For source code file toolkit/source/layout/vcl/wbutton.cxx,
function Remove, around line 500 is the following code

for ( std::list Window*::iterator it = maAdvanced.begin();
  it != maAdvanced.end(); it++ )
if ( *it == w )
{
lst.erase( it );
return *it;
}

So local variable it iterates over maAdvanced, but it is used
on variable lst. This looks wrong. Maybe the loop should iterate
over lst, not maAdvanced ?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 106576] wbutton.cxx: bad call to erase

2009-11-03 Thread es
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106576


User es changed the following:

What|Old value |New value

 Assigned to|writerneedsconfirm|pl





--- Additional comments from e...@openoffice.org Tue Nov  3 12:05:19 + 
2009 ---
@PL: Please have a look.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 106576] wbutton.cxx: bad call to erase

2009-11-03 Thread pl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106576


User pl changed the following:

What|Old value |New value

 Assigned to|pl|jcn





--- Additional comments from p...@openoffice.org Tue Nov  3 12:21:47 + 
2009 ---
pl-jcn: yes, the way it is it is certainly wrong. Moreover this Remove function
removes it on lst, which is a list passed by value; in other words it removes
the iterator from a temporary object resulting in no net effect aside from
returning not NULL when the passed window was found. I assume lst should have
been a reference instead of value ?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 106576] wbutton.cxx: bad call to erase

2009-11-03 Thread jcn
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106576





--- Additional comments from j...@openoffice.org Tue Nov  3 12:31:56 + 
2009 ---
 I assume lst should have been a reference instead of value ?

@pl: yes, that's what I figure too, looking at this code. 

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org