[sw-issues] [Issue 109921] sw: meaningless tests aga inst NULL
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 User cmc changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from c...@openoffice.org Wed May 26 15:17:31 + 2010 --- integrated DEV300_m79 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 109921] sw: meaningless tests aga inst NULL
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 User mst changed the following: What|Old value |New value CC|''|'mst' Assigned to|mst |cmc --- Additional comments from m...@openoffice.org Thu Apr 29 12:04:50 + 2010 --- please verify - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 109921] sw: meaningless tests aga inst NULL
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 User cmc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from c...@openoffice.org Thu Apr 29 12:14:54 + 2010 --- verified, dead tests removed, logic unchanged - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 109921] sw: meaningless tests aga inst NULL
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 --- Additional comments from m...@openoffice.org Mon Apr 12 09:28:08 + 2010 --- *** Issue 110771 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 109921] sw: meaningless tests aga inst NULL
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 User mst changed the following: What|Old value |New value Assigned to|ama |mst Target milestone|--- |OOo 3.3 --- Additional comments from m...@openoffice.org Wed Mar 17 12:49:22 + 2010 --- at first i was a bit concerned about the change in feshview.cxx, but it seems the return value of GetMarkedSdrObj() is not checked anywhere in that file, so i suppose it works :) the pointer in unotxvw.cxx is completely, err, pointless. thanks for the patch! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 109921] sw: meaningless tests aga inst NULL
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 User mst changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from m...@openoffice.org Wed Mar 17 12:52:00 + 2010 --- fixed in cws sw33bf03: http://hg.services.openoffice.org/hg/cws/sw33bf03/rev/5ef8f3c98a50 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 109921] sw: meaningless tests aga inst NULL
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 Issue #|109921 Summary|sw: meaningless tests against NULL Component|Word processor Version|DEV300m73 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|ama Reported by|cmc --- Additional comments from c...@openoffice.org Mon Mar 8 12:05:08 + 2010 --- in sw/source/core/frmedt/feshview.cxx we first check if (pTmpObj)... ... if (pTmpObj) else foo Seeing as pTmpObj is not null, and is not modified afterwards, the foo branch can never be executed so patch to remove it attached. Similarly in sw/source/ui/uno/unotxvw.cxx we have... SwWrtShell* pOldSh = m_pView-GetWrtShell(); if (pOldSh) foo Its not possible to pOldSh to not be NULL, so the if doesn't make any real sense. Patch also cleans that up. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 109921] sw: meaningless tests aga inst NULL
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 User cmc changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |68212) clean these up --- Additional comments from c...@openoffice.org Mon Mar 8 12:05:45 + 2010 --- Created an attachment (id=68212) clean these up - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 109921] sw: meaningless tests aga inst NULL
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 User cmc changed the following: What|Old value |New value OtherIssuesDependingOnTh| |106602 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org