[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 User es changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from e...@openoffice.org Mon Jun 7 13:11:33 + 2010 --- Verified in CWS graphite02 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 User sba changed the following: What|Old value |New value CC|'hdu,kstribley,regina'|'hdu,kstribley,regina,sba' Assigned to|sba |es --- Additional comments from s...@openoffice.org Mon May 31 14:46:15 + 2010 --- SBA-ES: Please take over, thx. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 --- Additional comments from h...@openoffice.org Wed May 19 11:59:44 + 2010 --- *** Issue 111277 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 User hdu changed the following: What|Old value |New value CC|'kstribley,regina'|'hdu,kstribley,regina' Assigned to|hdu |sba --- Additional comments from h...@openoffice.org Wed May 12 13:47:17 + 2010 --- @sba: please verify in CWS graphite02 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 User hdu changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from h...@openoffice.org Thu May 6 07:38:44 + 2010 --- Applied the second patch into CWS graphite02. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 --- Additional comments from h...@openoffice.org Thu May 6 05:10:53 + 2010 --- Regarding the topic of the justification emulation layer I mentioned in #desc18 and #desc21: This can be disabled by overriding the AdjustLayout() method from class derived from SalLayout. I saw that GraphiteLayout::AdjustLayout() already does that, but it mostly copied the code from the generic SalLayout justification emulation layer. So the kashidas noticed in #desc17 come from GraphiteLayout::kashidaJustify() instead of the GenericSalLayout::KashidaJustify() which I suspected first. If graphite prefers to do the justification itself just forward the justification request in AdjustLayout() to e.g. gr::Segment::JustifiedSegment(). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 User hdu changed the following: What|Old value |New value OtherIssuesDependingOnTh| |111272 is| | --- Additional comments from h...@openoffice.org Tue May 4 09:40:24 + 2010 --- The patch looks good to me (for CWS graphite02), thanks! @kstribley: should I hgpush+commit the latest patch as it is or do you prefer to commit it yourself? CWS graphite02 should probably also disable the justification emulation layer (described in #desc18) for Graphite layouts if graphite prefers to do the justification itself. Due to Writer writer having unusual opinions on the division of responsibility between the code layers used for justification (issue 108684) this might become tricky though. Feel free to split off an issue for that topic. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 User kstribley changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |69248) Revised patch fixin | |g justification regression | |, includes fix for issue 1 | |11272 --- Additional comments from kstrib...@openoffice.org Mon May 3 06:08:53 + 2010 --- Created an attachment (id=69248) Revised patch fixing justification regression, includes fix for issue 111272 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 --- Additional comments from kstrib...@openoffice.org Mon May 3 06:59:58 + 2010 --- I've noticed that if expanded text is used with Arabic, then Kashida's are introduced for large expansions. This seems to affect both the Graphite code and the ICU code on Linux. Is that actually correct? I don't know any Arabic, but if I compare it with where they are inserted for justification they don't look to be the same positions. @hdu are you able to comment on this? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 --- Additional comments from h...@openoffice.org Mon May 3 09:35:07 + 2010 --- if expanded text is used with Arabic, then Kashida's are introduced for large expansions Yes, for shaping engines that do not bother with topics such as justification OOo has a layer to emulate it on top of the non-justfied layout. This introduces kashidas for scripts that use that method for justification. Graphite does justification itself so the justification-emulation layer should become active. The concept of expanded/condensed spacing in WE/EE itself is a bit dubious and for cursive scripts it IMHO does not make any sense at all. WriterEngine/EditEngine should then either disallow it or they should accumulate the expanded space into the locations suggested by normal justification for this script, i.e. into spaces or into the kashida positions. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 --- Additional comments from h...@openoffice.org Mon May 3 09:37:18 + 2010 --- correction: Graphite does justification itself so the justification-emulation layer should NOT become active. I hope the issue tracker will allow to edit comments one day... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 --- Additional comments from h...@openoffice.org Mon May 3 10:17:56 + 2010 --- I split off issue 111336 for the problem I described above (with cursive scripts and non-zero spacing). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 --- Additional comments from h...@openoffice.org Tue Apr 27 07:21:20 + 2010 --- Thanks! The change looks quite tricky... if it solves both text breaking and displaying non-default spaced text all is well. FWIW, I had a similar problem with text breaking on the Aqua port in the method GetTextBreak() (in vcl/aqua/source/gdi/salatslayout.cxx) which uses native OSX text breaking methods to emulate the unique text breaking semantics expected by Writer and EditEngine. This was be solved by just adapting GetTextBreak(). At the root of the problem there is of course SW and EE having these very un-conventional expectations (issue 108684). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 User kstribley changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |69132) Line breaking patch | | for expanded condensed gr | |aphite text --- Additional comments from kstrib...@openoffice.org Mon Apr 26 17:10:58 + 2010 --- Created an attachment (id=69132) Line breaking patch for expanded condensed graphite text - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 --- Additional comments from kstrib...@openoffice.org Mon Apr 26 17:24:44 + 2010 --- The problem was in the GraphiteLayout::GetTextBreak method. It subtracted the extra character spacing for all glyphs in a run before computing where the Line Break point lay. If the number of characters being tested was much more than the number that could fit, this resulted in line breaking occurring in a much narrower width than it should have been. Originally, I was using Graphite's LineFillSegment object to calculate the line break point, however, this is not possible when extra spacing is being applied per character. I've therefore decided to record the break weights from the Graphite segment when it is first analyzed in the appendCluster method. These can then be used to compute an appropriate break point even when there is extra character spacing. The attached patch fixes the issue for me on Linux and I hope to test it some more on Windows later in the week. It also includes a fix for incorrect rendering of expanded/condensed Graphite text in the preview window of the Character dialog (the expansion/condensation wasn't being applied). PS: I think my previous comment about Padauk being OK was erroneous. Perhaps fallback was confusing the issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 111054] formatting borked for exp anded text with Graphite fonts (spacing, line width)
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=111054 User hdu changed the following: What|Old value |New value Summary|formatting borked for Grap|formatting borked for expa |hite fonts in OOo3.2 (spac|nded text with Graphite fo |ing, line width) |nts (spacing, line width) --- Additional comments from h...@openoffice.org Thu Apr 22 13:08:45 + 2010 --- @kstribley: thanks for looking into this! Indeed, text breaking for expanded or condensed spacing already caused enough trouble for other layout engines in OOo. The severity of this issue is reduced by the small percentage of documents using such non-zero horizontal extra-spacing. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
