[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 --- Additional comments from m...@openoffice.org Thu Oct 14 12:18:28 + 2010 --- @cmc: d'oh! of course you are right! 114412 is now officially my unlucky number... fixed here (but please double-check it): http://hg.services.openoffice.org/hg/cws/sw34bf01/rev/2b2b31b4f97e - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 --- Additional comments from c...@openoffice.org Thu Oct 14 12:24:02 + 2010 --- That seems sane to me, yup - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 --- Additional comments from c...@openoffice.org Wed Oct 13 19:28:15 + 2010 --- um, http://hg.services.openoffice.org/hg/cws/sw34bf01/rev/6e6683f194c5 doesn't make any sense to me. ::std::auto_ptrconst LocaleDataWrapper pLclD; ... if( eLang != SvxLocaleToLanguage( pLclD-getLocale() ) ) ... i.e. dereference of unset pLclD maybe, if( eLang != SvxLocaleToLanguage( aSysLocale.GetLocaleData().getLocale() ) ) is what was intended - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 User mst changed the following: What|Old value |New value CC|''|'mst' Assigned to|mst |dtardon --- Additional comments from m...@openoffice.org Thu Oct 7 10:19:45 + 2010 --- please verify - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 User dtardon changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from dtar...@openoffice.org Thu Oct 7 19:32:10 + 2010 --- looks good - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 --- Additional comments from m...@openoffice.org Thu Sep 9 13:54:54 + 2010 --- @dtardon: you've left the if (...) delete pLclD in the second copy of Str2Double, can't see a reason why only one should be removed, i guess that's an oversight? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 --- Additional comments from dtar...@openoffice.org Thu Sep 9 16:58:31 + 2010 --- dtardon-mst: because pLclD might have been created inside the function: see pLclD = new LocaleDataWrapper(...) a few lines above. (I don't know if that block is still relevant, though. Maybe the condition eLang != SvxLocaleToLanguage( pLclD-getLocale() ) is always false...) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 --- Additional comments from m...@openoffice.org Thu Sep 9 17:04:02 + 2010 --- @dtardon: d'oh, of course, now that you mention it i also see it :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 This issue depends on issue 114409, which changed state: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 User mst changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED Target milestone|--- |OOo 3.4 --- Additional comments from m...@openoffice.org Thu Sep 9 18:38:29 + 2010 --- thanks for removing the code duplication; you have unfortunately introduced a problem that you never expected: the stupid SunStudio C++ compiler can't link sw anymore, because it's stupid and mangles the const that you added to the parameter into the method name, which is afaik not allowed by the C++ standard (for good reasons, because whether a parameter is const/volatile or not is purely an implementation detail). unfortunately it's necessary to adapt the header as well to make stupid Sun C++ happy. so i've fixed that and then refactored a bit more to replace the UGLY BOOL with nice bool and also replaced the other delete with an auto_ptr. fixed in cws sw34bf01 http://hg.services.openoffice.org/hg/cws/sw34bf01/rev/43f603d097e0 http://hg.services.openoffice.org/hg/cws/sw34bf01/rev/6e6683f194c5 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 Issue #|114412 Summary|sw: dubious delete in SwCalc::Str2Double Component|Word processor Version|DEV300m87 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|ama Reported by|dtardon --- Additional comments from dtar...@openoffice.org Wed Sep 8 13:25:12 + 2010 --- There is the following code in BOOL SwCalc::Str2Double( const String rCommand, xub_StrLen rCommandPos, double rVal, const LocaleDataWrapper* const pLclData ) : if( !pLclData pLclD != SvtSysLocale.GetLocaleData() ) delete (LocaleDataWrapper*)pLclD; . The condition is always false because pLclData is assigned from SvtSysLocale::GetLocaleData() if it's 0. I've removed it and refactored the remaining code a bit to get rid of duplicate code. The patch is only applicable if the patch in #i114409# is also applied. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 --- Additional comments from dtar...@openoffice.org Wed Sep 8 13:26:54 + 2010 --- Created an attachment (id=71615) remove the delete and simplify the code a bit - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 User dtardon changed the following: What|Old value |New value IssuesThisDependsOn| |114409 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 --- Additional comments from a...@openoffice.org Wed Sep 8 14:32:27 + 2010 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 --- Additional comments from a...@openoffice.org Wed Sep 8 14:34:08 + 2010 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114412] sw: dubious delete in SwC alc::Str2Double
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 User ama changed the following: What|Old value |New value Assigned to|ama |mst --- Additional comments from a...@openoffice.org Wed Sep 8 14:35:01 + 2010 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
