[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-04-24 Thread er
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090


User er changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  QA contact|[EMAIL PROTECTED] |[EMAIL PROTECTED]

  Resolution|  |FIXED

Subcomponent|code  |programming

Target milestone|OOo Later |OOo 3.0





--- Additional comments from [EMAIL PROTECTED] Thu Apr 24 20:06:59 + 
2008 ---
In cws odff03:

sc/source/core/inc/interpre.hxx  1.32.20.2
sc/source/core/tool/interpr2.cxx  1.35.20.2

Applied last patch as is, except that I added some spaces here and there for
readability ;-) between operators and variable names.

This includes returning values for roots  -1; plus accepting non-integer
PayType other than 0 or 1, with reservation to what the ODFF specification may
define in the end.

@regina: The test case document you attached in rows 9 and 10 has proofs with
comment should be zero, but for various cases it isn't. I assume the should
is to be considered purely mathematical and the difference is within the error
margins of the algorithm used and acceptable?

One more question: does allowing PayType other than 0 or 1 affect the functions
FV, NPER, PMT and PV, would these have to be adapted? Currently they distinguish
between PayType  0.0 and any other value to do different calculations, the
value itself is not included in the calculation.

Many thanks again for your work!

  Eike


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-02-16 Thread regina
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090





--- Additional comments from [EMAIL PROTECTED] Sat Feb 16 20:43:07 + 
2008 ---
I had a closer look at the problem. Gnumeric 1.6.3 (Windows) returns the value 0
if the algorithm doesn't converge. That is not correct. Excel returns an error,
if the calculated value is smaller than -1. I don't think we should follow
Excel, because those values are still solutions to the equation, which is given
in the ODFF spec. Gnumeric shows such values.

What I have done:
(1)
Introduce a test for Nper=0 because ODFF constraints it that way.
(2)
Made a case distinction for Nper integer or not. In ODFF spec it is not yet
decided whether non inter Nper are allowed. If the  non integer Nper will be
forbidden, the case can easily be removed. With this distinction, we get
additional values as they are calculated in Gnumeric.
(3)
Catch special case solution on an extreme.
(4)
Remove setting non zero PayType to 1, because other values than 0 or 1 are
meaningful and can easily be handled. ODFF spec is not precise in that area.

The text includes comments, so that you can enable the statements, if you don't
like to follow my decision concerning PayType or validity of results -1.

Additional remark to ODFF spec: The given equation is not defined for a solution
RATE=0. But such situations are possible. Changing the equation to a version
with geometric series instead of the version with fraction would solve that
problem and force Nper to be integer.

The patches are based on m244 with CWS odff. 

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-02-16 Thread regina
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090





--- Additional comments from [EMAIL PROTECTED] Sat Feb 16 20:44:41 + 
2008 ---
Created an attachment (id=51547)
patch for interpr2.cxx


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-02-16 Thread regina
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090





--- Additional comments from [EMAIL PROTECTED] Sat Feb 16 20:45:20 + 
2008 ---
Created an attachment (id=51548)
patch for interpr.hxx


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-02-16 Thread regina
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090





--- Additional comments from [EMAIL PROTECTED] Sat Feb 16 20:48:18 + 
2008 ---
Created an attachment (id=51549)
Additional test cases including the values of Excel, Gnumeric and OOo2.3.1. The 
examples of the first sheet might be useful as ODFF spec examples too


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-02-04 Thread regina
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090





--- Additional comments from [EMAIL PROTECTED] Mon Feb  4 11:23:30 + 
2008 ---
Created an attachment (id=51352)
version if Nper is allowed to be non integer


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-02-04 Thread regina
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090





--- Additional comments from [EMAIL PROTECTED] Mon Feb  4 11:22:34 + 
2008 ---
Created an attachment (id=51351)
version for constrain Nper to integer


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-02-04 Thread regina
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090


User regina changed the following:

What|Old value |New value

  Issue type|DEFECT|PATCH





--- Additional comments from [EMAIL PROTECTED] Mon Feb  4 11:36:08 + 
2008 ---
Both patches are based on a m240.
In both cases rates that a lower than -1 are rejected. That will give error
cases mostly same to that of excel with the RATE_problem.sxc document.
In addition the oddf constraint Nper0 is integrated and it works correct in
cases, where the Guess or the intermediate result value is at a place with zero
slope, where the current version gives an error.

Please have a look, if you like one of them in content or whether I should
change something in the algorithm.

After you decide, I'll try to transport the solution to a version which is based
on CWS odff. Discussion should be continued on [EMAIL PROTECTED], I think.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-02-04 Thread regina
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090





--- Additional comments from [EMAIL PROTECTED] Mon Feb  4 14:06:09 + 
2008 ---
Created an attachment (id=51357)
Now the correct one, hopefully :)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 15090] RATE function does not wor k properly

2008-01-27 Thread regina
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=15090


User regina changed the following:

What|Old value |New value

  CC|''|'regina'





--- Additional comments from [EMAIL PROTECTED] Sun Jan 27 10:22:00 + 
2008 ---
I'll work on it.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]