[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User mst changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from m...@openoffice.org Fri Nov 5 16:56:02 + 2010 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User mst changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from m...@openoffice.org Thu Oct 7 09:53:39 + 2010 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User mst changed the following: What|Old value |New value CC|'kendy' |'kendy,os' Assigned to|os|mst Status|REOPENED |NEW --- Additional comments from m...@openoffice.org Tue Jul 20 16:54:40 + 2010 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User mst changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED Target milestone|OOo 3.3 |OOo 3.4 --- Additional comments from m...@openoffice.org Tue Jul 20 17:12:42 + 2010 --- re: ama's concerns: 1. the pBLIPType seems to be initialized from OOO_STRING constants only anyway (in DEV300m83) 2. i will believe that this change has a performance impact if somebody shows me a callgrind trace where this makes any difference at all of course i'm not opposed to turning this into an enum, but i can't see any reason not to merge this patch. thanks pmladek/kendy for the patch! fixed in cws sw34bf01 http://hg.services.openoffice.org/hg/cws/sw34bf01/rev/49a9b379e1dc - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User os changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |WORKSFORME --- Additional comments from o...@openoffice.org Tue Oct 27 09:05:38 + 2009 --- rtfatr.cxx has been fixed in cws sb107 (integrated in m47) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User kendy changed the following: What|Old value |New value Status|RESOLVED |REOPENED Resolution|WORKSFORME| --- Additional comments from ke...@openoffice.org Tue Oct 27 09:16:29 + 2009 --- os: Sorry, but apparently not completely (or reversed during integration of something else). This patch still applies in ooo320-m2: http://cgit.freedesktop.org/ooo-build/ooo-build/tree/patches/dev300/warning-string-comparsion-sw.diff - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 --- Additional comments from o...@openoffice.org Tue Oct 27 09:30:07 + 2009 --- -kendy: What's wrong with the line: bool bIsWMF = (const char *)pBLIPType == (const char *)OOO_STRING_SVTOOLS_RTF_WMETAFILE ? true : false; The line in the patch reads: bool bIsWMF = (const sal_Char *)pBLIPType == (const sal_Char *)sRTF_WMETAFILE ? true : false; If I understand the comments correctly the strings should not be compared with strcmp. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 --- Additional comments from pmla...@openoffice.org Tue Oct 27 10:15:12 + 2009 --- -os: The line produces the warning: comparison with string literal results in unspecified behaviour. The string is defined in svtools/source/svrtf/rtfkeywd.hxx as #define OOO_STRING_SVTOOLS_RTF_WMETAFILE \\wmetafile It is not guaranteed that this string is defined only once in the object files, so it is dangerous to compare pointers. I think that it works fine with the most used compilers. Though, this warning is marked as error in openSUSE build system = we need to avoid it. Hmm, my solution with the cast (const sal_Char *) actually just hides the problem. strcmp is not usable (ama knows more details) = we should rework it to use real enums. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User ama changed the following: What|Old value |New value Assigned to|ama |os Status|REOPENED |NEW --- Additional comments from a...@openoffice.org Fri Oct 16 15:04:44 + 2009 --- -os: Please have a look - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 --- Additional comments from pmla...@openoffice.org Fri Oct 16 15:21:43 + 2009 --- JFYI: htmlforw.cxx seems to be already fixed using enum in dev300-m60. rtfatr.cxx seems to be still broken. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User kendy changed the following: What|Old value |New value Status|CLOSED|REOPENED Resolution|FIXED | --- Additional comments from ke...@openoffice.org Thu Oct 15 22:12:21 + 2009 --- This is still a valid issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User kendy changed the following: What|Old value |New value Target milestone|OOo 3.0 |OOo 3.3 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 --- Additional comments from [EMAIL PROTECTED] Wed Jun 18 10:14:14 + 2008 --- ama-kendy: I didn't like the first patch of Petr because for 15 occurrences of pType it is used just like an enum and strcmp looked a little bit oversized for me. So I would appreciate if you change the code to real enum. But there is one occurrence of pType where it is not used as enum, the string itself is used, so you'll need to adjust this a little bit. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User kendy changed the following: What|Old value |New value CC|''|'kendy' --- Additional comments from [EMAIL PROTECTED] Mon Jun 16 08:21:47 + 2008 --- ama: Hmm, after integration of 86772, the assumption that pType is 'like enum' is not true any more; we should really go with Petr's first patch I guess (or change the code so that pType really _is_ an enum). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User ama changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Mon May 19 12:04:58 + 2008 --- Verified. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User ama changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Wed Apr 23 15:07:44 + 2008 --- ama-pmladek: Thank you for your patch! Fixed in CWS sw30bf04. rtfatr.cxx htmlforw.cxx - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User pmladek changed the following: What|Old value |New value Assigned to|pmladek |ama --- Additional comments from [EMAIL PROTECTED] Tue Apr 22 15:43:38 + 2008 --- pmladek-ama: I see your point. I will attach another patch that adds explicit casts to (const sal_Char *). It helps to avoid the warnings as well. Would it be acceptable for you? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 --- Additional comments from [EMAIL PROTECTED] Tue Apr 22 15:44:27 + 2008 --- Created an attachment (id=53118) Another propossed fix. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User mba changed the following: What|Old value |New value Target milestone|--- |OOo 3.0 --- Additional comments from [EMAIL PROTECTED] Mon Apr 21 10:27:00 + 2008 --- As this is a build breaker I assume that 3.0 is a suitable target. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User ama changed the following: What|Old value |New value Assigned to|ama |pmladek --- Additional comments from [EMAIL PROTECTED] Wed Apr 16 08:11:17 + 2008 --- ama-pmladek: There char-pointers pType and pBLIPType are used like enums. The intention is to compare the pointers and _not_ the string it points to. Your patch will be slower and theoretically it could deliver true when the old code delivers false. Please have a look if you'll find a fix for your warning without replacing == by strcmp. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 Issue #|86880 Summary|sw: warning: comparison with string literal results in | unspecified behaviour Component|Word processor Version|OOo 2.4 RC4 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|ama Reported by|pmladek --- Additional comments from [EMAIL PROTECTED] Mon Mar 10 15:39:06 + 2008 --- We mark the warning: comparison with string literal results in unspecified behaviour as an error in our build system. I'll attach a patch that fixes these warnings in the module: sw Example of the warning: --- cut --- In function 'Writer OutRTF_SwGrfNode(Writer, SwCntntNode)': /usr/src/packages/BUILD/ooo-build-2.4.0.2/build/ooh680-m9/sw/source/filter/rtf/rtfatr.cxx:1763: warning: comparison with string literal results in unspecified behaviour --- cut --- - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 86880] sw: warning: comparison wi th string literal results in unspecified behav iour
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86880 User pmladek changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |52009) Proposed fix. --- Additional comments from [EMAIL PROTECTED] Mon Mar 10 15:40:19 + 2008 --- Created an attachment (id=52009) Proposed fix. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
