[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 User fme changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Thu Nov 27 10:43:51 + 2008 --- Verified by developer. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 User fme changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Mon Sep 29 12:30:24 + 2008 --- @hennerdrewes: Thank you for your patch! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 --- Additional comments from [EMAIL PROTECTED] Thu Jul 10 15:33:42 + 2008 --- You are right. Apparently the problems I observed are connected to the kashida changes I made. So this issue is probably less critical than I thought. Anyhow, with the modifications to the patch I just posted, everything seems to work fine with my kashida patches - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 User hennerdrewes changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |55053) modified patch --- Additional comments from [EMAIL PROTECTED] Thu Jul 10 15:28:31 + 2008 --- Created an attachment (id=55053) modified patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 --- Additional comments from [EMAIL PROTECTED] Thu Jul 10 15:15:05 + 2008 --- fme->hennerdrewes: Well, I can't see a problem with the bugdoc in a current DEV300m23. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 --- Additional comments from [EMAIL PROTECTED] Thu Jul 10 13:40:57 + 2008 --- Created an attachment (id=55051) sample doc - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 --- Additional comments from [EMAIL PROTECTED] Thu Jul 10 13:25:16 + 2008 --- I worked with the kashida.odt document from the other Arabic issues, I'll attach it again. But there might be another problem involved: I deliberately changed CTL language attributes on selected text ranges (to Hebrew) in the document to see, how the justification reacts on that. Expected results: kashida justification should switch to regular blank justification. Observed results: Apparently my language choices were not always applied to the text. Sometimes I still had blank justification, although the status bar reported Arabic (Egypt) as the current language. At a certain stage, the spellchecker marked Arabic words: My conclusion: somewhere in the program the LATIN language was reported instead of the CTL (Arabic) language. (I don't have a spellchecker for neither Arabic or Hebrew installed, so it must be LATIN). Finally, I managed to get rid of this chaos by selecting all the text and applying Arabic (Jordan) to it, Arabic (Egypt) didn't work. I don't know if you will manange to reproduce my observings with the original document. Also my kashida patches might influence the results, though I doubt that the language chaos is influenced by this. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 --- Additional comments from [EMAIL PROTECTED] Thu Jul 10 11:58:25 + 2008 --- fme->hennerdrewes: Thank you for your patch. Yes, I think you are right, the code needs to be changed here. But what's puzzling me is this: [...] In one line I had English text followed by Arabic, separated by a blank. [...] As nScript was ignored, and break iterator looked only at the first character of the Arabic run (the blank), the Latin language is returned. [...] I wonder why the blank that's located between the English and Arabic text is part of the Arabic portion instead of the English portion. I think the first character of a portion usually should be of the same script type as the rest for the portion. Therefore this shouldn't be much of a problem. Can you attach a document? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 --- Additional comments from [EMAIL PROTECTED] Thu Jul 10 05:53:57 + 2008 --- @fme: When I was debugging the kashida justification, I had the following case: In one line I had English text followed by Arabic, separated by a blank. The formatting of the line was completely broken, words were placed beyond the page margin. This didn't happen with my kashida patches in 2.4.1 code, only in dev300_xxx. When the justification type is determined by asking for the language attribute, the nScript parameter gets ignored if pSwpHints == NULL. (Apparently there was a pSwpHints in 2.4.x, but now there is not.) As nScript was ignored, and break iterator looked only at the first character of the Arabic run (the blank), the Latin language is returned. As this will probably also happen for other special justifications (e.g. Thai), it might be a good idea to include this fix in 3.0. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 User fme changed the following: What|Old value |New value Status|NEW |STARTED --- Additional comments from [EMAIL PROTECTED] Thu Jul 10 05:30:16 + 2008 --- fme->hennerdrewes: Thank you for your patch. I'll have a look. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 User ama changed the following: What|Old value |New value Assigned to|ama |fme Ever confirmed| |1 Status|UNCONFIRMED |NEW --- Additional comments from [EMAIL PROTECTED] Wed Jul 9 09:37:18 + 2008 --- ama->fme: Please have a look! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 User mru changed the following: What|Old value |New value Assigned to|mru |ama Target milestone|--- |OOo 3.1 --- Additional comments from [EMAIL PROTECTED] Tue Jul 8 15:03:23 + 2008 --- MRU->AMA: please have a look at this patch proposal. If you are not the correct developer for this, please reassign to proper person, thanks! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 User hennerdrewes changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |55006) patch for file sw/s | |ource/core/txtnode/thints. | |cxx --- Additional comments from [EMAIL PROTECTED] Tue Jul 8 11:19:45 + 2008 --- Created an attachment (id=55006) patch for file sw/source/core/txtnode/thints.cxx - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sw-issues] [Issue 91465] SwTxtNode::GetLang() ignor es nScript parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91465 Issue #|91465 Summary|SwTxtNode::GetLang() ignores nScript parameter Component|Word processor Version|DEV300m19 Platform|PC URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mru Reported by|hennerdrewes --- Additional comments from [EMAIL PROTECTED] Tue Jul 8 11:17:39 + 2008 --- While debugging my changes of issue 60591, I noticed an apparent bug in SwTxtNode::GetLang(). If pSwpHints == NULL, the function will not evaluate the nScript parameter, and eventually return a LATIN language, when CTL was requested. In my debugging case, it disrupted the kashida justification when mixing English and Arabic in a text line. I think this could also disrupt justification of other CTL or Asian languages. Attaching a patch. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
