[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[cloph]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User cloph changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from [EMAIL PROTECTED] Tue Mar  4 22:29:20 + 
2008 ---
verified in ause090

when running dmake create_patch in a module with old (context) diff, a unified
diff will be created, for modules with unified diff, changes will not change the
timestamps or order of the unmodified hunks but only update/add the hunks  with
new patch-data.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[hjs]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User hjs changed the following:

What|Old value |New value

 Assigned to|hjs   |cloph





--- Additional comments from [EMAIL PROTECTED] Mon Mar  3 16:21:15 + 
2008 ---
please verify

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[hjs]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917





--- Additional comments from [EMAIL PROTECTED] Fri Feb 29 16:14:47 + 
2008 ---
did some additional tests to make sure cygwin tooling isn't holding some 
surprises.
patch creation, patch_sanitize.pl and applying the resulting patch works as
expected. also made sure that the resulting patches work for SO windows env.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[hjs]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User hjs changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Issue type|DEFECT|TASK

  Resolution|  |FIXED

Target milestone|---   |DevTools





--- Additional comments from [EMAIL PROTECTED] Mon Feb 25 16:06:50 + 
2008 ---
patch_sanitizer.pl now gets called when creating patches with "dmake
create_patch". this should reduce the pain of diffing patches.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[fridrich_strba]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User fridrich_strba changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |49667)
modification to the
|  | create_patch target to th
|  |at it creates sanitized pa
|  |tches






--- Additional comments from [EMAIL PROTECTED] Thu Nov 15 09:55:14 + 
2007 ---
Created an attachment (id=49667)
modification to the create_patch target to that it creates sanitized patches


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[thb]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917





--- Additional comments from [EMAIL PROTECTED] Thu Nov 15 09:46:03 + 
2007 ---
dumped patch_sanitize.pl into CWS boostup01 (solenv/bin), as this is just too
useful to idle in this issue...

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[fridrich_strba]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User fridrich_strba changed the following:

What|Old value |New value

  CC|'cloph,fs,pjanik,rt,tono' |'cloph,fridrich_strba,fs,p
|  |janik,rt,tono'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[rt]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User rt changed the following:

What|Old value |New value

  CC|'cloph,fs,pjanik,tono'|'cloph,fs,pjanik,rt,tono'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[cloph]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917





--- Additional comments from [EMAIL PROTECTED] Tue Oct 30 15:47:37 + 
2007 ---
Created an attachment (id=49274)
sanitizer for context-diffs generated by dmake patch


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[cloph]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User cloph changed the following:

What|Old value |New value

  CC|'fs,pjanik,tono'  |'cloph,fs,pjanik,tono'





--- Additional comments from [EMAIL PROTECTED] Tue Oct 30 15:46:22 + 
2007 ---
Is there any timeline?
I for myself would prefer unified diffs as well.

And since the different results of dmake patch have bitten me again (the patch
for issue 81303 doesn't apply for m235 anymore, but only because the patch data
was reshuffled, not because of other conflicts) I wrote a hackish patch
sanitizer that will sort the output by patched filename and will copy the hunks
& headers (timestamps) from the original patch when the patch data itself is the
same (instead of taking the same hunk from the new patch that would introduce
modified timestamps for every hunk and thus will make reading a patch against
the patch very uncomfortable - but the sorting part is even more important).

That simplifies comparing two different versions of a patch a lot

I personally would love if the timestamps (at least of the modified hunks) were
converted to ISO format, but unfortunately HTTP::Date is not part of the default
perl installation, and parsing the dates myself is too troublesome.

usage is as follows
patch_sanitizer.pl original.patch new.patch sanitized.patch

I didn't test it thoroughly, and it is far from being optimized (but as
generating new patches isn't time critical anyway, I think it will do...)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[fs]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User fs changed the following:

What|Old value |New value

  CC|'pjanik,tono' |'fs,pjanik,tono'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[tono]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917





--- Additional comments from [EMAIL PROTECTED] Sat Nov 18 19:21:52 -0800 
2006 ---
On cygwin unified diff files include time zone info, while context diff do not.

Unified diff emits old and new line numbers in one line output and it is 
better for diff'ing diff files.

I do not like context diffs.

tono (Takashi Ono)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[hjs]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917





--- Additional comments from [EMAIL PROTECTED] Mon Aug 28 02:56:49 -0700 
2006 ---
see also #i40959# - if there is an agreement that unified diffs are the desired
format, it's easy to switch

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[tono]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User tono changed the following:

What|Old value |New value

  CC|'pjanik'  |'pjanik,tono'





--- Additional comments from [EMAIL PROTECTED] Fri Aug 25 16:47:10 -0700 
2006 ---
I think it better to keep the timestamp. Can't we specify -Z flag to patch 
command so that non-essential timestamp modification will not occur?

And maybe unfied style diff is better than context style for diff'ing diff 
files.

tono (Takashi Ono)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[pjanik]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User pjanik changed the following:

What|Old value |New value

  CC|''|'pjanik'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[pjanik]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917





--- Additional comments from [EMAIL PROTECTED] Thu Aug 24 09:27:45 -0700 
2006 ---
I agree this is needed, but for now, I use interdiff as a workaround for
comparing two patches.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[sb]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917


User sb changed the following:

What|Old value |New value

 Assigned to|mh|hjs





--- Additional comments from [EMAIL PROTECTED] Thu Aug 24 02:07:50 -0700 
2006 ---
.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[tools-issues] [Issue 68917] dmake create_patch: Produc e diff'able patches

[sb]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68917
 Issue #|68917
 Summary|dmake create_patch: Produce diff'able patches
   Component|tools
 Version|680m182
Platform|All
 URL|
  OS/Version|All
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|DEFECT
Priority|P3
Subcomponent|code
 Assigned to|mh
 Reported by|sb





--- Additional comments from [EMAIL PROTECTED] Thu Aug 24 02:04:48 -0700 
2006 ---
As Ause and I discussed off-line, dmake create_patch (see
) has two problems that lead to
generated patches that are "too large" (and thus hard to diff against older
revisions of those patches):

1  The used diff behaves differently on Linux and Solaris with respect to the
order of files processed (so that patch chunks can show up permutated in two
revisions of a patch).

2  The resulting patch (needlessly) contains the dates of the processed files
(which typically differ for different runs of dmake create_patch, so that the
resulting patches needlessly differ in those lines).

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]