[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2009-02-24 Thread hjs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136


User hjs changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from h...@openoffice.org Tue Feb 24 11:53:27 + 
2009 ---
.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@tools.openoffice.org
For additional commands, e-mail: issues-h...@tools.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-26 Thread hjs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136


User hjs changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from [EMAIL PROTECTED] Tue Feb 26 16:10:24 + 
2008 ---
ok, last comment from shay counts as verified regarding this particular issue.
also, i couldn't find regressions regarding nested macros or similar (yes, i
tried ;)). but i still don't feel comfortable with this change...

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-26 Thread vq
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136





--- Additional comments from [EMAIL PROTECTED] Tue Feb 26 16:49:11 + 
2008 ---
 also, i couldn't find regressions regarding nested macros or similar (yes, i
 tried ;)). but i still don't feel comfortable with this change...

At first I wasn't feeling comfortable with this either, but I tripple checked
that it actually was a bug before. Before the patch a macro holding a
(make-)filename was always expanded twice, now it's done only when needed.

And removing unneeded Expand() calls is a small run-time optimization ;)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-08 Thread shay
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136





--- Additional comments from [EMAIL PROTECTED] Fri Feb  8 08:58:55 + 
2008 ---
Yes, looks good to me now. I can even build perl using a dmake.exe in
C:\Temp\$test. Thanks!

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-07 Thread shay
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136





--- Additional comments from [EMAIL PROTECTED] Thu Feb  7 09:29:01 + 
2008 ---
I checked out cws_src680_dmake412, confirmed that the source contains your
patch, and re-tested the bug exactly as I originally reported, and I'm afraid
that I still get exactly the same error.

Should this bug be re-opened, or rejected as don't do that!?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-07 Thread vq
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136





--- Additional comments from [EMAIL PROTECTED] Thu Feb  7 15:49:26 + 
2008 ---
Hmm, I only checked if $(ABSMAKECMD) and $(MAKESTARTUP) were set to the right
value and kept the $, but dmake was doing a little more behind our backs.

The previous two patches (committed) take care of this and I verified that I
now actually can run the following makefile with dmake being installed to a path
that has a $ in it.

-- makefile.mk --
SHELL:=cmd.exe 
SHELLFLAGS:=/S /C

all :
@echo AXXA
@echo ABSMAKECMD:$(ABSMAKECMD)A
@echo MAKESTARTUP:$(MAKESTARTUP):A
-- makefile.mk --

$ ./dmake/dmake.exe
AXXA
ABSMAKECMD:d:\w1\cws_src680_dmake412\mingw$\dmake\dmake.exeA
MAKESTARTUP:d:\w1\cws_src680_dmake412\mingw$\dmake\startup\startup.mk:A


Please check again.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-07 Thread vq
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136


User vq changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |51420)
Patch for dmake






--- Additional comments from [EMAIL PROTECTED] Thu Feb  7 15:26:21 + 
2008 ---
Created an attachment (id=51420)
Patch for dmake


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-07 Thread vq
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136


User vq changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |51422)
Patch for dmake






--- Additional comments from [EMAIL PROTECTED] Thu Feb  7 15:40:05 + 
2008 ---
Created an attachment (id=51422)
Patch for dmake


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-06 Thread vq
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136


User vq changed the following:

What|Old value |New value

  CC|''|'hjs'

  Ever confirmed|  |1

  Status|UNCONFIRMED   |NEW

  OS/Version|Windows XP|Windows, all

Target milestone|---   |DevTools





--- Additional comments from [EMAIL PROTECTED] Wed Feb  6 15:57:12 + 
2008 ---
Usually I would say don't do that  ;)  I mean using $ in targets/prerequisites
is asking for trouble as macros in target names are evaluated before defining
the rules or - even worse - dynamic prerequisites are evaluated at run time.

I might be able to fix this particular problem by not expanding $(ABSMAKECMD).
Your problem comes from startup.mk being searched for in
 $(ABSMAKECMD:d)startup/startup.mk
but there might lurk problems in every dynamic macro. It might just work because
absolute paths are rarely used.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-06 Thread vq
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136


User vq changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |51412)
Patch for dmake






--- Additional comments from [EMAIL PROTECTED] Wed Feb  6 22:10:44 + 
2008 ---
Created an attachment (id=51412)
Patch for dmake


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-06 Thread vq
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136


User vq changed the following:

What|Old value |New value

  Status|NEW   |STARTED





--- Additional comments from [EMAIL PROTECTED] Wed Feb  6 22:13:19 + 
2008 ---
The previous patch fixes the ABSMAKECMD problem and thus the config.mk problem.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-02-06 Thread vq
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136


User vq changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from [EMAIL PROTECTED] Wed Feb  6 22:23:06 + 
2008 ---
Committed. Please verify.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[tools-issues] [Issue 85136] dmake can't find config fi les when in directory containing $ in name

2008-01-10 Thread shay
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85136
 Issue #|85136
 Summary|dmake can't find config files when in directory contai
|ning $ in name
   Component|tools
 Version|current
Platform|PC
 URL|
  OS/Version|Windows XP
  Status|UNCONFIRMED
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|DEFECT
Priority|P3
Subcomponent|dmake
 Assigned to|vq
 Reported by|shay





--- Additional comments from [EMAIL PROTECTED] Thu Jan 10 11:25:46 + 
2008 ---
dmake.exe can't find its configuration files when it is run from within a
directory that contains a $ character in its name.

E.g. put the following in C:\Temp\makefile.mk:

all :
[EMAIL PROTECTED] Hello

and put dmake.exe and its startup\ directory in C:\Temp\$test

Then 'cd' to C:\Temp and run:

$test\dmake.exe

The output is:

dmake.exe:  Error: -- Configuration file `C:\Temp\est\startup\startup.mk' not 
found

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]