[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2010-01-08 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738


User cmc changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from c...@openoffice.org Fri Jan  8 09:30:28 + 
2010 ---
integrated m69, closing

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2009-12-11 Thread sb
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738


User sb changed the following:

What|Old value |New value

 Assigned to|kso   |cmc





--- Additional comments from s...@openoffice.org Fri Dec 11 08:22:46 + 
2009 ---
@cmc: please verify on CWS sb116

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2009-12-11 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738


User cmc changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from c...@openoffice.org Fri Dec 11 09:00:38 + 
2009 ---
sane in sb116

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2009-10-13 Thread kso
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738


User kso changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from k...@openoffice.org Tue Oct 13 11:32:41 + 
2009 ---
Fixed. =

bCanUseSystemCreds = (attempt == 0)  
   ne_has_support( NE_FEATURE_SSPI )  
   ( ( ne_strcasecmp( inAuthProtocol, NTLM ) == 0 ) ||
 ( ne_strcasecmp( inAuthProtocol, Negotiate ) == 0 ) );


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2009-10-09 Thread kso
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738


User kso changed the following:

What|Old value |New value

  Status|NEW   |STARTED

Target milestone|---   |OOo 3.3





--- Additional comments from k...@openoffice.org Fri Oct  9 07:28:10 + 
2009 ---
cmc: Good catch. The current logic is indeed *not* intended. Thanks for the 
patch.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2009-10-09 Thread kso
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738





--- Additional comments from k...@openoffice.org Fri Oct  9 07:32:24 + 
2009 ---
cmc: Forgot to mention that I will not apply your patch (because it implements
the wrong logic - just without compiler warnings), but will fix the code myself.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2009-10-09 Thread kso
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738


User kso changed the following:

What|Old value |New value

  Issue type|PATCH |DEFECT





--- Additional comments from k...@openoffice.org Fri Oct  9 07:34:53 + 
2009 ---
- DEFECT.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2009-10-08 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738
 Issue #|105738
 Summary|ucb: suspicious  || in NeonSession.cxx
   Component|ucb
 Version|DEV300m61
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|kso
 Reported by|cmc





--- Additional comments from c...@openoffice.org Thu Oct  8 16:09:51 + 
2009 ---
in NeonSession.cxx we've got...

bCanUseSystemCreds = (attempt == 0)  
   ne_has_support( NE_FEATURE_SSPI )  
   ( ne_strcasecmp( inAuthProtocol, NTLM ) == 0 ) ||
   ( ne_strcasecmp( inAuthProtocol, Negotiate ) == 0 );

i.e. this is parsed as...

bCanUseSystemCreds = ((attempt == 0)  
   ne_has_support( NE_FEATURE_SSPI )  
   ( ne_strcasecmp( inAuthProtocol, NTLM ) == 0 )) ||
   ( ne_strcasecmp( inAuthProtocol, Negotiate ) == 0 );

is that definitely the intent ? If so patch to remove new gcc warning attached.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2009-10-08 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |65252)
silence warnings, i
|  |f what we have is what we 
|  |want






--- Additional comments from c...@openoffice.org Thu Oct  8 16:11:20 + 
2009 ---
Created an attachment (id=65252)
silence warnings, if what we have is what we want


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[ucb-issues] [Issue 105738] ucb: suspicious || in NeonSession.cxx

2009-10-08 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=105738


User cmc changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |96084
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@ucb.openoffice.org
For additional commands, e-mail: issues-h...@ucb.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org