[udk-issues] [Issue 108161] [cppuhelper] WeakReferenc eHelper::operator= performance
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108161 User sb changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from s...@openoffice.org Fri Feb 5 12:22:11 + 2010 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@udk.openoffice.org For additional commands, e-mail: issues-h...@udk.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[udk-issues] [Issue 108161] [cppuhelper] WeakReferenc eHelper::operator= performance
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108161 User mst changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from m...@openoffice.org Mon Jan 11 14:02:52 + 2010 --- so i've decided to put this into my CWS anyway. it turns out that i had to add an operator= to class WeakReference, because the operator= in base class WeakReferenceHelper is not called on assignment to a WeakReference instance anyway (in that case, the temporary WeakReference was apparently created as an implicit conversion). fixed in CWS swunolocking1. http://hg.services.openoffice.org/hg/cws/swunolocking1/rev/92a84f268046 please verify. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@udk.openoffice.org For additional commands, e-mail: issues-h...@udk.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[udk-issues] [Issue 108161] [cppuhelper] WeakReferenc eHelper::operator= performance
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108161 --- Additional comments from s...@openoffice.org Mon Jan 11 14:33:45 + 2010 --- @mst; some remarks: 1 WeakReference::operator= declaration lacks @since tag 2 cppuhelper/source/msvc_win32_intel.map needs to be updated, too (gcc3os2.map seems to be unmaintained already, anyway) 3 in the definition of WeakReferenceHelper::operator=, indentation (which erroneously used tabs instead of spaces) should be fixed after taking out one level of braces - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@udk.openoffice.org For additional commands, e-mail: issues-h...@udk.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[udk-issues] [Issue 108161] [cppuhelper] WeakReferenc eHelper::operator= performance
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108161 --- Additional comments from m...@openoffice.org Mon Jan 11 15:10:56 + 2010 --- re 1: added since tag. http://hg.services.openoffice.org/hg/cws/swunolocking1/rev/aafa89530c8c re 2: for some reason the symbol was already in the msvc mapfile; the built ooo runs, at least. re 3: the actual assignment code is the same as before; i prefer not to mix code changes with whitespace changes - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@udk.openoffice.org For additional commands, e-mail: issues-h...@udk.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[udk-issues] [Issue 108161] [cppuhelper] WeakReferenc eHelper::operator= performance
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108161 User sb changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from s...@openoffice.org Mon Jan 11 15:23:36 + 2010 --- verified by code review - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@udk.openoffice.org For additional commands, e-mail: issues-h...@udk.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[udk-issues] [Issue 108161] [cppuhelper] WeakReferenc eHelper::operator= performance
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108161 Issue #|108161 Summary|[cppuhelper] WeakReferenceHelper::operator= performanc |e Component|udk Version|DEV300m67 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|sb Reported by|mst --- Additional comments from m...@openoffice.org Fri Jan 8 17:30:56 + 2010 --- cppuhelper/weak.hxx: WeakReferenceHelper has 2 assignment operators, one copy assignment, and one for assigning a uno::Reference. the latter is implemented by constructing a temporary WeakReferenceHelper from the uno::Reference, then assigning that via the other operator=. callgrind says that constructing and destructing the temporary copy is twice as expensive as the actual assignment. it probably would be better to have a fast assignment operator for uno::Reference, and have the copy assignment operator invoke that instead of the other way around. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@udk.openoffice.org For additional commands, e-mail: issues-h...@udk.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[udk-issues] [Issue 108161] [cppuhelper] WeakReferenc eHelper::operator= performance
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108161 User ericb changed the following: What|Old value |New value CC|''|'ericb' --- Additional comments from er...@openoffice.org Sat Jan 9 06:00:34 + 2010 --- Interesting - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@udk.openoffice.org For additional commands, e-mail: issues-h...@udk.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
