[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 User utomo99 changed the following: What|Old value |New value CC|'joergwartenberg,mhu,thing|'joergwartenberg,mhu,thing |' |,utomo99' Keywords| |oooqa --- Additional comments from [EMAIL PROTECTED] Sun Jun 10 09:26:59 + 2007 --- I hope Michael Meeks patch considered to be integrated soon, after some changes necessary. it is not good if a patch which exist since 2005, need more and more works because of time, and code changes. This patch will reduce user complains of slow OOo. just my 2c - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 User sb changed the following: What|Old value |New value Issue type|PATCH |ENHANCEMENT --- Additional comments from [EMAIL PROTECTED] Fri Mar 30 11:44:21 + 2007 --- Changed from PATH to ENHANCEMENT to indicate that the attached patch is a starting point for some more work that is still necessary. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 User thing changed the following: What|Old value |New value CC|'joergwartenberg,mhu' |'joergwartenberg,mhu,thing | |' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 User sb changed the following: What|Old value |New value Target milestone|OOo 3.0 |OOo 2.x --- Additional comments from [EMAIL PROTECTED] Tue Jun 13 06:08:45 -0700 2006 --- ...more appropriately OOo 2.x, as OOo 3.0 is only for issues that will go into 3.0 exactly. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 User sb changed the following: What|Old value |New value Status|NEW |STARTED Target milestone|--- |OOo 3.0 --- Additional comments from [EMAIL PROTECTED] Tue Feb 14 04:57:25 -0800 2006 --- As it seems that the proposed patches in this issue do not yet lead to a clean (robust, for all platforms) fix that significantly reduces startup cost, I postpone this to OOo 3.0. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=56783
--- Additional comments from [EMAIL PROTECTED] Fri Oct 28 00:23:11 -0700
2005 ---
comments from jb:
diff -u -p -u -r1.3 localfilehelper.cxx
--- configmgr/source/localbe/localfilehelper.cxx16 Feb 2005 16:46:51 -
1.3
+++ configmgr/source/localbe/localfilehelper.cxx27 Oct 2005 11:21:18 -
@@ -126,6 +128,10 @@ namespace configmgr if (_sURL.getLength() == 0)
return false;
+// This method has no right to be so under-performing to
+// achieve so, so little of any usefulness.
+return true;
+
DirectoryItem aDirItem;
This is function normalizeURL(). AFAICT we call it only for directories where we
need to compare directory names. It is needed there (for example) when
non-case-sensitive filesystems are involved (need to ask the sal/osl crowd what
other reasons can cause a different file URL to be reported).
I believe we can eliminate some redundant stats here with additional bookkeeping
- but we can't get rid of that in general. We might also add a configmgrrc
setting to skip this, if it is known that no file systems where
osl_getFileStatus can produce a URL that is different from the input are
involved, but the default for deploying to unknown environments would have to
stay unchanged.
diff -u -p -u -r1.5 localmultistratum.cxx
--- configmgr/source/localbe/localmultistratum.cxx8 Sep 2005 04:04:46
-1.5
+++ configmgr/source/localbe/localmultistratum.cxx27 Oct 2005 11:21:18
-
@@ -107,7 +107,7 @@ uno::Sequence rtl::OUString SAL_CALL rtl::OUString
const aComponentUrl = aLayerUrl + componentToPath(aComponent);
using namespace osl;
-const sal_uInt32 k_STATUS_FIELDS = FileStatusMask_Type |
FileStatusMask_FileName; +const sal_uInt32 k_STATUS_FIELDS =
FileStatusMask_FileName; Directory aComponentDirectory(aComponentUrl);
DirectoryItem aItem;
std::vector rtl::OUString aResult;
@@ -132,13 +132,12 @@ uno::Sequence rtl::OUString SAL_CALL
OSL_TRACE(Reading Component Directory - Error (%u) getting status of directory
item.\n, unsigned(errcode));
break;
}
-
-OSL_ENSURE( aItemDescriptor.isValid(FileStatusMask_Type), Could
not get type of directory item);
-if (aItemDescriptor.getFileType() != FileStatus::Regular)
-continue;
OSL_ENSURE(
aItemDescriptor.isValid(FileStatusMask_FileName), Could not get Name of
component found);
OUString const aFileName = aItemDescriptor.getFileName();
+
+// It is reasonable to assume a .xcu file is not a directory =
+// not stat each directory entry at considerable cost.
if
(!aFileName.endsWithIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(kLocalDataSuffix)))
Fair enough. The .xcu check should be sufficient. This has the added effect that
.xcu files may be symlinks - which also sounds reasonable.
diff -u -p -u -r1.16 filehelper.cxx
--- configmgr/source/misc/filehelper.cxx8 Sep 2005 04:09:44 -1.16
+++ configmgr/source/misc/filehelper.cxx27 Oct 2005 11:21:18 -
@@ -143,9 +143,22 @@ namespace configmgr static const TimeValue
k_NullTime = {0,0};
sal_uInt64 aSize = 0;
rModifyTime = k_NullTime;
+rtl::OUString aURL;
-DirectoryItem aItem;
-if (osl::FileBase::E_None == DirectoryItem::get(_sURL, aItem))
+DirectoryItem aItem;
+
+#ifndef STAT_LOTS_OF_UNUSED_FILES
+// Statting every file takes way to long - we can use the directory
+// time-stamp size instead, if we need to provoke an update
+// a simple cat foo; rm foo will do that.
+// The dir size is (hopefully) non-0 and a good enough proxy value.
+
+aURL = FileHelper::getParentDir(_sURL);
+#else
+aURL = _sURL;
+#endif
+
+if (osl::FileBase::E_None == DirectoryItem::get(aURL, aItem))
{
FileStatus
aStatus(osl_FileStatus_Mask_ModifyTime|osl_FileStatus_Mask_Type|osl_FileStatus_Mask_FileSize);
if (osl::FileBase::E_None == aItem.getFileStatus(aStatus))
I don't think that is acceptable.
Firstly, it violates the semantics of that function. If anybody really wanted to
do this, the parent directory substitution should be in the caller (i.e. in the
getTimestamp() method in localfilelayer.cxx).
Secondly it does not work everywhere. The semantics of that 'timestamp' is that
it must change, if the file changes. You can't guarantee that. Without actively
provoking an update, changes might go completely unnoticed on most filesystems.
Generally I'm wary of directory timestamps. Is their behaviour really portable
across all kinds of file systems and OSs?
For directory sizes that
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 --- Additional comments from [EMAIL PROTECTED] Fri Oct 28 03:13:08 -0700 2005 --- Joerg - the patch you suggest: +// if reference timestamp is empty, every layer needs to be read +if (aTimestamp.getLength() == 0) + return true; Surely is helpful only for the very-1st start which is so slow as to be painful anyway ? surely when it has been run once already we'll have a timestamp to compare and this will confer no advantage ? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 --- Additional comments from [EMAIL PROTECTED] Fri Oct 28 04:18:58 -0700 2005 --- No. This patch will reduce stat calls significantly. That code currently only ever gets called with empty timestamp. The timestamp parameter here would be used for caching remote data for offline use. That was used for some StarOffice7 feature, but never in OOo. Unfortunately the same files will be stat'ed for the binary cache a little later. Thus this patch won't reduce *unique* stats. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 --- Additional comments from [EMAIL PROTECTED] Fri Oct 28 08:02:02 -0700 2005 --- One additional remark: The isMoreRecent fix should completely eliminate the need to stat the .xcu files in ~/.ooo/user/registry/data. But that won't help all that much either, because these files will even be opened and read - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 User mmeeks changed the following: What|Old value |New value Attachment is patch| |Created an attachment | |(id=30914) patch --- Additional comments from [EMAIL PROTECTED] Thu Oct 27 04:46:32 -0700 2005 --- Created an attachment (id=30914) patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 --- Additional comments from [EMAIL PROTECTED] Thu Oct 27 05:51:03 -0700 2005 --- In terms of testing, touching/removing files in both ~/.ooo and system prefix had the expected refreshing effect (of the whole directory I guess [a slight down-side ;-]). And of course, changing user settings through the UI works nicely too. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 56783] cold-start speedup - file touch redux ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=56783 User sb changed the following: What|Old value |New value Assigned to|hro |sb --- Additional comments from [EMAIL PROTECTED] Thu Oct 27 06:56:55 -0700 2005 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
