[util-issues] [Issue 107594] cws.pl doesn't fail on hg returning an error status

2009-12-10 Thread gh
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107594
 Issue #|107594
 Summary|cws.pl doesn't fail on hg returning an error status
   Component|utilities
 Version|1.0.0
Platform|All
 URL|
  OS/Version|All
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|DEFECT
Priority|P3
Subcomponent|code
 Assigned to|hr
 Reported by|gh





--- Additional comments from g...@openoffice.org Thu Dec 10 12:38:07 + 
2009 ---
see attachment for my fix

opening a pipe seems to fail only if the command cannot get started but only the
close dails if it returns anything else but 0 (zero)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org
For additional commands, e-mail: issues-h...@util.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[util-issues] [Issue 107594] cws.pl doesn't fail on hg returning an error status

2009-12-10 Thread gh
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107594


User gh changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |66590)
check if program ex
|  |its with 0






--- Additional comments from g...@openoffice.org Thu Dec 10 12:41:57 + 
2009 ---
Created an attachment (id=66590)
check if program exits with 0


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org
For additional commands, e-mail: issues-h...@util.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[util-issues] [Issue 107594] cws.pl doesn't fail on hg returning an error status

2009-12-10 Thread gh
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107594





--- Additional comments from g...@openoffice.org Thu Dec 10 12:42:46 + 
2009 ---
note that this pattern is repeated in other places also

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org
For additional commands, e-mail: issues-h...@util.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[util-issues] [Issue 107594] cws.pl doesn't fail on hg returning an error status

2009-12-10 Thread hr
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107594


User hr changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |INVALID





--- Additional comments from h...@openoffice.org Thu Dec 10 13:32:06 + 
2009 ---
Some hg commands (for example hg ident on non existing revision) may return with
non-zero status, this is not an error condition. In such cases exiting on
close() returning false will break the script.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org
For additional commands, e-mail: issues-h...@util.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[util-issues] [Issue 107594] cws.pl doesn't fail on hg returning an error status

2009-12-10 Thread mechtilde
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107594


User mechtilde changed the following:

What|Old value |New value

  Status|RESOLVED  |CLOSED





--- Additional comments from mechti...@openoffice.org Thu Dec 10 21:08:23 
+ 2009 ---
invalid - closed

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org
For additional commands, e-mail: issues-h...@util.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org