[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 User tono changed the following: What|Old value |New value Status|RESOLVED |CLOSED --- Additional comments from t...@openoffice.org Sat Aug 29 23:37:40 + 2009 --- Closing as the fix is already in the trunk. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 --- Additional comments from b_michael...@openoffice.org Mon Feb 23 10:52:25 + 2009 --- Cant reproduce with any gcc: gcc (Gentoo 4.3.3 p1.0, pie-10.1.5) 4.3.3 gcc (GCC) 4.1.2 (Gentoo 4.1.2 p1.0.2) gcc (Ubuntu 4.3.2-1ubuntu12) 4.3.2 g++ (GCC) 3.3.6 (Gentoo 3.3.6-r1 p1.5, ssp-3.3.6-1.0, pie-8.7.8) Also ISO/IEC FDIS 14882:1998(E) chapter 12.3 is pretty clear on that one. Which gcc version are you using? I wouldnt be so picky for DEV300_m42, but this code also is in OOO310_m1 so I really want to understand the issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 --- Additional comments from b_michael...@openoffice.org Mon Feb 23 10:54:39 + 2009 --- Created an attachment (id=60381) testcase for implicit conversions - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 --- Additional comments from t...@openoffice.org Mon Feb 23 11:51:15 + 2009 --- OStringBuffer foover(string literal); is always OK. It relies on implicit conversion only once. OStringBuffer foover = string literal; is another story. We have to convert the intializer to OStringBuffer implicitly, and the result is used as an argument for copy constructor. So It relies on twice conversion and will fail. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 --- Additional comments from t...@openoffice.org Mon Feb 23 12:03:20 + 2009 --- Both gcc-3.4.4 MinGW and gcc-4.2.1 (beta) MinGW fail on OStringBuffer s = ...; - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 --- Additional comments from t...@openoffice.org Mon Feb 23 12:10:36 + 2009 --- Please note that the part is conditionally compiled for non-unix. In the unix version the intitalizer is a result of + operator with OString and it is OString type. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 User b_michaelsen changed the following: What|Old value |New value Ever confirmed| |1 Status|UNCONFIRMED |STARTED --- Additional comments from b_michael...@openoffice.org Mon Feb 23 12:36:59 + 2009 --- Sorry, I didnt look at the patch to closely. The weird thing is, it (errormail.cxx not the test.cpp) compiles here on gcc 3.4.1. Fixing on cws oooimprovement3 while it is still on status new. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 User b_michaelsen changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from b_michael...@openoffice.org Mon Feb 23 12:41:09 + 2009 --- fixed with patch by tono in cws oooimprovement3 revision 268353. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 --- Additional comments from b_michael...@openoffice.org Sun Feb 22 17:46:59 + 2009 --- OString has a (non-explicit) constructor from ASCII string: http://svn.services.openoffice.org/opengrok/xref/Current%20(trunk)/sal/inc/rtl/string.hxx#140 So I assume this to take precedence via C++ implicit type conversion. Have you tested the issue to go wrong? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 --- Additional comments from t...@openoffice.org Sun Feb 22 22:03:07 + 2009 --- We cannot expect compiler to choose appropriate implicit conversion twice. (const char* - OString, OString - OStringBuffer) GCC fails to choose them and causes an error on such a conversion. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 Issue #|99491 Summary|to-be-DEV300_m42: inappropriate usage of OStringBuffer | ctor Component|utilities Version|DEV300m41 Platform|All URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|b_michaelsen Reported by|tono --- Additional comments from t...@openoffice.org Sat Feb 21 23:19:26 + 2009 --- In extensions/source/oooimprovement/errormail.cxx, OStringBuffer is being initialized with ASCII string constant. As OStringBuffer can be initialized only with OStringBuffer, OString or length integer, the initializer will be treated as an length integer. A patch to fix it follows. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[util-issues] [Issue 99491] to-be-DEV300_m42: inapprop riate usage of OStringBuffer ctor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99491 User tono changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |60349) Patch to use OStrin | |g instead of string consta | |nt --- Additional comments from t...@openoffice.org Sat Feb 21 23:22:19 + 2009 --- Created an attachment (id=60349) Patch to use OString instead of string constant - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
