[xml-issues] [Issue 106389] package: dubious && || in ZipPackageFolder.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=106389 User mav changed the following: What|Old value |New value Component|xml |framework QA contact|iss...@xml|iss...@framework --- Additional comments from m...@openoffice.org Thu Oct 29 07:16:20 + 2009 --- Changing the component to framework. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@xml.openoffice.org For additional commands, e-mail: issues-h...@xml.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[xml-issues] [Issue 106389] package: dubious && || in ZipPackageFolder.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=106389 User mav changed the following: What|Old value |New value Status|NEW |STARTED Target milestone|--- |OOo 3.3 --- Additional comments from m...@openoffice.org Thu Oct 29 07:15:28 + 2009 --- mav->cmc: Thank you for the patch. You are completely right, generally speaking the changed version is the correct one. The interesting thing is that the source code functions correctly now, because the stream has nMethod set only if it is a package member, and if the stream should be encrypted it must be compressed as well. Anyway, the current implementation works by luck and is not clear, so I will integrate the second patch in the next 3.3 framework cws. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@xml.openoffice.org For additional commands, e-mail: issues-h...@xml.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[xml-issues] [Issue 106389] package: dubious && || in ZipPackageFolder.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=106389 User cmc changed the following: What|Old value |New value OtherIssuesDependingOnTh| |96084 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@xml.openoffice.org For additional commands, e-mail: issues-h...@xml.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[xml-issues] [Issue 106389] package: dubious && || in ZipPackageFolder.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=106389 User cmc changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |65707) change logic --- Additional comments from c...@openoffice.org Wed Oct 28 15:37:45 + 2009 --- Created an attachment (id=65707) change logic - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@xml.openoffice.org For additional commands, e-mail: issues-h...@xml.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[xml-issues] [Issue 106389] package: dubious && || in ZipPackageFolder.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=106389 User cmc changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |65706) keep logic --- Additional comments from c...@openoffice.org Wed Oct 28 15:37:28 + 2009 --- Created an attachment (id=65706) keep logic - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@xml.openoffice.org For additional commands, e-mail: issues-h...@xml.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[xml-issues] [Issue 106389] package: dubious && || in ZipPackageFolder.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=106389 Issue #|106389 Summary|package: dubious && || in ZipPackageFolder.cxx Component|xml Version|DEV300m63 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mav Reported by|cmc --- Additional comments from c...@openoffice.org Wed Oct 28 15:36:49 + 2009 --- i.e. we have... if ( !bUseNonSeekableAccess && ( bRawStream || bTransportOwnEncrStreamAsRaw || ( pStream->IsPackageMember() && !bToBeEncrypted && ( pStream->aEntry.nMethod == DEFLATED && bToBeCompressed ) || ( pStream->aEntry.nMethod == STORED && !bToBeCompressed ) ) ) ) which is parsed as if ( !bUseNonSeekableAccess && ( bRawStream || bTransportOwnEncrStreamAsRaw || (( pStream->IsPackageMember() && !bToBeEncrypted && ( pStream->aEntry.nMethod == DEFLATED && bToBeCompressed )) || ( pStream->aEntry.nMethod == STORED && !bToBeCompressed ) ) ) ) which is a little suspicious, I suspect it might have been intended to be if ( !bUseNonSeekableAccess && ( bRawStream || bTransportOwnEncrStreamAsRaw || ( pStream->IsPackageMember() && !bToBeEncrypted && (( pStream->aEntry.nMethod == DEFLATED && bToBeCompressed ) || ( pStream->aEntry.nMethod == STORED && !bToBeCompressed )) ) ) ) patch 1 keeps our current logic and silences warning, patch 2 changes the logic to what might have been intended - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@xml.openoffice.org For additional commands, e-mail: issues-h...@xml.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
