Re: 2.5.1 nitpicks

2006-09-26 Thread Jean-Francois Malouin
* Jean-Louis Martineau <[EMAIL PROTECTED]> [20060922 20:16]:
> Jean-Francois,
> 
> Could you try this patch?

sorry to get back that late...
The patched amstat now show the tape usage
and amtoc looks fine too.

regards, 
jf

> 
> Jean-Louis
> 
> Jean-Francois Malouin wrote:
> >Hello,
> >
> >I've been testing 2.5.1 for a few days now and I have 2 nitpicks:
> >
> >With 2.4.5 'amtoc -a' produces outputfile with names
> >.toc as per the man page. This doesn't seem to be the
> >case anymore with 2.5.1 where I just get a file called "tape.toc". And
> >in the situation where more than one tape were used (runtapes>1) it
> >simply clobbers all of them except for the last tape. I had a brief
> >look at the diff between the 2.4.5 and 2.5.1 but couldn't find
> >anything obvious.
> >
> >amstatus doesn't tell you which tapes are used and how much stuff was
> >put on them.
> >
> >regards
> >jf
> >  
> 



-- 
<° ><


Re: 2.5.1 nitpicks

2006-09-22 Thread Jean-Louis Martineau

Jean-Francois,

Could you try this patch?

Jean-Louis

Jean-Francois Malouin wrote:

Hello,

I've been testing 2.5.1 for a few days now and I have 2 nitpicks:

With 2.4.5 'amtoc -a' produces outputfile with names
.toc as per the man page. This doesn't seem to be the
case anymore with 2.5.1 where I just get a file called "tape.toc". And
in the situation where more than one tape were used (runtapes>1) it
simply clobbers all of them except for the last tape. I had a brief
look at the diff between the 2.4.5 and 2.5.1 but couldn't find
anything obvious.

amstatus doesn't tell you which tapes are used and how much stuff was
put on them.

regards
jf
  


diff -u -r --show-c-function --exclude-from=amanda.diff amanda-2.5.2alpha.new/server-src/amstatus.pl.in amanda-2.5.2alpha.new.taperstart/server-src/amstatus.pl.in
--- amanda-2.5.2alpha.new/server-src/amstatus.pl.in	2006-09-12 06:42:35.0 -0400
+++ amanda-2.5.2alpha.new.amtoc/server-src/amstatus.pl.in	2006-09-22 16:19:31.0 -0400
@@ -732,7 +732,7 @@ while() {
 			}
 		}
 	}
-	elsif(/taper: wrote label `(\S*)'/) {
+	elsif(/taper: .*wrote label `(\S*)'/) {
 		$nb_tape++;
 		$ntlabel{$nb_tape} = $1;
 		$ntpartition{$nb_tape} = 0;
diff -u -r --show-c-function --exclude-from=amanda.diff amanda-2.5.2alpha.new/server-src/amtoc.pl.in amanda-2.5.2alpha.new.taperstart/server-src/amtoc.pl.in
--- amanda-2.5.2alpha.new/server-src/amtoc.pl.in	2006-09-11 11:30:09.0 -0400
+++ amanda-2.5.2alpha.new.amtoc/server-src/amtoc.pl.in	2006-09-22 16:16:03.0 -0400
@@ -166,7 +166,7 @@ while ( <$IF> ) {
   $level = $6;
   switch: {
 /START taper/ && do {
-  $tocfilename=&tfn($level) if ($#subs >= 0);
+  $tocfilename=&tfn($chunk) if ($#subs >= 0);
   if (!$tocfilename || ($tocfilename eq '-')) {$OF=STDOUT;}
   else {
   die ("Cannot open tocfile $tocfilename") unless open(OF,">$tocfilename");


2.5.1 nitpicks

2006-09-22 Thread Jean-Francois Malouin
Hello,

I've been testing 2.5.1 for a few days now and I have 2 nitpicks:

With 2.4.5 'amtoc -a' produces outputfile with names
.toc as per the man page. This doesn't seem to be the
case anymore with 2.5.1 where I just get a file called "tape.toc". And
in the situation where more than one tape were used (runtapes>1) it
simply clobbers all of them except for the last tape. I had a brief
look at the diff between the 2.4.5 and 2.5.1 but couldn't find
anything obvious.

amstatus doesn't tell you which tapes are used and how much stuff was
put on them.

regards
jf