Compile error, resolution, confusion

2002-06-24 Thread Jason Brooks

Hello,

I have been reading through the archives and found a bit of information
that helped me.

for amanda 2.4.3b3, I received errors while compiling on a solaris8 (bybee)
machine.  I applied a change I found in reference to this error, and the
compiler error went away.  the wierd part: this error didn't happen on
different machines running solaris8(bramble), 7, 251, redhat 6.2-7.2, or 
freebsd3.4.

the change was to line 244 of client-src/sendbackup-dump.c:
I changed "no_record" to "options->no_record".  

Interestingly enough, this appears to compile just as well on the other
machines too.

I have installed on both solaris machines:
binutils-2.11.2-sol8-sparc-local
bison-1.28-sol8-sparc-local
flex-2.5.4a-sol8-sparc-local
gcc-3.0.3-sol8-sparc-local
libgcc-3.0.3-sol8-sparc-local
make-3.79.1-sol8-sparc-local



I will include the compiler error messages below.  Please note that the
biggest difference between the compiling and non-compiling machines is
that the non-compiling machine has a slightly older os patch level, Veritas
File system and Veritas Volume manager installed, and is a clearcase
server.  Otherwise, the gcc, binutils, make, etc packages are all the same. 

What do you all think?

--jason


the error is:
gcc -DHAVE_CONFIG_H -I. -I. -I../config -I../common-src  
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2   
-c `test -f sendbackup-dump.c || echo './'`sendbackup-dump.c
sendbackup-dump.c: In function `start_backup':
sendbackup-dump.c:244: `no_record' undeclared (first use in this 
function)
sendbackup-dump.c:244: (Each undeclared identifier is reported only 
once
sendbackup-dump.c:244: for each function it appears in.)
make[1]: *** [sendbackup-dump.o] Error 1
make[1]: Leaving directory `/net/jetstream/jetstream1/amanda/bybee/client-src'
make: *** [all-recursive] Error 1



-- 

~~~
Jason Brooks ~ (503) 641-3440 x1861
  Direct ~ (503) 924-1861
System / Network Administrator 
Wind River Systems
8905 SW Nimbus ~ Suite 255  
Beaverton, Or 97008



Re: Compile error, resolution, confusion

2002-06-24 Thread Jon LaBadie

On Mon, Jun 24, 2002 at 01:10:24PM -0700, Jason Brooks wrote:
> Hello,
> 
> I have been reading through the archives and found a bit of information
> that helped me.
> 
> for amanda 2.4.3b3, I received errors while compiling on a solaris8 (bybee)
> machine.  I applied a change I found in reference to this error, and the
> compiler error went away.  the wierd part: this error didn't happen on
> different machines running solaris8(bramble), 7, 251, redhat 6.2-7.2, or 
> freebsd3.4.
> 
> the change was to line 244 of client-src/sendbackup-dump.c:
>   I changed "no_record" to "options->no_record".  


I'm only looking at the 2.4.3.b"2" code, but I doubt it makes a difference.

Certainly your change is not the proper correction.  The "options" identifier
I see is a character pointer, not a structure pointer.  Also, the no_record
parameter should be in scope as an external integer.  It is a flag as to
whether the no record option is set in the configuration.

Check sendbackup.c.  In my code, line 55 has the declaration.
Check sendbackup.h.  In my code, line 65 has the definition.
Check sendbackup-dump.c and confirm sendbackup.h is being included.

If your correction is valid, there are lots of places around line 244 that
should be similarly corrected.

-- 
Jon H. LaBadie  [EMAIL PROTECTED]
 JG Computing
 4455 Province Line Road(609) 252-0159
 Princeton, NJ  08540-4322  (609) 683-7220 (fax)



RE: Compile error, resolution, confusion

2002-06-27 Thread Robert Bottomley

I was just about to report the same thing. Amanda 2.4.3b3 would not compile
under IRIX 6.5. I came up with the following fix:


--- client-src/sendbackup-dump.c.orig  Fri Jun 21 01:31:32 2002
+++ client-src/sendbackup-dump.c   Fri Jun 21 01:32:31 2002
@@ -215,7 +215,7 @@
dumppid = pipespawn(progname, STDIN_PIPE,
&dumpin, &dumpout, &mesgf,
"xfsdump",
-   no_record ? "-J" : skip_argument,
+   options->no_record ? "-J" : skip_argument,
"-F",
"-l", dumpkeys,
"-",
@@ -241,7 +241,7 @@
program->restore_name = VXRESTORE;

dumpkeys = vstralloc(level_str,
-no_record ? "" : "u",
+options->no_record ? "" : "u",
 "s",
 "f",
 NULL);
@@ -282,7 +282,7 @@
program->restore_name = VRESTORE;

dumpkeys = vstralloc(level_str,
-no_record ? "" : "u",
+options->no_record ? "" : "u",
 "b",
 "f",
 NULL);
@@ -350,7 +350,7 @@
 /* AIX backup program */
 dumpkeys = vstralloc("-",
 level_str,
-no_record ? "" : "u",
+options->no_record ? "" : "u",
 "f",
 NULL);


- - - - - - - - - - - - - - - - - - - - - - - - - -
Robert Bottomley | E-mail: [EMAIL PROTECTED]
System Administrator | Tel: 909-781-5788   /~\The ASCII
College of Engineering   | Fax: 909-781-5790   \ / Ribbon Campaign
Center for Environmental | CE-CERT  X  Against
Research and Technology  | UC Riverside/ \   HTML Email!


-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]]On Behalf Of Jason Brooks
Sent: Monday, June 24, 2002 1:10 PM
To: [EMAIL PROTECTED]; [EMAIL PROTECTED]
Subject: Compile error, resolution, confusion


Hello,

I have been reading through the archives and found a bit of information
that helped me.

for amanda 2.4.3b3, I received errors while compiling on a solaris8 (bybee)
machine.  I applied a change I found in reference to this error, and the
compiler error went away.  the wierd part: this error didn't happen on
different machines running solaris8(bramble), 7, 251, redhat 6.2-7.2, or
freebsd3.4.

the change was to line 244 of client-src/sendbackup-dump.c:
I changed "no_record" to "options->no_record".

Interestingly enough, this appears to compile just as well on the other
machines too.

I have installed on both solaris machines:
binutils-2.11.2-sol8-sparc-local
bison-1.28-sol8-sparc-local
flex-2.5.4a-sol8-sparc-local
gcc-3.0.3-sol8-sparc-local
libgcc-3.0.3-sol8-sparc-local
make-3.79.1-sol8-sparc-local



I will include the compiler error messages below.  Please note that the
biggest difference between the compiling and non-compiling machines is
that the non-compiling machine has a slightly older os patch level, Veritas
File system and Veritas Volume manager installed, and is a clearcase
server.  Otherwise, the gcc, binutils, make, etc packages are all the same.

What do you all think?

--jason


the error is:
gcc -DHAVE_CONFIG_H -I. -I. -I../config -I../common-src
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2
-c `test -f sendbackup-dump.c || echo './'`sendbackup-dump.c
sendbackup-dump.c: In function `start_backup':
sendbackup-dump.c:244: `no_record' undeclared (first use in this
function)
sendbackup-dump.c:244: (Each undeclared identifier is reported only
once
sendbackup-dump.c:244: for each function it appears in.)
make[1]: *** [sendbackup-dump.o] Error 1
make[1]: Leaving directory
`/net/jetstream/jetstream1/amanda/bybee/client-src'
make: *** [all-recursive] Error 1



--

~~~
Jason Brooks ~ (503) 641-3440 x1861
  Direct ~ (503) 924-1861
System / Network Administrator
Wind River Systems
8905 SW Nimbus ~ Suite 255
Beaverton, Or 97008