Re: Review Request: amvault --only-fulls option

2010-08-29 Thread Dustin J. Mitchell
On Tue, Aug 24, 2010 at 2:00 AM, Marc Muehlfeld
 wrote:
> Can I use this for migrating hundred of my old DLT 40/80 GB tapes (All
> contain level 0 dumps for long time archiving) to some LTO30 400/800 GB?

Absolutely!

Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com


Re: Review Request: amvault --only-fulls option

2010-08-23 Thread Marc Muehlfeld

Am 24.08.2010 00:29, schrieb Dustin J. Mitchell:

That means that amvault can now re-assemble dumps from

> the source volume and re-split them on the destination volume.

Can I use this for migrating hundred of my old DLT 40/80 GB tapes (All contain 
level 0 dumps for long time archiving) to some LTO30 400/800 GB?



Regards,
Marc



Re: Review Request: amvault --only-fulls option

2010-08-23 Thread Dustin J. Mitchell
On Mon, Aug 23, 2010 at 9:15 PM, Chris Nighswonger
 wrote:
> Here's how it reads to me: Now we pass in a dump level when creating
> our dump spec object. For the present, the only dump level supported
> is 0 or full.
>
> Without testing (sorry, I'm not setup to test atm), it looks fine to me.

Great!  Thanks!  Buildbot is running amvault, and we'll get some extra
testing in the next releases, so that's good enough for me!

Committed - r3341.

Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com


Re: Review Request: amvault --only-fulls option

2010-08-23 Thread Chris Nighswonger
On Mon, Aug 23, 2010 at 6:29 PM, Dustin J. Mitchell  wrote:
> I've already rewritten amvault to use the same underlying machinery as
> amfetchdump and taper -- at the same time.  That means that amvault
> can now re-assemble dumps from the source volume and re-split them on
> the destination volume.
>
> Making this more general requires some hard thought about
> configurations and whatnot, but in the interim, it was pretty easy to
> add support for a frequently-requested feature: only vaulting full
> dumps.
>
> I've implemented it here (and I checked the link this time):
>  http://github.com/djmitche/amanda/commit/z11694
> and the patch is attached, as well.
>
> Like last time, it'd be great if someone could take a look and, if the
> patch looks good, let me know.  Please feel free to add any comments
> on the github commit, too.
>

Here's how it reads to me: Now we pass in a dump level when creating
our dump spec object. For the present, the only dump level supported
is 0 or full.

Without testing (sorry, I'm not setup to test atm), it looks fine to me.

Kind Regards,
Chris



Review Request: amvault --only-fulls option

2010-08-23 Thread Dustin J. Mitchell
I've already rewritten amvault to use the same underlying machinery as
amfetchdump and taper -- at the same time.  That means that amvault
can now re-assemble dumps from the source volume and re-split them on
the destination volume.

Making this more general requires some hard thought about
configurations and whatnot, but in the interim, it was pretty easy to
add support for a frequently-requested feature: only vaulting full
dumps.

I've implemented it here (and I checked the link this time):
  http://github.com/djmitche/amanda/commit/z11694
and the patch is attached, as well.

Like last time, it'd be great if someone could take a look and, if the
patch looks good, let me know.  Please feel free to add any comments
on the github commit, too.

Thanks again to Chris for the last review!
Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com


0001-add-fulls-only-to-amvault.patch
Description: Binary data