amdump  myconfig
  has been crashing during the report phase  -- after the dumps are
done and okay.   We are at 2.5.1p2    which was thought to fix this,
but it hasn't helped.
   After some local debugging,   my  expert source tells me
that this patch should fix the problem  (it fixed ours):



The main() function in reporter.c has the lines:

    if (postscript) {
        do_postscript_output();
    }

such that the function do_postscript_output() will only be called if the
variable postscript is not null...

however the function do_postscript_output() subsequently calls the
function copy_template_file() which MAY under several conditions call the
function afclose(postscript), that sets the postscript variable to NULL

after the return from copy_template_file() to do_postscript_output() the
do_postscript_output() function proceeds to call fprintf() with the
assumption that the postscript variable is valid, resulting in a core
dump.

The following diff should cure that core dump.

diff -wub reporter.c.orig reporter.c
--- reporter.c.orig     Thu Feb  8 14:16:40 2007
+++ reporter.c  Thu Feb  8 14:17:16 2007
@@ -2796,6 +2796,8 @@

        copy_template_file(tapetype_get_lbl_templ(tp));

+       if (postscript == NULL) return;
+
        /* generate a few elements */
        fprintf(postscript,"(%s) DrawDate\n\n",
                    nicedate(run_datestamp ? run_datestamp : "0"));

Please report this information back to the amanda developers.
(I'll add the patch and install on our server.)

Thanks,

 - Tim

Reply via email to