Re: Review Request: Fix 266645: Update wikipedia applet when metadata in a stream changes.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100953/ --- (Updated March 26, 2011, 6:10 p.m.) Review request for Amarok and Rick W. Chen. Summary --- WikipediaEnginePrivate has a member "Meta::TrackPtr currentTrack" and to check if an update is required this member is queried to get the previous track's data. This of course would not work as this member always returns the current data when a stream is being played. Can I replace this member with a struct to save Artist, Album and Track info? Bad idea? This addresses bug 266645. https://bugs.kde.org/show_bug.cgi?id=266645 Diffs - src/context/engines/wikipedia/WikipediaEngine.cpp 1fe80ae Diff: http://git.reviewboard.kde.org/r/100953/diff Testing --- Works with different streams. Tested by playing files as well. Thanks, Elbin ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Review Request: Fix 266645: Update wikipedia applet when metadata in a stream changes.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100953/ --- Review request for Amarok. Summary --- WikipediaEnginePrivate has a member "Meta::TrackPtr currentTrack" and to check if an update is required this member is queried to get the previous track's data. This of course would not work as this member always returns the current data when a stream is being played. Can I replace this member with a struct to save Artist, Album and Track info? Bad idea? This addresses bug 266645. https://bugs.kde.org/show_bug.cgi?id=266645 Diffs - src/context/engines/wikipedia/WikipediaEngine.cpp 1fe80ae Diff: http://git.reviewboard.kde.org/r/100953/diff Testing --- Works with different streams. Tested by playing files as well. Thanks, Elbin ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Amarok Crash in collection browser
Hi, looks like some TagLib internal error, probably file is corrupted. Does It always happen, or It was 1st time? 2011/3/26 Peter C. Ndikuwera : > Trying to browse through my collection, and Amarok crashed. I think it's > something to do with coverart in an MP4 audio file. > > Peter > > "Happiness makes up in height what it lacks in length" > -- Robert Frost > > ___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > > -- Sergey Ivanov ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Amarok Crash in collection browser
Trying to browse through my collection, and Amarok crashed. I think it's something to do with coverart in an MP4 audio file. Peter "Happiness makes up in height what it lacks in length" -- Robert Frost amarok-20110326-153129.kcrash Description: Binary data ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: GSoC: Amarok Mobile Foundations
On Fri, Mar 25, 2011 at 15:57, Maximilian Kossick wrote: > Good idea. Although I'd recommend to drop the additional collection > implementation or make it an optional goal. > In my opinion properly untangling the dependency mess that is Amarok, > not only with respect to Backend<->GUI but also Backend<->Backend, is > going to be hard enough. > > There should be network based collection implementation (Ampache?) > that are good enough for testing purposes and don't bring any > additional dependencies. Thank you. As advised, I've made it an optional goal. Cheers, -- Teo ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
