Re: Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Lucas, tried the PodcastProvider now that it is in Master. Fixed some Stuff (use of #DEFINES instead of constants & creation of own nam), but found some serious Problems: It uploads an EpisodeAction::PLAY every minute, which is not correct. Play should only be sent once to the Webservice, when I stop/pause/seek (not sure about seek, @stefankoegl can you clarify?) and not every minute. Please change this asap, cause if more users start using the gpodder service in Amarok the gpodder Server will receive too many requests. Also after restarting amarok and starting a podcast episode again from the start, the time in the EpisodeActions seem to be counted from the last point where I stopped it and not from the beginning (also try to find a way to set the start always to 00:00, it is always 00:01). Stefan -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk6aByMACgkQlZvAMV/NgGLjcgCgkIAsUvT9IXWvp0b0qO8lnT2u P14AoJmnL4cDmuTKTMFGleIpzapj1B29 =Kux6 -END PGP SIGNATURE- ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102844/#review7312 --- This review has been submitted with commit 720ccbd61d93651e3b394862a55b7e3f72f07b0c by Bart Cerneels to branch master. - Commit Hook On Oct. 13, 2011, 9:25 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102844/ > --- > > (Updated Oct. 13, 2011, 9:25 p.m.) > > > Review request for Amarok, Stefan Derkits and Bart Cerneels. > > > Description > --- > > The attached diff is the work done during this summer to integrate > gpodder.net web service with Amarok. > Notice that this diff have only GPodder service related stuff and that you > need to apply this > patch http://git.reviewboard.kde.org/r/102846/ before anything. > > Added features: > > Podcast subscription synchronisation. > Podcast status synchronisation. > Browse through podcasts suggested by gpodder.net. > Browse through gpodder.net top recommended podcasts. > > > Diffs > - > > ChangeLog 14422b1 > src/core-impl/podcasts/gpodder/GpodderPodcastMeta.h PRE-CREATION > src/core-impl/podcasts/gpodder/GpodderPodcastMeta.cpp PRE-CREATION > src/core-impl/podcasts/gpodder/GpodderProvider.h PRE-CREATION > src/core-impl/podcasts/gpodder/GpodderProvider.cpp PRE-CREATION > src/services/gpodder/CMakeLists.txt 97f14b3 > src/services/gpodder/GpodderConfigWidget.ui PRE-CREATION > src/services/gpodder/GpodderService.h fac508a > src/services/gpodder/GpodderService.cpp e0cb02f > src/services/gpodder/GpodderServiceConfig.h PRE-CREATION > src/services/gpodder/GpodderServiceConfig.cpp PRE-CREATION > src/services/gpodder/GpodderServiceModel.h 1fbc90d > src/services/gpodder/GpodderServiceModel.cpp d899456 > src/services/gpodder/GpodderServiceSettings.h PRE-CREATION > src/services/gpodder/GpodderServiceSettings.cpp PRE-CREATION > src/services/gpodder/GpodderTreeItem.h 5698d5b > src/services/gpodder/GpodderTreeItem.cpp bfa216e > src/services/gpodder/amarok_service_gpodder_config.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102844/diff/diff > > > Testing > --- > > This patch is the result of git diff for the range of several commits prior > to HEAD, rebased on current master, and should build. Everything is working > as expected and there aren't any known issues. > > > Thanks, > > Lucas Gomes > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: [GSoC] Amarok integration with gpodder.net (Playlist synchronisation stuff)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102846/#review7313 --- This review has been submitted with commit 818da5e60c242673e2016cca151732259953e21c by Bart Cerneels to branch master. - Commit Hook On Oct. 13, 2011, 9:25 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102846/ > --- > > (Updated Oct. 13, 2011, 9:25 p.m.) > > > Review request for Amarok, Stefan Derkits and Bart Cerneels. > > > Description > --- > > The attached diff is the work done during this summer to integrate > gpodder.net web service with Amarok. > Notice that this diff have only playlist synchronisation service related > stuff. > > > Diffs > - > > ChangeLog 14422b1 > src/CMakeLists.txt 962070d > src/browsers/playlistbrowser/PlaylistBrowserModel.h 76ccb10 > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp ff18d83 > src/browsers/playlistbrowser/PodcastModel.h ce1a86f > src/browsers/playlistbrowser/PodcastModel.cpp 4aad518 > src/browsers/playlistbrowser/QtGroupingProxy.cpp e0b4e7a > src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 2dcc0cd > src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp c64cb97 > src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 0a3c99a > src/core-impl/podcasts/sql/SqlPodcastMeta.h 0110911 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp e88bc9e > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 83e9b99 > src/core/playlists/Playlist.h f88b070 > src/core/podcasts/PodcastMeta.h 21364b4 > src/core/podcasts/PodcastMeta.cpp fb82fa8 > src/main.cpp 7306e84 > src/playlistmanager/PlaylistManager.h 54d63b1 > src/playlistmanager/PlaylistManager.cpp 333ff17 > src/playlistmanager/SyncRelationStorage.h 2a2681d > src/playlistmanager/SyncRelationStorage.cpp b151243 > src/playlistmanager/SyncedPlaylist.h 54914c7 > src/playlistmanager/SyncedPlaylist.cpp c8383b5 > src/playlistmanager/SyncedPodcast.h PRE-CREATION > src/playlistmanager/SyncedPodcast.cpp PRE-CREATION > src/playlistmanager/file/KConfigSyncRelStore.h 4674f66 > src/playlistmanager/file/KConfigSyncRelStore.cpp a857593 > src/playlistmanager/file/PlaylistFileProvider.cpp 728030d > src/playlistmanager/sql/SqlPlaylist.cpp b2a9ca5 > > Diff: http://git.reviewboard.kde.org/r/102846/diff/diff > > > Testing > --- > > This patch is the result of git diff for the range of several commits prior > to HEAD, rebased on current master, and should build. Everything is working > as expected and there aren't any known issues. > > > Thanks, > > Lucas Gomes > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
