Fwd: Amarok

2012-03-23 Thread Myriam Schweingruber 
Wrong mailing list

Regards, Myriam


-- Forwarded message --
From: Bezruchenko Alexandr 
Date: Fri, Mar 23, 2012 at 23:14
Subject: Amarok
To: kde-de...@kde.org


Does amarok have library to send requests to the Spotify?


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<



-- 
Proud member of the Amarok and KDE Community
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Proof of concept for the 2012 GSoC project idea 'Semantic Collection for Amarok'.

2012-03-23 Thread Bart Cerneels 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104369/#review11785
---


Code is clean and (probably) functional. Even though it's not supposed to be I 
would ship this.
It also makes me feel that a conversion utility from SQL -> nepomuk would not 
be to difficult to do.

- Bart Cerneels


On March 22, 2012, 4:58 p.m., Phalgun Guduthur wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104369/
> ---
> 
> (Updated March 22, 2012, 4:58 p.m.)
> 
> 
> Review request for Amarok and Teo Mrnjavac.
> 
> 
> Description
> ---
> 
> I have tried to demonstrate a basic read and write of Nepomuk index through 
> Amarok by altering how song ratings are stored.
> 
> When applied, this patch stores any changed rating of a song into the Nepomuk 
> index and not the Sql backend. To test this, change the rating of any song 
> through Amarok and check the attributes of that song using Dolphin 
> (song->properties). The song rating would have changed accordingly. 
> 
> To demonstrate the read part, Each song's rating is fetched from the Nepomuk 
> index instead of the Sql backend. To test this, change the rating of any song 
> through Dolphin and the same would be reciprocated in Amarok. 
> 
> Please note, this is only for proof of concept. This is not intended to be 
> shipped. 
> The code changes I have made are only temporary. The actual project will have 
> Nepomuk classes and handlers to do the same task. 
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/db/sql/CMakeLists.txt bdb3966 
>   src/core-impl/collections/db/sql/SqlMeta.cpp e663adf 
> 
> Diff: http://git.reviewboard.kde.org/r/104369/diff/
> 
> 
> Testing
> ---
> 
> The existing test cases work.
> It has been tried on numerous songs successfully on my computer.
> 
> 
> Thanks,
> 
> Phalgun Guduthur
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: GSoC Proposal: Statistics synchronization for pluggable devices and Last.fm

2012-03-23 Thread Teo Mrnjavac 
On Wed, Mar 21, 2012 at 00:06, Matěj Laitl  wrote:
> Hi Teo, Bart and list,
> as suggested by Teo, I've decided to try to take part in GSoC 2012 working as
> a student on Amarok. My idea is not on the KDE Ideas page, but I've been
> playing with (a variant of it) for months.
>
> Continues a very draft of my GSoC proposal. I'd be very grateful for any
> possible comments, pointed-out omissions or questions that may arise.
>
> Introduction
> ===
> Amarok has an ability to store per-track play statistics such as play count,
> first & last played date, rating and labels. It then has powerful means to
> generate custom-tailored playlists based on gathered statistics (e.g.: play me
> what I've listened to last month) that many users like to exploit. This works
> well when your computer is the only device you play music from. More likely
> situation is that you play music using Amarok at home, listen to iPod while
> commuting and use Amarok or another music player at work. All these 3 devices
> are able to keep track of what you've listened to, but each one only a third
> of it, which makes Amarok statistics more or less useless. This project aims
> to remedy the situation; Last.fm is an online service that can keep track of
> music a user listens to[1] and can help us with a part of this project. Amarok
> Users group on Last.fm has over 23 000 users.[2]
>
> Project Goals
> 
> This project will implement:
>  * track statistics synchronization between Amarok collections that support
> statistics; these are currently Local Collection and iPod Collection, but the
> framework will be general
>  * Last.fm scrobbling from pluggable media players that support statistics
> (iPods, currently) using the general framework from previous point
>  * ability to synchronize labels from Amarok to Last.fm
>  * ability to synchronize play counts, first & last played date from Last.fm 
> to
> Amarok collections (other way around is already implemented by scrobbling)
>  * GUI dialogue for performing the synchronization/resolving conflicts
>
> Bonus points (what will Amarok gain for free):
>  * ability to synchronize statistics of Amarok and other media player that
> scrobbles to Last.fm
>  * track statistics backup through Last.fm
>
> Caveats:
>  * Last.fm has no concept of track ratings. This can be however worked around
> by special Last.fm-side labels such as "7/10 stars"
>  * advanced features will be only available for Last.fm users; Last.fm is free
> to use, but the data are public which may be unpleasant for certain users
>
> Implementation
> =
> Amarok represents audio tracks by Meta::Track abstract C++ class that provides
> getter methods for meta-data (title, artist, album..) and getter/setter
> methods for statistics (rating, play count...). These tracks are grouped into
> so-called Collections, where each Collection represents one source of songs
> (iPod, Local, USB Mass Storage..). Tracks from different collections will be
> matched together using their meta-data and other collection's QueryMaker to
> perform the search. Moreover, iPods provide additional data that can be
> used for conflict-resolution: app_rating and recent_playcount. [3] I plan to
> expose these as new capability offered by Collections. This capability will
> also be used to implement Last.fm scrobbling from iPods (in fact, every
> collection that will support this capability), exploiting recent_playcount
> field in the iPod case. It should be noted that I have already implemented
> similar synchronization in my spare time back in summer 2011 [4], but I was
> not satisfied with its iPod-specific design and GUI, so I decided not to 
> strive
> for its inclusion. But I have the code working and ported to Amarok 2.5, so it
> can be used to fast-start this project.
>
> Another interesting note is that scrobble-from-iPod-to-Last.fm was functional
> in Amarok 1.4 days, but this feature got dropped during rewrites leading to
> 2.0, so this will fix one long-overdue regression.
>
> Speaking about Last.fm integration, Last.fm provides rather nice RESTful API
> [5] a subset of which is already used through liblastfm [6] library in Amarok
> to submit (scrobble) currently played songs. I plan to reuse this library and
> Amarok code dealing with it; the Last.fm API is powerful enough to support all
> claimed features. There is already even Last.fm on-line service Collection,
> but it focuses on playing Last.fm radio streams and doesn't handle individual
> tracks. In order to implement actual synchronization with Last.fm, user's
> Last.fm Library (that contains relevant track data) can be represented as a
> new (invisible) Collection or as special case in synchronizer, I have yet to
> decide this design choice.
>
> Timeline
> =
> [To be done when the general idea is accepted.] Generally: inter-collection
> synchronization will be first and will be done by the midterm evaluation,
> Last.fm support will be second. I'm already quite bound to Ama

Re: GSoC 2012 : Improvised proposal for 'Semantic Collection for Amarok'

2012-03-23 Thread Teo Mrnjavac 
On Thu, Mar 22, 2012 at 18:25, Phalgun Guduthur
 wrote:
> Hello
>
> I have been working towards the 2012 GSoC idea 'Semantic Collection for
> Amarok' since a month now. I have already sent in my first rough draft of
> the proposal.
>
> At that time, I promised a proof of Concept and you can it submitted on the
> review board https://git.reviewboard.kde.org/r/104369/
>
> It is a small patch demonstrating the read and write of Nepomuk index
> through Amarok.
>
> I have also attached my improvised proposal after interactions with both the
> mentors Teo and Vishesh.
>
> Please review my proposal whenever you find time. Any feedback is
> appreciated.
>
> Thanks
> Phalgun

Hello,

When I read "Improvised" I was a bit worried for a moment ;)
Overall the proposal is pretty good. I'd still like it if you could
think about the timeline a bit more. I'm not sure you can complete the
NepomukCollection before the NepomukQueryMaker. A bit more clarity in
the timeline could go a long way in convincing the team that you
understand the problem thoroughly.

The proof of concept looks good, simple and to the point.

Cheers,
-- 
Teo
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-23 Thread Jasneet Bhatti 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104307/
---

(Updated March 22, 2012, 8:33 p.m.)


Review request for Amarok.


Changes
---

Updated the description


Description (updated)
---

This patch implements https://bugs.kde.org/show_bug.cgi?id=214721 . The 
bookmark is movable within the slider. If it is dragged outside the range, it 
will revert back to its previous valid location. The bookmark is activated( 
seek is called ) only when the bookmark is clicked and its position hasn't 
changed.

In addition, also fixed a bug that caused deletion of the wrong bookmark when 
two bookmarks had the same name(possible by manual renaming), by making sure 
the location of the bookmark is appended to its name at all times.


Diffs
-

  src/amarokurls/BookmarkModel.cpp 9218088 
  src/amarokurls/AmarokUrl.h 6a1d67f 
  src/amarokurls/AmarokUrl.cpp 19ba210 
  src/amarokurls/BookmarkModel.h 73ae345 
  src/widgets/BookmarkTriangle.h 46e9118 
  src/widgets/BookmarkTriangle.cpp 4c59d42 
  src/widgets/SliderWidget.cpp 5e72e13 

Diff: http://git.reviewboard.kde.org/r/104307/diff/


Testing
---

Tested it on ubuntu 11.04 with kubuntu-desktop. Works fine for me.


Thanks,

Jasneet Bhatti

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-03-23 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review11771
---



src/browsers/AbstractTreeViewDelegate.h


I would be more verbose here:

bigFontMetrics();
smallFontMetrics();



src/browsers/CollectionTreeItemModelBase.cpp


Sorry, I fooled you in a bad way, I wanted to say that the height should be 
left at 34 pixels (i.e. untouched).


Could you please explain what are the benefits (direct, current - not 
hypothetical or philosofical) of the TreeItem -> NormalTreeItem, MergedTreeItem 
split? Where exactly is avoids code duplication?

- Matěj Laitl


On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 29, 2012, 6:42 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   ChangeLog 70dd420 
>   src/CMakeLists.txt 4241e69 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
>   src/core/podcasts/PodcastMeta.h 679f7ac 
>   src/core/podcasts/PodcastMeta.cpp b9851f7 
>   src/widgets/TrackSelectWidget.cpp 5bd5059 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/420/
> PodcastBr

Review Request: Proof of concept for the 2012 GSoC project idea 'Semantic Collection for Amarok'.

2012-03-23 Thread Phalgun Guduthur 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104369/
---

Review request for Amarok and Teo Mrnjavac.


Description
---

I have tried to demonstrate a basic read and write of Nepomuk index through 
Amarok by altering how song ratings are stored.

When applied, this patch stores any changed rating of a song into the Nepomuk 
index and not the Sql backend. To test this, change the rating of any song 
through Amarok and check the attributes of that song using Dolphin 
(song->properties). The song rating would have changed accordingly. 

To demonstrate the read part, Each song's rating is fetched from the Nepomuk 
index instead of the Sql backend. To test this, change the rating of any song 
through Dolphin and the same would be reciprocated in Amarok. 

Please note, this is only for proof of concept. This is not intended to be 
shipped. 
The code changes I have made are only temporary. The actual project will have 
Nepomuk classes and handlers to do the same task. 


Diffs
-

  src/core-impl/collections/db/sql/CMakeLists.txt bdb3966 
  src/core-impl/collections/db/sql/SqlMeta.cpp e663adf 

Diff: http://git.reviewboard.kde.org/r/104369/diff/


Testing
---

The existing test cases work.
It has been tried on numerous songs successfully on my computer.


Thanks,

Phalgun Guduthur

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel