[KDE Bugtracking System] REMINDER: current Amarok regressions

2012-07-06 Thread bugzilla_noreply 
Please find below a list of the current regressions reported for Amarok.

  This search was scheduled by myr...@kde.org.


Amarok regressions
--
Bug 230991:
  https://bugs.kde.org/show_bug.cgi?id=230991
  Priority: NOR  Severity: crash  Platform: Ubuntu Packages
  Assignee: amarok-bugs-d...@kde.org
Status: REOPENED
   Summary: Crash when dragging Magnatune genre to, "replace playlist" [@ 
ServiceSqlRegistry::getTrack]
Bug 231187:
  https://bugs.kde.org/show_bug.cgi?id=231187
  Priority: NOR  Severity: normal  Platform: Other
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Amarok progress bar startup position is wrong for single-file cue 
albums.
Bug 233282:
  https://bugs.kde.org/show_bug.cgi?id=233282
  Priority: NOR  Severity: normal  Platform: Gentoo Packages
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Seeking backwards with the keyboard in a cuesheeted song doesn't 
work.
Bug 233283:
  https://bugs.kde.org/show_bug.cgi?id=233283
  Priority: NOR  Severity: normal  Platform: Gentoo Packages
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Bumpy song transitions when listening to cuesheeted music
Bug 244506:
  https://bugs.kde.org/show_bug.cgi?id=244506
  Priority: NOR  Severity: normal  Platform: Ubuntu Packages
  Assignee: amarok-bugs-d...@kde.org
Status: UNCONFIRMED
   Summary: amarok: podcasts are not getting updates
Bug 264432:
  https://bugs.kde.org/show_bug.cgi?id=264432
  Priority: NOR  Severity: normal  Platform: Unlisted Binaries
  Assignee: amarok-bugs-d...@kde.org
Status: REOPENED
   Summary: good moodbar color scheme got removed
Bug 268492:
  https://bugs.kde.org/show_bug.cgi?id=268492
  Priority: NOR  Severity: major  Platform: Ubuntu Packages
  Assignee: amarok-bugs-d...@kde.org
Status: NEEDSINFO Resolution: WAITINGFORINFO
   Summary: Amarok default window geometry/dimensions on first start are wrong
Bug 281143:
  https://bugs.kde.org/show_bug.cgi?id=281143
  Priority: NOR  Severity: normal  Platform: Fedora RPMs
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Total playlist length is not displayed correctly - Again
Bug 284895:
  https://bugs.kde.org/show_bug.cgi?id=284895
  Priority: NOR  Severity: crash  Platform: Debian testing
  Assignee: amarok-bugs-d...@kde.org
Status: REOPENED
   Summary: Crash when trying to tag a corrupted file with MusicBrainz [@ 
MusicDNSAudioDecoder::run]
Bug 285712:
  https://bugs.kde.org/show_bug.cgi?id=285712
  Priority: NOR  Severity: major  Platform: Ubuntu Packages
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Resizing the Files Browser pane causes breadcrumbs to show in 
separate windows for each path level. Path doesn't show in the breadcrumb line 
at all
Bug 292245:
  https://bugs.kde.org/show_bug.cgi?id=292245
  Priority: HI  Severity: normal  Platform: Ubuntu Packages
  Assignee: amarok-bugs-d...@kde.org
Status: NEEDSINFO Resolution: WAITINGFORINFO
   Summary: stats lost after changing metadata and moving files within amarok.
Bug 292510:
  https://bugs.kde.org/show_bug.cgi?id=292510
  Priority: NOR  Severity: normal  Platform: openSUSE RPMs
  Assignee: amarok-bugs-d...@kde.org
Status: UNCONFIRMED
   Summary: Recently added albums widget not displaying with phonon-vlc backend 
after a songis played
Bug 295058:
  https://bugs.kde.org/show_bug.cgi?id=295058
  Priority: NOR  Severity: normal  Platform: Gentoo Packages
  Assignee: amarok-bugs-d...@kde.org
Status: NEEDSINFO Resolution: WAITINGFORINFO
   Summary: Amarok volume slider changes have no effect while playing
Bug 299461:
  https://bugs.kde.org/show_bug.cgi?id=299461
  Priority: NOR  Severity: normal  Platform: Ubuntu Packages
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: amarok: song starts playing before gain is adjusted
Bug 299890:
  https://bugs.kde.org/show_bug.cgi?id=299890
  Priority: NOR  Severity: normal  Platform: Fedora RPMs
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Bug #188330 is back: Playcount increased by 2 by "Stop Playing 
After Track"


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: mentor to localize amarok

2012-07-06 Thread Teo Mrnjavac 
On Thu, Jul 5, 2012 at 4:45 PM, Jaydev Ajit Kumar  wrote:
> Hi Teo
>
> i would like to help with help with localization of amarok ,i have been
> using amarok and i totally love it ,but when i play songs in Hindi , i do
> not get a lyrics list.
> this is what i would like to work on , getting the lyric list for songs in
> Hindi
> As i have never contributed to a open source before .. i really don no how
> to get about things
>
> i would really appreciate it if u could mentor me with my first contribution
> waiting to hear from you
>
> Regards
> Jaydev

Hello Jaydev,

Thank you for contacting us, your contributions would be very much
appreciated. Unfortunately I cannot mentor you personally, both
because I'm not familiar with that portion of code and also because
I'm already mentoring or co-mentoring two other students, but I'll try
to find someone who can help you and point you in the right direction.

It might be hard to find a full-time mentor right now because
everybody is occupied with Google Summer of Code and Season of KDE, so
I would suggest that you try to get started and submit a patch on your
own, and ask here or on IRC in #amarok on Freenode if you get stuck.
All the information you need to get started should be available in the
Amarok wiki.

I'm CCing this email to our development list, and I'll ask around if
there's someone who could step up and give you a helping hand.

Cheers,
-- 
Teo Mrnjavac
http://teom.org  |  t...@kde.org
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Jasneet Bhatti 


> On July 6, 2012, 9:57 a.m., Matěj Laitl wrote:
> > tests/core/collections/support/TestTrackForUrlWorker.cpp, line 113
> > 
> >
> > You can use m_emittedTrack on the left side here. Also, why don't you 
> > use QCOMPARE? It gives better messages in case of error.

Silly me ! Of course private members are accessible within the class. *After 
effects of sleep deprivation*

And the argument you hold here for QCOMPARE is exactly the reason I used it in 
the previous issue. But yes, it doesn't really matter there but very much here.


- Jasneet


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/#review15450
---


On July 6, 2012, 5:38 p.m., Jasneet Bhatti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105389/
> ---
> 
> (Updated July 6, 2012, 5:38 p.m.)
> 
> 
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
> 
> 
> Description
> ---
> 
> Added unit test for core/collections/support/TrackForUrlWorker
> 
> Just the one slot completeJob() to test.
> Tested for both KUrl and QString types of urls.
> 
> 
> Diffs
> -
> 
>   tests/core/collections/CMakeLists.txt b01b655 
>   tests/core/collections/support/CMakeLists.txt PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105389/diff/
> 
> 
> Testing
> ---
> 
> Builds and runs fine.
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Jasneet Bhatti 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/
---

(Updated July 6, 2012, 5:38 p.m.)


Review request for Amarok, Matěj Laitl and Sven Krohlas.


Changes
---

I guess this should solve all issues.

Some of the code style issues arise from the autocomplete feature of KDevelop, 
where I edit one part to comply with the style and miss some other part :P


Description
---

Added unit test for core/collections/support/TrackForUrlWorker

Just the one slot completeJob() to test.
Tested for both KUrl and QString types of urls.


Diffs (updated)
-

  tests/core/collections/CMakeLists.txt b01b655 
  tests/core/collections/support/CMakeLists.txt PRE-CREATION 
  tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
  tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
  tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
  tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105389/diff/


Testing
---

Builds and runs fine.


Thanks,

Jasneet Bhatti

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/#review15450
---


Just minor things are left now:


tests/core/collections/support/TestTrackForUrlWorker.h


No need for this method.



tests/core/collections/support/TestTrackForUrlWorker.cpp


unused include



tests/core/collections/support/TestTrackForUrlWorker.cpp


code style: extra line.



tests/core/collections/support/TestTrackForUrlWorker.cpp


No! Threadweaver calls run() from itself in a thread!



tests/core/collections/support/TestTrackForUrlWorker.cpp


shorter: QVERIFY( receivedDone )



tests/core/collections/support/TestTrackForUrlWorker.cpp


You can use m_emittedTrack on the left side here. Also, why don't you use 
QCOMPARE? It gives better messages in case of error.



tests/core/collections/support/TestTrackForUrlWorker.cpp


code style: spacer around argument.



tests/mocks/MockTrackForUrlWorker.h


Originally I thought that "ad-hoc" is for mocks that are all defined inline 
in a test .cpp file.



tests/mocks/MockTrackForUrlWorker.h


No need to mention finishedLookup, I'd rather mention that it fetches the 
track from QTest data-driven testing variable named track and assigns it to 
m_track.



tests/mocks/MockTrackForUrlWorker.h


Hmm, if you have a .cpp file, I would put the implementation there.


- Matěj Laitl


On July 6, 2012, 8:54 a.m., Jasneet Bhatti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105389/
> ---
> 
> (Updated July 6, 2012, 8:54 a.m.)
> 
> 
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
> 
> 
> Description
> ---
> 
> Added unit test for core/collections/support/TrackForUrlWorker
> 
> Just the one slot completeJob() to test.
> Tested for both KUrl and QString types of urls.
> 
> 
> Diffs
> -
> 
>   tests/core/collections/CMakeLists.txt b01b655 
>   tests/core/collections/support/CMakeLists.txt PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105389/diff/
> 
> 
> Testing
> ---
> 
> Builds and runs fine.
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Matěj Laitl 


> On July 5, 2012, 9:29 p.m., Matěj Laitl wrote:
> > tests/core/collections/support/TestTrackForUrlWorker.cpp, line 94
> > 
> >
> > testCompleteJobKUrl_data() and testCompleteJobQString_data() can share 
> > code, too, I suggest non-slot private testCompleteJobInternal_data()
> 
> Jasneet Bhatti wrote:
> Apparently, having a standalone textCompleteJobInternal_data() doesn't 
> suffice as textCompleteJobInternal() isn't a test function.
> 
> So, testCompleteJobKUrl_data() and testCompleteJobQString_data() both 
> call textCompleteJobInternal_data() to add test data.

Oh yeah, I worded myself incorrectly - I meant it like you did. Good you use 
your common sense interpreting my comments. In fact, do try to object them, I 
may not be right, too.


- Matěj


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/#review15417
---


On July 6, 2012, 8:54 a.m., Jasneet Bhatti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105389/
> ---
> 
> (Updated July 6, 2012, 8:54 a.m.)
> 
> 
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
> 
> 
> Description
> ---
> 
> Added unit test for core/collections/support/TrackForUrlWorker
> 
> Just the one slot completeJob() to test.
> Tested for both KUrl and QString types of urls.
> 
> 
> Diffs
> -
> 
>   tests/core/collections/CMakeLists.txt b01b655 
>   tests/core/collections/support/CMakeLists.txt PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105389/diff/
> 
> 
> Testing
> ---
> 
> Builds and runs fine.
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Jasneet Bhatti 


> On July 5, 2012, 9:29 p.m., Matěj Laitl wrote:
> > tests/core/collections/support/TestTrackForUrlWorker.h, line 29
> > 
> >
> > Why these are public? Data members should be normally private.

Done away with these


> On July 5, 2012, 9:29 p.m., Matěj Laitl wrote:
> > tests/core/collections/support/TestTrackForUrlWorker.cpp, line 94
> > 
> >
> > testCompleteJobKUrl_data() and testCompleteJobQString_data() can share 
> > code, too, I suggest non-slot private testCompleteJobInternal_data()

Apparently, having a standalone textCompleteJobInternal_data() doesn't suffice 
as textCompleteJobInternal() isn't a test function.

So, testCompleteJobKUrl_data() and testCompleteJobQString_data() both call 
textCompleteJobInternal_data() to add test data.


- Jasneet


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/#review15417
---


On July 6, 2012, 8:54 a.m., Jasneet Bhatti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105389/
> ---
> 
> (Updated July 6, 2012, 8:54 a.m.)
> 
> 
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
> 
> 
> Description
> ---
> 
> Added unit test for core/collections/support/TrackForUrlWorker
> 
> Just the one slot completeJob() to test.
> Tested for both KUrl and QString types of urls.
> 
> 
> Diffs
> -
> 
>   tests/core/collections/CMakeLists.txt b01b655 
>   tests/core/collections/support/CMakeLists.txt PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105389/diff/
> 
> 
> Testing
> ---
> 
> Builds and runs fine.
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

2012-07-06 Thread Jasneet Bhatti 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/
---

(Updated July 6, 2012, 8:54 a.m.)


Review request for Amarok, Matěj Laitl and Sven Krohlas.


Changes
---

Now only one mock class exists.
Contrived helper methods done away with and _real usage_ implementation for 
testing done.
Also, test data now comes from the existing tracks available for tests in the 
tests/data folder instead of mock tracks.


Description
---

Added unit test for core/collections/support/TrackForUrlWorker

Just the one slot completeJob() to test.
Tested for both KUrl and QString types of urls.


Diffs (updated)
-

  tests/core/collections/CMakeLists.txt b01b655 
  tests/core/collections/support/CMakeLists.txt PRE-CREATION 
  tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
  tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
  tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
  tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105389/diff/


Testing
---

Builds and runs fine.


Thanks,

Jasneet Bhatti

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel