Re: Review Request 107476: clear filter history
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107476/#review26535 --- I have seen that a lot of work has been invested in getting the coding style issues corrected. However I tend to agree with Matěj's comment. Do we really need it there? Actually, do we really need it at all? Is there a bug/wish related to this? We have wishes with a couple of hundred votes. I never felt the search history in need of cleaning. Expecially since it's cleaned at every restart. It's sometimes hard to realize (and more so after a lot of work has been invested) that sometimes a nice functionality just isn't worth the increased code complexity, translation and maintenance effort. - Ralf Engels On Nov. 26, 2012, 5:45 p.m., Manuel Finessi wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107476/ --- (Updated Nov. 26, 2012, 5:45 p.m.) Review request for Amarok. Description --- Hi, this patch implement (very simple) clear filter history. This addresses bug 310582. https://bugs.kde.org/show_bug.cgi?id=310582 Diffs - src/dialogs/EditFilterDialog.cpp 4caabd3 src/widgets/SearchWidget.h 897d843 src/widgets/SearchWidget.cpp afa4e7b Diff: http://git.reviewboard.kde.org/r/107476/diff/ Testing --- Screenshots --- clear button http://git.reviewboard.kde.org/r/107476/s/854/ Thanks, Manuel Finessi ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 108717: nepomuk: implement custom QueryMaker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 2, 2013, 3:46 p.m.) Review request for Amarok and Vishesh Handa. Description --- nepomuk: implement custom QueryMaker Diffs - src/core-impl/collections/nepomukcollection/CMakeLists.txt 642919bd7b2188c6055308eabc07319ae48e14be src/core-impl/collections/nepomukcollection/NepomukCache.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukCache.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukCollection.h 2c73fea67fd0f79d12d867907e055872372191aa src/core-impl/collections/nepomukcollection/NepomukCollection.cpp a85dc1ee1b7b987e501354d75364ed16d3f023cb src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h 33167333a1a3537b30b1449232d4987bab3bd047 src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp 446346f3944e3b0ddf627d1d1b985006ffe27691 src/core-impl/collections/nepomukcollection/NepomukInquirer.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukInquirer.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukParser.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukParser.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukQueryMaker.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.h 8456ddb8d952e130816d01fc312c8df3146e83d1 src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.cpp 76c9136f9d4f5ba77cac49b242b3aa3b2d844c0c src/core-impl/collections/nepomukcollection/meta/NepomukArtist.h 7cf533e760b0a06e5a2316693e13f6aea0ac3dcd src/core-impl/collections/nepomukcollection/meta/NepomukArtist.cpp 34d7c8f9c32f96be0ef5f81de9d58bfedb510c2d src/core-impl/collections/nepomukcollection/meta/NepomukComposer.h 837c37fa5dce5c3c10e6840f618cf72430b51b3d src/core-impl/collections/nepomukcollection/meta/NepomukComposer.cpp 33ba85ae11100e8ccbb5cc94a2d7d0e2007fdbd1 src/core-impl/collections/nepomukcollection/meta/NepomukGenre.cpp c34831ab4812f0241ceef844c2ea2397ae97 src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h 27ff06d9e895d6d18b3f700d99ffaafb42288b4d src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp 6d5bcf791ce88b42db9cf765b804ca5239d63c7d src/core-impl/collections/nepomukcollection/meta/NepomukYear.h 9eca44fbcd3aab77149d864cb6d3e5d266cc8461 src/core-impl/collections/nepomukcollection/meta/NepomukYear.cpp 1d6e3b1066e13fd6adba15ae6b1d81f8ca28a5d9 Diff: http://git.reviewboard.kde.org/r/108717/diff/ Testing --- Playing tracks from Nepomuk collection, browsing, filtering. Thanks, Edward Hades Toroshchin ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 108717: nepomuk: implement custom QueryMaker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 2, 2013, 4:25 p.m.) Review request for Amarok and Vishesh Handa. Description --- nepomuk: implement custom QueryMaker Diffs (updated) - src/core-impl/collections/nepomukcollection/CMakeLists.txt 642919bd7b2188c6055308eabc07319ae48e14be src/core-impl/collections/nepomukcollection/NepomukCache.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukCache.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukCollection.h 2c73fea67fd0f79d12d867907e055872372191aa src/core-impl/collections/nepomukcollection/NepomukCollection.cpp a85dc1ee1b7b987e501354d75364ed16d3f023cb src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h 33167333a1a3537b30b1449232d4987bab3bd047 src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp 446346f3944e3b0ddf627d1d1b985006ffe27691 src/core-impl/collections/nepomukcollection/NepomukInquirer.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukInquirer.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukParser.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukParser.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukQueryMaker.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.h 8456ddb8d952e130816d01fc312c8df3146e83d1 src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.cpp 76c9136f9d4f5ba77cac49b242b3aa3b2d844c0c src/core-impl/collections/nepomukcollection/meta/NepomukArtist.h 7cf533e760b0a06e5a2316693e13f6aea0ac3dcd src/core-impl/collections/nepomukcollection/meta/NepomukArtist.cpp 34d7c8f9c32f96be0ef5f81de9d58bfedb510c2d src/core-impl/collections/nepomukcollection/meta/NepomukComposer.h 837c37fa5dce5c3c10e6840f618cf72430b51b3d src/core-impl/collections/nepomukcollection/meta/NepomukComposer.cpp 33ba85ae11100e8ccbb5cc94a2d7d0e2007fdbd1 src/core-impl/collections/nepomukcollection/meta/NepomukGenre.cpp c34831ab4812f0241ceef844c2ea2397ae97 src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h 27ff06d9e895d6d18b3f700d99ffaafb42288b4d src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp 6d5bcf791ce88b42db9cf765b804ca5239d63c7d src/core-impl/collections/nepomukcollection/meta/NepomukYear.h 9eca44fbcd3aab77149d864cb6d3e5d266cc8461 src/core-impl/collections/nepomukcollection/meta/NepomukYear.cpp 1d6e3b1066e13fd6adba15ae6b1d81f8ca28a5d9 Diff: http://git.reviewboard.kde.org/r/108717/diff/ Testing --- Playing tracks from Nepomuk collection, browsing, filtering. Thanks, Edward Hades Toroshchin ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Phonon GStreamer 4.6.3 Released
Another ever so lovely release of the GStreamer backend got out. It resolves various annoyances users of Amarok and Tomahawk experienced. More information @ [1] [1] http://wm161.net/2013/02/01/phonon-gstreamer-4-6-3/ regards, HS and the Phonominals ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 108717: nepomuk: implement custom QueryMaker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 2, 2013, 10:26 p.m.) Review request for Amarok and Vishesh Handa. Description --- nepomuk: implement custom QueryMaker Diffs - src/core-impl/collections/nepomukcollection/CMakeLists.txt 642919bd7b2188c6055308eabc07319ae48e14be src/core-impl/collections/nepomukcollection/NepomukCache.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukCache.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukCollection.h 2c73fea67fd0f79d12d867907e055872372191aa src/core-impl/collections/nepomukcollection/NepomukCollection.cpp a85dc1ee1b7b987e501354d75364ed16d3f023cb src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h 33167333a1a3537b30b1449232d4987bab3bd047 src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp 446346f3944e3b0ddf627d1d1b985006ffe27691 src/core-impl/collections/nepomukcollection/NepomukInquirer.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukInquirer.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukParser.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukParser.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukQueryMaker.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.h 8456ddb8d952e130816d01fc312c8df3146e83d1 src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.cpp 76c9136f9d4f5ba77cac49b242b3aa3b2d844c0c src/core-impl/collections/nepomukcollection/meta/NepomukArtist.h 7cf533e760b0a06e5a2316693e13f6aea0ac3dcd src/core-impl/collections/nepomukcollection/meta/NepomukArtist.cpp 34d7c8f9c32f96be0ef5f81de9d58bfedb510c2d src/core-impl/collections/nepomukcollection/meta/NepomukComposer.h 837c37fa5dce5c3c10e6840f618cf72430b51b3d src/core-impl/collections/nepomukcollection/meta/NepomukComposer.cpp 33ba85ae11100e8ccbb5cc94a2d7d0e2007fdbd1 src/core-impl/collections/nepomukcollection/meta/NepomukGenre.cpp c34831ab4812f0241ceef844c2ea2397ae97 src/core-impl/collections/nepomukcollection/meta/NepomukLabel.h 6f2e54c3c6a0d350615cea0e335ed9f5c5a0eedf src/core-impl/collections/nepomukcollection/meta/NepomukLabel.cpp 7e2a313e5eac91128d0ce211c6575ac3d8d2b1ab src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h 27ff06d9e895d6d18b3f700d99ffaafb42288b4d src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp 6d5bcf791ce88b42db9cf765b804ca5239d63c7d src/core-impl/collections/nepomukcollection/meta/NepomukYear.h 9eca44fbcd3aab77149d864cb6d3e5d266cc8461 src/core-impl/collections/nepomukcollection/meta/NepomukYear.cpp 1d6e3b1066e13fd6adba15ae6b1d81f8ca28a5d9 Diff: http://git.reviewboard.kde.org/r/108717/diff/ Testing (updated) --- Playing tracks from Nepomuk collection, browsing, filtering, adding/removing labels. Thanks, Edward Hades Toroshchin ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Review Request 108716: FIX Randomize playlist with Ctrl+H
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- Review request for Amarok. Description --- Added a shortcut button for shuffle with default shortcut as Ctrl + H. Created a slot shuffleTrack() in mainWindow.cpp which is triggered on pressing Ctrl + H Diffs - src/MainWindow.h 4b23679 src/MainWindow.cpp 8587784 Diff: http://git.reviewboard.kde.org/r/108716/diff/ Testing --- File Attachments http://git.reviewboard.kde.org/media/uploaded/files/2013/02/02/0001-Randomize-playlist-with-Ctrl-H.patch Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
