Review Request: Fixed Bug 272346, unable to set MySQL password to 'password'

2012-04-27 Thread Lachlan Dufton

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104751/
---

Review request for Amarok.


Description
---

Fix for bug #272346. If the user set the MySQL password to password it would 
be interpreted as no password due to a mismatch in default config values.


This addresses bug 272346.
https://bugs.kde.org/show_bug.cgi?id=272346


Diffs
-

  
src/core-impl/collections/db/sql/mysqlservercollection/MySqlServerCollection.cpp
 7ae8bdf 

Diff: http://git.reviewboard.kde.org/r/104751/diff/


Testing
---

Tested connecting to an external database with passwords set to: , 
password, other and verified the correct connection was made in each case.


Thanks,

Lachlan Dufton

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Review Request: Bug 292081 - JJ: Label about info at opendesktop.org is truncated

2012-04-02 Thread Lachlan Dufton

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104464/
---

Review request for Amarok.


Description
---

Fix for bug #292081

AnimatedBarWidget is modified to wrap text when widget is too narrow.


This addresses bug 292081.
https://bugs.kde.org/show_bug.cgi?id=292081


Diffs
-

  src/aboutdialog/AnimatedBarWidget.h 8ec32ad 
  src/aboutdialog/AnimatedBarWidget.cpp f40dd6d 

Diff: http://git.reviewboard.kde.org/r/104464/diff/


Testing
---

Tested changed widget correctly wraps text when About dialog is resized.


Thanks,

Lachlan Dufton

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel