Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14599 --- One minor comment: Please don't remove copyright headers when copying files from another project--this is important for both legal and authorship (e.g. who do I ask when this code doesn't work) reasons. The ScriptResolver.* files come from Tomahawk, and I'm totally happy with you re-using the code that we wrote. However, you need to retain the same copyright header that exists in the original source file, and additionally adding your own copyright if you modify the file. This is the original: https://github.com/tomahawk-player/tomahawk/blob/master/src/libtomahawk/resolvers/ScriptResolver.cpp This is also why the ScriptResolver class supports external .js and non-spotify resolvers. It'll work with any external process that implements the playdar + tomahawk extensions resolver API. thanks! - Leo Franchi On June 10, 2012, 7:10 a.m., Zhengliang Feng wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/ --- (Updated June 10, 2012, 7:10 a.m.) Review request for Amarok. Description --- Add Spotify collection code Currently implemented SpotifyCollection, SpotifyQueryMaker and SpotifyMeta. The ScriptResolver is the class handles communcation with standalone Spotify resolver, the code is mainly from original ScriptResolver, but added more functions to handle messages separately. The controller class is used to start a ScriptResolver in a separate thread and handles queries. Diffs - src/core-impl/collections/CMakeLists.txt c78b9202ece71b51189c4e47d85acfa4a74ef8d6 src/core-impl/collections/spotifycollection/CMakeLists.txt PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyCollection.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyMeta.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyMeta.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp PRE-CREATION src/core-impl/collections/spotifycollection/support/Controller.h PRE-CREATION src/core-impl/collections/spotifycollection/support/Controller.cpp PRE-CREATION src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h PRE-CREATION src/core-impl/collections/spotifycollection/support/Query.h PRE-CREATION src/core-impl/collections/spotifycollection/support/ScriptResolver.h PRE-CREATION src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105201/diff/ Testing --- Communication between ScriptResolver and Spotify resolver( from Tomahawk resolver repo https://github.com/ofan/tomahawk-resolvers ). Logging into Spotify using a username and password. Thanks, Zhengliang Feng ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: GSoC report #2 - Integrate Spotify into Amarok
On May 27, 2012, at 10:13 PM, Ryan Feng wrote: Hi, The Spotify service plugin has two parts, a standalone Spotify resolver and a Amarok side Script Resolver, it's mainly from Tomahawk. I've rewrote the Amarok side resolver, it can work without Tomahawk base classes and headers now. Here[1] is the code. In the following week, I will continue working on the resolver to make it more suited for Amarok. [1] http://quickgit.kde.org/index.php?p=scratch%2Fzhengliangfeng%2Fgsoc-scratch.gita=summary Hi from one of the authors of the spotify resolver :) Please don't fork the resolver and make a bunch of amarok-specific changes. I'm more than happy to work together to make the resolver support both Tomahawk's and Amarok's needs together. If we end up with two different variants it is only a matter of time until one of the two bitrots and falls into disrepair, especially because Hugo and I are making frequent (and sometimes incompatible) changes to the spotify resolver as libspotify itself is often changing as well. I'm hanging out in the amarok channels as well as #tomahawk, so lets have some conversations to make sure the resolver can do what you need it to do. cheers, leo -- l...@kdab.com KDAB (USA), LLC lfran...@kde.org The KDE Project ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Fwd: Shutdown of V3 of the Echo Nest API is imminent.
HI guys, just an FYI: The echo nest dynamic playlist bias (is it even still there? I forget) uses the V3 version of the API. it would need to be ported to libechonest that uses the v4 of the api. cheers, leo Begin forwarded message: From: Paul Lamere p...@echonest.com Subject: Shutdown of V3 of the Echo Nest API is imminent. Date: December 14, 2011 10:22:32 AM EST To: undisclosed-recipients:; Greetings: Sometime in the next 48 hours, our machines that host V3 of the Echo Nest API will be shutdown. We announced the shutdown of V3 last year here: http://developer.echonest.com/forums/thread/280 This is the final notice. This week we will actually turn the machines off. Our V3 usage logs show that you've recently made V3 API calls. Once we shutdown V3 your calls will no longer work. If the application making the calls is important to you, you should switch it over to use V4 of our API. It is faster, has more features and is more stable. Please let me know if you have any questions. Paul -- Paul Lamere Director of Developer Platform The Echo Nest http://echonest.com http://MusicMachinery.com -- l...@kdab.com KDAB (USA), LLC lfran...@kde.org The KDE Project ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: diploma thesis done \o/
On Monday, May 02, 2011 01:12:39 PM Lydia Pintscher wrote: Heya folks :) I handed in the printed version of my thesis this morning. You can find the pdf version here: http://www.slideshare.net/lydiapintscher/collaborative-and-transparent-free- software-development Thanks so much to everyone who helped. Yayyy congrats! leo -- l...@kdab.com KDAB (USA), LLC lfran...@kde.org The KDE Project signature.asc Description: This is a digitally signed message part. ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Parts of Amarok which were built by GSoC students
Here are the projects: 2006: Ian - DAAP 207: Ian - New Amarok 2.0 Playlist Leo - Context View 2008: Alejandro - MediaDevice framework Daniel Winter - Nepomuk Collection Daniel Jones - Dynamic Playlists Casey - MP3Tunes integration Peter - Scripting API / support William - Context View 2009: Sven - Unit testing Teo - Playlist sorting Alejandro - More MediaDevice work 2010: Nikhil - UPnP Andrew - Playdar collection Teo - Transcoding Varrun - Remote amarok collections cheers, leo -- l...@kdab.com KDAB (USA), LLC lfran...@kde.org The KDE Project ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Playdar Collection
On Thursday, December 16, 2010 01:44:15 PM Bart Cerneels wrote: On Thu, Dec 16, 2010 at 11:51, Mark Kretschmann kretschm...@kde.org wrote: Hey all, recently several people have noticed that our new Playdar Collection is causing a slowdown in startup time. I'm wondering, should we not default-disable this feature? 1) It causes unnecessary slowdown. 2) Playdar itself is still Vaporware (as I hear), the original code base is no longer maintained. So it's of little use right now. We could still enable it in later versions. Thoughts? I would disable it regardless whether it has issues or not. Playdar is indeed not so mainstream that is would be useful to many people. Doubly so if it has issues, though the issues still need to be resolved. Stuffcorpse has created this branch that is perfectly suited: http://gitweb.kde.org/amarok.git/shortlog/refs/heads/rickc-pluginselection Not sure if we need it though, just disabling the service might be enough. I agree, it's not very useful right now. It would be best to disable it via Rick's new branch, but until that is merged post-2.4.0, I suggest disabling it in the .desktop file so it doesn't get loaded at run-time (but users who want it can still enable it). I have some plans for the service but it requires other software projects to to fall into line and those aren't ready yet. cheers, leo -- l...@kdab.com KDAB (USA), LLC lfran...@kde.org The KDE Project ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: New context menu applet to display guitar and bass-tablature
On 2010-11-28 13:03:52, Alexander Potashev wrote: I see white text instead of black, and it may be hard to read it on light blue background. Could you please make the text always black? Are you testing this patch? This has gone into amarok git and had a lot of updates there, so please test that instead. - Leo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100117/#review429 --- On 2010-11-01 18:36:05, Rainer Sigle wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100117/ --- (Updated 2010-11-01 18:36:05) Review request for Amarok. Summary --- This patch adds a new applet to the Amarok context menu: Tabs. It's designed for guitar and bass-players, as it downloads and displays tablature information for the current song. Directly playing along a song has therefore never been easier. The tab data is currently fetched from two sites: www.ultimateguitar.com and www.fretplay.com. As these provide no direct API, the tab data is extracted using some simple HTML parsing. Multiple results, e.g. versions of the tab, are stored and can be choosen from a list. A settings dialog allows to define the type of tabs to be fetched. In this patch we've guitar and bass, but it could be extended to e.g. drums or piano in the future. Furthermore I've added a reload button which allows to easily refine the criteria for the tab-search. This can be used e.g. when no tab-results were found because the song name contains fragments like (live), remix, etc. I'll send some new png-images to amarok devel mailinglist because I was not able to correctly include these binary files into the patch. Please be aware that I don't know if there are any copyright restrictions on these bitmaps! Maybe they can be replaced with some KDE/Plasma specific images. Unfortunately I didn't find anything appropriate. Thanks for any feedback on this... By the way: Also big Thanks! to all Amarok devs and supporters for their great work. I love this application. Diffs - src/context/applets/CMakeLists.txt 98bdd2b src/context/applets/tabs/CMakeLists.txt PRE-CREATION src/context/applets/tabs/ReloadEditDialog.ui PRE-CREATION src/context/applets/tabs/TabsApplet.h PRE-CREATION src/context/applets/tabs/TabsApplet.cpp PRE-CREATION src/context/applets/tabs/TabsItem.h PRE-CREATION src/context/applets/tabs/TabsItem.cpp PRE-CREATION src/context/applets/tabs/TabsSettings.ui PRE-CREATION src/context/applets/tabs/TabsView.h PRE-CREATION src/context/applets/tabs/TabsView.cpp PRE-CREATION src/context/applets/tabs/amarok-context-applet-tabs.desktop PRE-CREATION src/context/applets/tabs/amarok-tabs-bass.png PRE-CREATION src/context/applets/tabs/amarok-tabs-drum.png PRE-CREATION src/context/applets/tabs/amarok-tabs-guitar.png PRE-CREATION src/context/applets/tabs/amarok-tabs-piano.png PRE-CREATION src/context/engines/CMakeLists.txt c1f029e src/context/engines/tabs/CMakeLists.txt PRE-CREATION src/context/engines/tabs/TabsEngine.h PRE-CREATION src/context/engines/tabs/TabsEngine.cpp PRE-CREATION src/context/engines/tabs/TabsInfo.h PRE-CREATION src/context/engines/tabs/amarok-data-engine-tabs.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/100117/diff Testing --- used and tested during the last months, works fine for me Screenshots --- Tabs Applet http://git.reviewboard.kde.org/r/100117/s/9/ Thanks, Rainer ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: New context menu applet to display guitar and bass-tablature
On 2010-11-28 13:03:52, Alexander Potashev wrote: I see white text instead of black, and it may be hard to read it on light blue background. Could you please make the text always black? Leo Franchi wrote: Are you testing this patch? This has gone into amarok git and had a lot of updates there, so please test that instead. Alexander Potashev wrote: No, I'm not testing it. I use ReviewBoard as an alternative to KDE Bugzilla ;) Commenting on a closed review request is not the appropriate way of reporting bugs. I don't know what version you're running, if you're running this patch or git, etc. Please file a bug! :) - Leo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100117/#review429 --- On 2010-11-01 18:36:05, Rainer Sigle wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100117/ --- (Updated 2010-11-01 18:36:05) Review request for Amarok. Summary --- This patch adds a new applet to the Amarok context menu: Tabs. It's designed for guitar and bass-players, as it downloads and displays tablature information for the current song. Directly playing along a song has therefore never been easier. The tab data is currently fetched from two sites: www.ultimateguitar.com and www.fretplay.com. As these provide no direct API, the tab data is extracted using some simple HTML parsing. Multiple results, e.g. versions of the tab, are stored and can be choosen from a list. A settings dialog allows to define the type of tabs to be fetched. In this patch we've guitar and bass, but it could be extended to e.g. drums or piano in the future. Furthermore I've added a reload button which allows to easily refine the criteria for the tab-search. This can be used e.g. when no tab-results were found because the song name contains fragments like (live), remix, etc. I'll send some new png-images to amarok devel mailinglist because I was not able to correctly include these binary files into the patch. Please be aware that I don't know if there are any copyright restrictions on these bitmaps! Maybe they can be replaced with some KDE/Plasma specific images. Unfortunately I didn't find anything appropriate. Thanks for any feedback on this... By the way: Also big Thanks! to all Amarok devs and supporters for their great work. I love this application. Diffs - src/context/applets/CMakeLists.txt 98bdd2b src/context/applets/tabs/CMakeLists.txt PRE-CREATION src/context/applets/tabs/ReloadEditDialog.ui PRE-CREATION src/context/applets/tabs/TabsApplet.h PRE-CREATION src/context/applets/tabs/TabsApplet.cpp PRE-CREATION src/context/applets/tabs/TabsItem.h PRE-CREATION src/context/applets/tabs/TabsItem.cpp PRE-CREATION src/context/applets/tabs/TabsSettings.ui PRE-CREATION src/context/applets/tabs/TabsView.h PRE-CREATION src/context/applets/tabs/TabsView.cpp PRE-CREATION src/context/applets/tabs/amarok-context-applet-tabs.desktop PRE-CREATION src/context/applets/tabs/amarok-tabs-bass.png PRE-CREATION src/context/applets/tabs/amarok-tabs-drum.png PRE-CREATION src/context/applets/tabs/amarok-tabs-guitar.png PRE-CREATION src/context/applets/tabs/amarok-tabs-piano.png PRE-CREATION src/context/engines/CMakeLists.txt c1f029e src/context/engines/tabs/CMakeLists.txt PRE-CREATION src/context/engines/tabs/TabsEngine.h PRE-CREATION src/context/engines/tabs/TabsEngine.cpp PRE-CREATION src/context/engines/tabs/TabsInfo.h PRE-CREATION src/context/engines/tabs/amarok-data-engine-tabs.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/100117/diff Testing --- used and tested during the last months, works fine for me Screenshots --- Tabs Applet http://git.reviewboard.kde.org/r/100117/s/9/ Thanks, Rainer ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Playlist Queue Editor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/#review434 --- Code looks okay, will test functionality in a bit. Thanks! src/playlist/PlaylistActions.h http://git.reviewboard.kde.org/r/100177/#comment310 space ;) - Leo On 2010-11-28 22:41:19, Andreas Hartmetz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/ --- (Updated 2010-11-28 22:41:19) Review request for Amarok. Summary --- This adds a Queue Editor, with limited features (move up / move down / clear) like in Amarok 1. The KAction for it is not very well placed in the main UI, I hope you guys can help me. A few design changes were necessary, too, as you can see in the patch. This addresses bug 198180. https://bugs.kde.org/show_bug.cgi?id=198180 Diffs - src/CMakeLists.txt c5ee1e3 src/MainWindow.cpp f755b6f src/likeback/LikeBackBar.cpp 6964f88 src/playlist/PlaylistActions.h a0b2275 src/playlist/PlaylistActions.cpp d9284e7 src/playlist/PlaylistController.cpp f05c250 src/playlist/PlaylistDock.h f7f1231 src/playlist/PlaylistDock.cpp 6170f78 src/playlist/PlaylistItem.h 6bfeb68 src/playlist/PlaylistModel.h 7b7633f src/playlist/PlaylistModel.cpp 0162321 src/playlist/PlaylistQueueEditor.h PRE-CREATION src/playlist/PlaylistQueueEditor.cpp PRE-CREATION src/playlist/PlaylistQueueEditor.ui PRE-CREATION src/playlist/navigators/DynamicTrackNavigator.cpp a1c67e7 src/playlist/navigators/TrackNavigator.h 6154f9a src/playlist/navigators/TrackNavigator.cpp 2a70b08 src/playlist/proxymodels/AbstractModel.h 03ca4d6 src/playlist/proxymodels/ProxyBase.h 2e6f9e7 src/playlist/proxymodels/ProxyBase.cpp 37cb8cb src/playlist/view/PlaylistViewCommon.cpp 2a5c9f6 src/playlist/view/listview/PrettyItemDelegate.cpp 5494279 src/playlist/view/listview/PrettyListView.cpp 0b2e41e src/statusbar/StatusBar.cpp 1a67677 Diff: http://git.reviewboard.kde.org/r/100177/diff Testing --- worksforme Thanks, Andreas ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Playlist Queue Editor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/#review436 --- Ok, a few comments from using it. Here are issues I think need to be addressed: * I think the action should be centered like the other actions below the playlist, probable with a separator. * I think the default size of the dialog is too big, especially given how small the items are * Lacking icon for 3rd/bottom button * The list is sort of lacking. It should at least show the Artist as well, maybe like Artist - Title. * List doesn't update on track progression, but jumps ahead once a button is pressed and tracks have progressed * Dialog is modal---it shouldn't be, so the user can also add/remove stuff from the queue with the queue manager open. Hand in hand with this is the fact that the playlist should update to reflect any changes made in the dialog immediately And these are issues I think are nice but not required for version 1: * Tracks should be re-arrangable by drag-n-drop * Tracks from the playlist should be draggable onto the Queue Manager to queue them at a specific place cheers, leo - Leo On 2010-11-28 23:26:33, Andreas Hartmetz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/ --- (Updated 2010-11-28 23:26:33) Review request for Amarok. Summary --- This adds a Queue Editor, with limited features (move up / move down / clear) like in Amarok 1. The KAction for it is not very well placed in the main UI, I hope you guys can help me. A few design changes were necessary, too, as you can see in the patch. This addresses bug 198180. https://bugs.kde.org/show_bug.cgi?id=198180 Diffs - src/CMakeLists.txt c5ee1e3 src/MainWindow.cpp f755b6f src/likeback/LikeBackBar.cpp 6964f88 src/playlist/PlaylistActions.h a0b2275 src/playlist/PlaylistActions.cpp d9284e7 src/playlist/PlaylistController.cpp f05c250 src/playlist/PlaylistDock.h f7f1231 src/playlist/PlaylistDock.cpp 6170f78 src/playlist/PlaylistItem.h 6bfeb68 src/playlist/PlaylistModel.h 7b7633f src/playlist/PlaylistModel.cpp 0162321 src/playlist/PlaylistQueueEditor.h PRE-CREATION src/playlist/PlaylistQueueEditor.cpp PRE-CREATION src/playlist/PlaylistQueueEditor.ui PRE-CREATION src/playlist/navigators/DynamicTrackNavigator.cpp a1c67e7 src/playlist/navigators/TrackNavigator.h 6154f9a src/playlist/navigators/TrackNavigator.cpp 2a70b08 src/playlist/proxymodels/AbstractModel.h 03ca4d6 src/playlist/proxymodels/ProxyBase.h 2e6f9e7 src/playlist/proxymodels/ProxyBase.cpp 37cb8cb src/playlist/view/PlaylistViewCommon.cpp 2a5c9f6 src/playlist/view/listview/PrettyItemDelegate.cpp 5494279 src/playlist/view/listview/PrettyListView.cpp 0b2e41e src/statusbar/StatusBar.cpp 1a67677 Diff: http://git.reviewboard.kde.org/r/100177/diff Testing --- worksforme Thanks, Andreas ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Fixing Coverbling applet build from playground
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100146/#review426 --- Ship it! Sorry for the lack of review. Looks good to me. Do you have git push access or should I commit for you? - Leo On 2010-11-12 10:11:15, Manu Wagner wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100146/ --- (Updated 2010-11-12 10:11:15) Review request for Amarok. Summary --- ooops, removed the patch (thought it wasn't necessary anymore) hence submitting again... Diffs - playground/src/context/applets/coverbling/CoverBlingApplet.h 5ffc8b8 playground/src/context/applets/coverbling/CoverBlingApplet.cpp d5ac4df Diff: http://git.reviewboard.kde.org/r/100146/diff Testing --- Thanks, Manu ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: RFC: develop feature branches in main repo
On Tuesday, November 09, 2010 09:21:21 PM Bart Cerneels wrote: On Tue, Nov 9, 2010 at 17:04, Ian Monroe i...@monroe.nu wrote: On Tue, Nov 9, 2010 at 9:57 AM, Leo Franchi lfran...@kde.org wrote: On Tuesday, November 09, 2010 09:50:29 AM Ian Monroe wrote: I know some people are still using Gitorious repos and such for the ongoing work. However recently everyone has been granted the right to create branches on our git.kde.org/amarok.git repo. I think it would raise the visibility of feature branches if everyone just pushed them to the main repo. This would make things a bit 'messy', but I don't really think its a big problem. We could have a spring cleaning and move all the old branches into amarok-history if it becomes an issue. I do suggest that branches be named MMDD-description. +1 from me. Though I suggest for naming we could also do author-description instead. Yes, I think that naming scheme makes more sense. I don't agree since these kinds of branches are generally worked on by multiple people. So having one author in the name is weird. I think the date in the name makes more sense for spring cleaning purposes, although it's not needed at all thanks to git's metadata. Though even if it's a shared branch the creator of the branch can put his name on it :) The idea being there is some sort of easy categorization: so looking at the branches, you have an idea of who random branch X belongs to. Or even just use something like shared-mediadevicerefactor cheers, leo -- l...@kdab.com KDAB (USA), LLC lfran...@kde.org The KDE Project ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: New collection scanner
Hi Ralf, An update. After your various fixes, scanning is much faster now (yay QSharedMemory!) Now it gets stuck at 24%, here is the debug output: http://pastebin.com/HPadHHtf leo On Wednesday, November 03, 2010 06:09:35 PM Ralf Engels wrote: Hi all, since this morning (very early) the new collection scanner is integrated. It should allow us to implement exiting new features and it also has some benefits over the old scanner. However the change is quite big and we even might want to revert the fix if serious problems come up. For now a short overview about the new features and already known problems. - The new scanner should be smarter in figuring out if an album is a compilation or not. If compilation is set by the user this information should also be saved and used in the next scanning run. - Rating, playcount and score should be saved and restored. - The playlist and collection view should be always up-to-date. There might be an empty album if all songs are removed from one. There should however never be a case where right-clicking on a track does not bring up a context menu. - The scanner should be a lot smarter in detecting which cover belongs to which album. known issues: - Probably the most severe issue right now: The scanning seems to hang sometimes. Sometimes meaning once every four full scans on my machine. If you have such a problem: please send me the last few debug output lines from the scanner. - The progress bar is not progressing to 100% Actually I couldn't really figure out yet why this happens but I will eventually. - The scanner will mark an album with a single track as compilation more often than the old one did. I am still not sure if this is good or bad. For now I think it's a little annoying that a lot of my singles appear under various artists. So, if you have any opinions please drop me a message. - If you see two albums with the same name and artist that appear in the collection. That is probably an album with two different album artists and not directly connected to the scanner. performance: - I have done perfomance tests with the scanner processor but not with the whole scanner as such. The scanner is reading more information than before but that shouldn't slow it down by much. However lfranchi has reported an increased scanning time. If you also have this impression please try to give me some numbers. The scanning time of 2 mp3 files on a local disk should be below three minutes. Any new bugs, complaints or improvement request can be directed to me directly, IRC, bug tracker or as a patch on the review board. As always. Cheers, Ralf ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel -- l...@kdab.com KDAB (USA), LLC lfran...@kde.org The KDE Project ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Coverbling applet (playground) build fix
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100133/#review313 --- Ship it! Looks good to me too, after the minor whitespace fix! - Leo On 2010-11-05 15:59:22, Manu Wagner wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100133/ --- (Updated 2010-11-05 15:59:22) Review request for Amarok. Summary --- This fixes CoverBling applet build (broken since yesterday's delivery). Diffs - playground/src/context/applets/coverbling/CoverBlingApplet.h 5ffc8b8 playground/src/context/applets/coverbling/CoverBlingApplet.cpp d5ac4df Diff: http://git.reviewboard.kde.org/r/100133/diff Testing --- It works fine at my end. Compiles and runs OK Thanks, Manu ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Podcast Engine
On Friday, November 05, 2010 04:16:59 PM Ian Monroe wrote: Seems like it would make sense to decide on this now. If you want to make a plasma engine first (I'm personally not convinced plasma engines make sense for use in Amarok), it would matter if the resulting applet only worked with Podcasts or worked with any track. Not sure what you're trying to say here. First of all, data engines are already how the ui/data is separated in the context view. For example, both the Current Track applet and the Albums applet connect to the same Current engine. The podcast info can be shown either in it's own applet or in the albums applet, regardless of where the data is coming from... leo -- l...@kdab.com KDAB (USA), LLC lfran...@kde.org The KDE Project ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
