Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/ --- (Updated Aug. 17, 2013, 4:08 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Don't communicate with mysql by env vars and autogenerated files Instead of generating the my.cnf every time amarok starts and to pass the location of this file by setting an environment variable directly pass the settings as arguments to mysql. As this is probably a better approach and the only one working on windows. This fixes an issue where amarok is writing the database to C:\Program Files (x86)\Amarok\data\amarok. This issue prevents Amarok from running correctly, because regarding to the rights of the useraccount the directory can be not writeable. The commands used are taken from the output of mysqld --verbose --help. Diffs - src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp 0233498fdeb18ab51e709e9a78384fc37c47cb2a Diff: http://git.reviewboard.kde.org/r/110187/diff/ Testing --- Only on windows Thanks, Patrick von Reth ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/ --- (Updated July 19, 2013, 8:35 a.m.) Review request for Amarok. Changes --- no idea what did break the description here Summary (updated) - Don't communicate with mysql by env vars and autogenerated files Description --- Don't communicate with mysql by env vars and autogenerated files Instead of generating the my.cnf every time amarok starts and to pass the location of this file by setting an environment variable directly pass the settings as arguments to mysql. As this is probably a better approach and the only one working on windows. This fixes an issue where amarok is writing the database to C:\Program Files (x86)\Amarok\data\amarok. This issue prevents Amarok from running correctly, because regarding to the rights of the useraccount the directory can be not writeable. The commands used are taken from the output of mysqld --verbose --help. Diffs - src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp 0233498fdeb18ab51e709e9a78384fc37c47cb2a Diff: http://git.reviewboard.kde.org/r/110187/diff/ Testing --- Only on windows Thanks, Patrick von Reth ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110187: SVN_SILENT made messages (.desktop file)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/ --- (Updated July 18, 2013, 12:10 p.m.) Review request for Amarok. Changes --- use qvector Summary (updated) - SVN_SILENT made messages (.desktop file) Description --- Don't communicate with mysql by env vars and autogenerated files Instead of generating the my.cnf every time amarok starts and to pass the location of this file by setting an environment variable directly pass the settings as arguments to mysql. As this is probably a better approach and the only one working on windows. This fixes an issue where amarok is writing the database to C:\Program Files (x86)\Amarok\data\amarok. This issue prevents Amarok from running correctly, because regarding to the rights of the useraccount the directory can be not writeable. The commands used are taken from the output of mysqld --verbose --help. Diffs (updated) - src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp 0233498fdeb18ab51e709e9a78384fc37c47cb2a Diff: http://git.reviewboard.kde.org/r/110187/diff/ Testing --- Only on windows Thanks, Patrick von Reth ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
RE: C++11
Date: Fri, 10 May 2013 01:14:52 +0200 Subject: Re: C++11 From: kretschm...@kde.org To: amarok-devel@kde.org On Fri, May 10, 2013 at 12:39 AM, Matěj Laitl ma...@laitl.cz wrote: On 8. 5. 2013 Patrick von Reth wrote: For the official builds we are still using gcc 4.4.7 and we probably won't switch to 4.8 before we switch to qt5. But for a amarok only build, I already did some testing and got a working build with gcc 4.8. For msvc, we are currently using msvc10, and won't switch to msvc12(which has c++11 support) before we switch to qt5. Cheers So I think this is the answer: C++11 only as soon Windows guys will support it. It's not really clear to me what Patrick meant to say. Is our build the official one? If not, how is this official build relevant to us?With the official builds I meant the one we are releasing as KDE Windows.But for the amarok installer I could use a different compiler.Also the need of c++ x11 could motivate us to move to the new compiler a bit earlier.And as it would only be amarok for the beginning that would require c++11 there would be no harm done to the guis providing Kontact, Calligra etc. My initial interpretation was: Amarok is built with GCC, and I've already tested it with GCC 4.8. It worked, so we can probably use C++11. Another (and IMO important) benefit of C++11 is make-coding-fun one. Trying new things is fun and C++11 is sexy, perhaps Markey would enjoy coding on Amarok much more if he could use C++11. That's a good point. Also, gaining practical experience is useful in other places. With some Lambda usage, it becomes a good deal more readable and pleasant to work with, and less error prone. This is how it could look instead: From 7cca04eb25169e5befb3e5d6a1290795c3e651b8 Mon Sep 17 00:00:00 2001 From: Mark Kretschmann kretschm...@kde.org Date: Thu, 9 May 2013 19:08:24 +0200 Subject: [PATCH] Replace redundant code with one Lambda function. This change doesn't really need a lambda support at all, just deduplicate the code into a helper function, it is only slightly less elegant. Please do it. Sure you could use a plain helper function here. But I find that in such cases, where a helper is only called from one function, it makes the code even less readable. The beauty of the lambda is that it can remove redundancy, while at the same time keeping relevant code together. -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Review Request 110187: Don't communicate with mysql by env vars and autogenerated files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/ --- Review request for Amarok. Description --- Don't communicate with mysql by env vars and autogenerated files Instead of generating the my.cnf every time amarok starts and to pass the location of this file by setting an environment variable directly pass the settings as arguments to mysql. As this is probably a better approach and the only one working on windows. This fixes an issue where amarok is writing the database to C:\Program Files (x86)\Amarok\data\amarok. This issue prevents Amarok from running correctly, because regarding to the rights of the useraccount the directory can be not writeable. The commands used are taken from the output of mysqld --verbose --help. Diffs - src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp 0233498fdeb18ab51e709e9a78384fc37c47cb2a Diff: http://git.reviewboard.kde.org/r/110187/diff/ Testing --- Only on windows Thanks, Patrick von Reth ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files
On April 25, 2013, 3:43 p.m., Edward Hades Toroshchin wrote: Thanks for the fix. However, this is the approach, we've used originally, and it didn't prove very reliable. I think we even went back and forth more than once. So you should really have a look in the history of the mysql collection, to see if and how this is different from the way it's been done before (and why it isn't done that way anymore). This fixes an issue where amarok is writing the database to C:\Program Files (x86)\Amarok\data\amarok. This issue prevents Amarok from running correctly, because regarding to the rights of the useraccount the directory can be not writeable. It's not only that, it could also lead to problems if several users tried to use Amarok simultaneously. I suggest you check, where does this path come from. Why is storageLocation empty? Storage location is not empty but either mysql isn't using MYSQL_HOME or unable to read the file. Why should it be a problem if several user are running amarok, what would be the difference to the my.cnf approach. - Patrick --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/#review31576 --- On April 25, 2013, 2:36 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/ --- (Updated April 25, 2013, 2:36 p.m.) Review request for Amarok. Description --- Don't communicate with mysql by env vars and autogenerated files Instead of generating the my.cnf every time amarok starts and to pass the location of this file by setting an environment variable directly pass the settings as arguments to mysql. As this is probably a better approach and the only one working on windows. This fixes an issue where amarok is writing the database to C:\Program Files (x86)\Amarok\data\amarok. This issue prevents Amarok from running correctly, because regarding to the rights of the useraccount the directory can be not writeable. The commands used are taken from the output of mysqld --verbose --help. Diffs - src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp 0233498fdeb18ab51e709e9a78384fc37c47cb2a Diff: http://git.reviewboard.kde.org/r/110187/diff/ Testing --- Only on windows Thanks, Patrick von Reth ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re:
Hi we could really need your help. Currently I'm looking for some artwork for the windows installer. So I don't want to repeat my self so I just past you the link to the forum post where I ask for some artwork. I'm no artist so I have no idea how it could look like but it would be great to see some of your ideas. Cheers Patrick On 27 April 2012 07:04, segun ogunwale seg...@cedarviewng.com wrote: I will like to know if you are still interested in the design of the icons and the artwork. Thank you. ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt
On Windows we have to package every dependency including 3party lib our salve. And AFAIK we already build/package QJson :) On 8 February 2011 17:50, Stefan Derkits ste...@derkits.at wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100607/ On February 8th, 2011, 2:36 a.m., *Andy Coder* wrote: This seems reasonable enough to me. Especially since JsonQt was used because it was already hanging around in the source tree, and availability of friendly JSON libraries in package repos wasn't what it is today. However, if the PlaydarCollection didn't start up automatically and you had Playdar running on your system, then something's broken. On February 8th, 2011, 10:40 a.m., *Stefan Derkits* wrote: No Playdar was not running on my System but I believe I didn't introduce Bugs. Could you try it please? On February 8th, 2011, 4:42 p.m., *Andy Coder* wrote: I'll try again when I get time, but I couldn't apply your patch, (no idea why, I'm probably doing it wrong). In the meantime, why don't we go ahead and make Qjson an optional dependency, and build the PlaydarCollection conditionally. That way, we don't add another real dependency. Realistically, Playdar's current status means that, while useful and fun for those who make use of it, the PlaydarCollection isn't likely to see enough use to require all users to install Qjson and build it. And for the record, the way to activate the PlaydarCollection is simply to have a Playdar service running on your machine, (whether or not Amarok's already started). Making PlaydarCollection optional (depending on QJSon) sounds good to me ... can do it quickly tonight or after Thursday when I have time again. On the Playdarsite I didn't find how to install it on Linux, is there no Linux Version? Haven't tried this Patch under Windows ... probably there it makes Problems cause not many People have QJson installed ;) - Stefan On February 8th, 2011, 12:17 a.m., Stefan Derkits wrote: Review request for Amarok. By Stefan Derkits. *Updated Feb. 8, 2011, 12:17 a.m.* Description What I did: -) added cmake/modules/FindQJson.cmake -) deleted external/JsonQt adapted external/CmakeLists.txt -) use QJson in collections/playdarcollection/support/ Why: QJson is available via Package on pretty much every System now Why QJson instead JsonQt? libmygpo-qt uses it, libechonest uses it and both Libraries will (sooner or later) be used in Amarok Testing compiled run Amarok; didn't specifically try out Playdarcollection, didn't know how to activate it Diffs - CMakeLists.txt (11d4c9d5a296560f1c779e1dee4405c9827dac91) - README (d8c142968c2da3888a703cc2b2e38d854f5c868b) - cmake/modules/FindQJSON.cmake (PRE-CREATION) - external/CMakeLists.txt (0e161c701e0d1a9d7b769a1dda742df9e8f303ae) - external/JsonQt/CMakeLists.txt (9978895bb72fa4993a4326397fa7284c74fd00ee) - external/JsonQt/COMPATIBILITY (1a5b6195ca32395657535bd426a91a8a8ee5c22f) - external/JsonQt/COPYING.HEADER (bf9c30eb90c5aa3c04a87a010736bb1c64326885) - external/JsonQt/Doxyfile.cmake (4d2a4bf7035976f1cd06dcd43a55cb8ab660e47d) - external/JsonQt/README.txt (4ebcf735ccbff8556914ed687b27f065dfb4a229) - external/JsonQt/add-copyright-header.sh (8d21c92fbfa305e0f24d57e9a921235f624aecba) - external/JsonQt/lib/CMakeLists.txt (3d394572d1af6b062ff6fb10881e462b5b4f7f9e) - external/JsonQt/lib/JsonQtExport.h (30d5a7569710d4c31d9deffe3798566008fe89bc) - external/JsonQt/lib/JsonRpc.h (8f0024c03c0c89c021f271421821e57b3d4b9367) - external/JsonQt/lib/JsonRpc.cpp (cbcd16156ac44a55b7c34aae3d2b47b2b776f856) - external/JsonQt/lib/JsonRpcAdaptor.h (83836c810358b7b5db44d151c6840027ec85586a) - external/JsonQt/lib/JsonRpcAdaptor.cpp (18a1504435040a1cb8e6a785ae8093ade7d232ef) - external/JsonQt/lib/JsonRpcAdaptorPrivate.h (03c990ce187ff90ccb591052f25de547e5651982) - external/JsonQt/lib/JsonRpcAdaptorPrivate.cpp (c8fddb012b45c6117e5ac74b7d36cfa6c02048b1) - external/JsonQt/lib/JsonToProperties.h (f04bd586e5d1aae9727d8bc4e218171954d86ec5) - external/JsonQt/lib/JsonToProperties.cpp (4859d49b643bcd2e9cfb54c0c64581c94654b3f4) - external/JsonQt/lib/JsonToVariant.h (82b62c0446b03df25aabcbd508fd24e290a9ac98) - external/JsonQt/lib/JsonToVariant.cpp (323e31adfe0558d9b4dd671b7a9409cb9bb202fa) - external/JsonQt/lib/ParseException.h (2f6566099bc13ab84eba28054330bcb0812e9785) - external/JsonQt/lib/ParseException.cpp (c663179388f193175febe0eaaca6a2ce8241c215) - external/JsonQt/lib/VariantToJson.h (2a1a645e4743af267ce21b55d7c164ea2805940b) - external/JsonQt/lib/VariantToJson.cpp (baa7cddb548f10e6ea25e1b194683de7863055fc) - external/JsonQt/tests/CMakeLists.txt (4954fe78d726afc534b541cd97c79551f40f742a) - external/JsonQt/tests/JsonRpc.cpp
