Re: Review Request 111038: Fixes the scrolling problem in dynamic playlists i.e. Bug 284214

2013-07-02 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111038/
---

(Updated July 2, 2013, 10:15 a.m.)


Status
--

This change has been marked as submitted.


Review request for Amarok.


Description
---

After the track was changed the scroll to current playing track worked as per 
user settings. But in case of dynamic playlists after the tracks were added 
(automatically) the PrettyListView scrolled to the tracks added (i.e. it 
scrolled to the bottom). It took me so long to figure this out and even longer 
to find a solution; but the patch was only of 2 lines. Anyway I got a better 
understanding of the Playlist Model-View architecture :)


This addresses bug 284214.
https://bugs.kde.org/show_bug.cgi?id=284214


Diffs
-

  src/playlist/view/listview/PrettyListView.cpp 8723875 

Diff: http://git.reviewboard.kde.org/r/111038/diff/


Testing
---

Builds successfully and runs as expected


Thanks,

Vedant Agarwala

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Re: Review Request 111038: Fixes the scrolling problem in dynamic playlists i.e. Bug 284214

2013-07-02 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111038/#review35429
---


This review has been submitted with commit 
9dbdb8bde9836f2e17da9ef063cea66961324639 by Mark Kretschmann on behalf of 
Vedant Agarwala to branch master.

- Commit Hook


On June 15, 2013, 11:22 a.m., Vedant Agarwala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/111038/
 ---
 
 (Updated June 15, 2013, 11:22 a.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 After the track was changed the scroll to current playing track worked as 
 per user settings. But in case of dynamic playlists after the tracks were 
 added (automatically) the PrettyListView scrolled to the tracks added (i.e. 
 it scrolled to the bottom). It took me so long to figure this out and even 
 longer to find a solution; but the patch was only of 2 lines. Anyway I got a 
 better understanding of the Playlist Model-View architecture :)
 
 
 This addresses bug 284214.
 https://bugs.kde.org/show_bug.cgi?id=284214
 
 
 Diffs
 -
 
   src/playlist/view/listview/PrettyListView.cpp 8723875 
 
 Diff: http://git.reviewboard.kde.org/r/111038/diff/
 
 
 Testing
 ---
 
 Builds successfully and runs as expected
 
 
 Thanks,
 
 Vedant Agarwala
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel