Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128246/ --- (Updated Aug. 7, 2016, 10:17 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Changes --- Submitted with commit bdbb3a27f556c41910d3b814e5a4c73a2a93362f by Mat?j Laitl on behalf of Stefano Pettini to branch master. Bugs: 314854 https://bugs.kde.org/show_bug.cgi?id=314854 Repository: amarok Description --- This makes the lyrics browser similar to every other context applet. Please note that, when editing lyrics, the default textbox background is still used. Diffs - ChangeLog 23599f1 src/context/applets/lyrics/LyricsBrowser.cpp abcfe64 Diff: https://git.reviewboard.kde.org/r/128246/diff/ Testing --- Tested ONLY in the following environment: KDE Version: 4.14.16 Qt Version: 4.8.7 Tested with light and dark color scheme Tested use case of changing KDE color scheme while Amarok is running Tested the edit lyrics mode Thanks, Stefano Pettini
Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet
> On July 11, 2016, 4:27 p.m., Matěj Laitl wrote: > > Ship It! Can you commit it? Sandro doesn't have commit rights AFAIK - Myriam --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128246/#review97291 --- On July 10, 2016, 11:13 p.m., Stefano Pettini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128246/ > --- > > (Updated July 10, 2016, 11:13 p.m.) > > > Review request for Amarok. > > > Bugs: 314854 > https://bugs.kde.org/show_bug.cgi?id=314854 > > > Repository: amarok > > > Description > --- > > This makes the lyrics browser similar to every other context applet. > Please note that, when editing lyrics, the default textbox background > is still used. > > > Diffs > - > > ChangeLog 23599f1 > src/context/applets/lyrics/LyricsBrowser.cpp abcfe64 > > Diff: https://git.reviewboard.kde.org/r/128246/diff/ > > > Testing > --- > > Tested ONLY in the following environment: > KDE Version: 4.14.16 > Qt Version: 4.8.7 > > Tested with light and dark color scheme > Tested use case of changing KDE color scheme while Amarok is running > Tested the edit lyrics mode > > > Thanks, > > Stefano Pettini > >
Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128246/#review97291 --- Ship it! Ship It! - Matěj Laitl On Čec. 10, 2016, 11:13 odp., Stefano Pettini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128246/ > --- > > (Updated Čec. 10, 2016, 11:13 odp.) > > > Review request for Amarok. > > > Bugs: 314854 > https://bugs.kde.org/show_bug.cgi?id=314854 > > > Repository: amarok > > > Description > --- > > This makes the lyrics browser similar to every other context applet. > Please note that, when editing lyrics, the default textbox background > is still used. > > > Diffs > - > > ChangeLog 23599f1 > src/context/applets/lyrics/LyricsBrowser.cpp abcfe64 > > Diff: https://git.reviewboard.kde.org/r/128246/diff/ > > > Testing > --- > > Tested ONLY in the following environment: > KDE Version: 4.14.16 > Qt Version: 4.8.7 > > Tested with light and dark color scheme > Tested use case of changing KDE color scheme while Amarok is running > Tested the edit lyrics mode > > > Thanks, > > Stefano Pettini > >
Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128246/ --- (Updated July 10, 2016, 11:13 p.m.) Review request for Amarok. Changes --- Rebased and updated ChangeLog Bugs: 314854 https://bugs.kde.org/show_bug.cgi?id=314854 Repository: amarok Description --- This makes the lyrics browser similar to every other context applet. Please note that, when editing lyrics, the default textbox background is still used. Diffs (updated) - ChangeLog 23599f1 src/context/applets/lyrics/LyricsBrowser.cpp abcfe64 Diff: https://git.reviewboard.kde.org/r/128246/diff/ Testing --- Tested ONLY in the following environment: KDE Version: 4.14.16 Qt Version: 4.8.7 Tested with light and dark color scheme Tested use case of changing KDE color scheme while Amarok is running Tested the edit lyrics mode Thanks, Stefano Pettini
Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128246/#review96718 --- Ship it! Although I'm not context view expert, this loks good to me, let's merge this and let wider user base test it. - Matěj Laitl On Čer. 19, 2016, 3:01 dop., Stefano Pettini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128246/ > --- > > (Updated Čer. 19, 2016, 3:01 dop.) > > > Review request for Amarok. > > > Bugs: 314854 > https://bugs.kde.org/show_bug.cgi?id=314854 > > > Repository: amarok > > > Description > --- > > This makes the lyrics browser similar to every other context applet. > Please note that, when editing lyrics, the default textbox background > is still used. > > > Diffs > - > > src/context/applets/lyrics/LyricsBrowser.cpp abcfe64 > > Diff: https://git.reviewboard.kde.org/r/128246/diff/ > > > Testing > --- > > Tested ONLY in the following environment: > KDE Version: 4.14.16 > Qt Version: 4.8.7 > > Tested with light and dark color scheme > Tested use case of changing KDE color scheme while Amarok is running > Tested the edit lyrics mode > > > Thanks, > > Stefano Pettini > >
