Re: [Nouveau] [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-09-07 Thread Ilia Mirkin
On Wed, Aug 21, 2019 at 7:55 AM Thierry Reding  wrote:
>
> On Wed, Aug 21, 2019 at 04:33:58PM +1000, Ben Skeggs wrote:
> > On Wed, 14 Aug 2019 at 20:14, Gerd Hoffmann  wrote:
> > >
> > >   Hi,
> > >
> > > > > Changing the order doesn't look hard.  Patch attached (untested, have 
> > > > > no
> > > > > test hardware).  But maybe I missed some detail ...
> > > >
> > > > I came up with something very similar by splitting up nouveau_bo_new()
> > > > into allocation and initialization steps, so that when necessary the GEM
> > > > object can be initialized in between. I think that's slightly more
> > > > flexible and easier to understand than a boolean flag.
> > >
> > > Yes, that should work too.
> > >
> > > Acked-by: Gerd Hoffmann 
> > Acked-by: Ben Skeggs 
>
> Thanks guys, applied to drm-misc-next.

Hi Thierry,

Initial investigations suggest that this commit currently in drm-next

commit 019cbd4a4feb3aa3a917d78e7110e3011bbff6d5
Author: Thierry Reding 
Date:   Wed Aug 14 11:00:48 2019 +0200

drm/nouveau: Initialize GEM object before TTM object

breaks nouveau userspace which tries to allocate GEM objects with a
non-page-aligned size. Previously nouveau_gem_new would just call
nouveau_bo_init which would call nouveau_bo_fixup_align before
initializing the GEM object. With this change, it is done after. What
do you think -- OK to just move that bit of logic into the new
nouveau_bo_alloc() (and make size/align be pointers so that they can
be fixed up?)

Cheers,

  -ilia
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm: add drm device name

2019-09-07 Thread Daniel Vetter
On Sat, Sep 7, 2019 at 3:18 AM Rob Clark  wrote:
>
> On Fri, Sep 6, 2019 at 3:16 PM Marek Olšák  wrote:
> >
> > + dri-devel
> >
> > On Tue, Sep 3, 2019 at 5:41 PM Jiang, Sonny  wrote:
> >>
> >> Add DRM device name and use DRM_IOCTL_VERSION ioctl drmVersion::desc 
> >> passing it to user space
> >> instead of unused DRM driver name descriptor.
> >>
> >> Change-Id: I809f6d3e057111417efbe8fa7cab8f0113ba4b21
> >> Signed-off-by: Sonny Jiang 
> >> ---
> >>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |  2 ++
> >>  drivers/gpu/drm/drm_drv.c  | 17 +
> >>  drivers/gpu/drm/drm_ioctl.c|  2 +-
> >>  include/drm/drm_device.h   |  3 +++
> >>  include/drm/drm_drv.h  |  1 +
> >>  5 files changed, 24 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> >> index 67b09cb2a9e2..8f0971cea363 100644
> >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> >> @@ -2809,6 +2809,8 @@ int amdgpu_device_init(struct amdgpu_device *adev,
> >> /* init the mode config */
> >> drm_mode_config_init(adev->ddev);
> >>
> >> +   drm_dev_set_name(adev->ddev, amdgpu_asic_name[adev->asic_type]);
> >> +
> >> r = amdgpu_device_ip_init(adev);
> >> if (r) {
> >> /* failed in exclusive mode due to timeout */
> >> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> >> index 862621494a93..6c33879bb538 100644
> >> --- a/drivers/gpu/drm/drm_drv.c
> >> +++ b/drivers/gpu/drm/drm_drv.c
> >> @@ -802,6 +802,7 @@ void drm_dev_fini(struct drm_device *dev)
> >> mutex_destroy(>struct_mutex);
> >> drm_legacy_destroy_members(dev);
> >> kfree(dev->unique);
> >> +   kfree(dev->name);
> >>  }
> >>  EXPORT_SYMBOL(drm_dev_fini);
> >>
> >> @@ -1078,6 +1079,22 @@ int drm_dev_set_unique(struct drm_device *dev, 
> >> const char *name)
> >>  }
> >>  EXPORT_SYMBOL(drm_dev_set_unique);
> >>
> >> +/**
> >> + * drm_dev_set_name - Set the name of a DRM device
> >> + * @dev: device of which to set the name
> >> + * @name: name to be set
> >> + *
> >> + * Return: 0 on success or a negative error code on failure.
> >> + */
> >> +int drm_dev_set_name(struct drm_device *dev, const char *name)
> >> +{
> >> +   kfree(dev->name);
> >> +   dev->name = kstrdup(name, GFP_KERNEL);
> >> +
> >> +   return dev->name ? 0 : -ENOMEM;
> >> +}
> >> +EXPORT_SYMBOL(drm_dev_set_name);
> >> +
> >>  /*
> >>   * DRM Core
> >>   * The DRM core module initializes all global DRM objects and makes them
> >> diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
> >> index 2263e3ddd822..61f02965106b 100644
> >> --- a/drivers/gpu/drm/drm_ioctl.c
> >> +++ b/drivers/gpu/drm/drm_ioctl.c
> >> @@ -506,7 +506,7 @@ int drm_version(struct drm_device *dev, void *data,
> >> dev->driver->date);
> >> if (!err)
> >> err = drm_copy_field(version->desc, >desc_len,
> >> -   dev->driver->desc);
> >> +   dev->name);
>
> I suspect this needs to be something like dev->name ? dev->name :
> dev->driver->desc
>
> Or somewhere something needs to arrange for dev->name to default to
> dev->driver->desc
>
> And maybe this should be dev->desc instead of dev->name.. that at
> least seems less confusing to me.
>
> other than that, I don't see a big problem

(recap from irc)

I thought we're using this as essentially an uapi identifier, so that
you know which kind of ioctl set a driver supports. Not so big deal on
pci, where we match against pci ids anyway, kinda bigger deal where
that's not around. Listing codenames and or something else that
changes all the time feels a bit silly for that. Imo if you just want
to expose this to userspace, stuff it into an amdgpu info/query ioctl.

So what do you need this for exactly, where's the userspace that needs this?
-Daniel

>
> BR,
> -R
>
> >>
> >> return err;
> >>  }
> >> diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h
> >> index 7f9ef709b2b6..e29912c484e4 100644
> >> --- a/include/drm/drm_device.h
> >> +++ b/include/drm/drm_device.h
> >> @@ -123,6 +123,9 @@ struct drm_device {
> >> /** @unique: Unique name of the device */
> >> char *unique;
> >>
> >> +   /** @name: device name */
> >> +   char *name;
> >> +
> >> /**
> >>  * @struct_mutex:
> >>  *
> >> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> >> index 68ca736c548d..f742e2bde467 100644
> >> --- a/include/drm/drm_drv.h
> >> +++ b/include/drm/drm_drv.h
> >> @@ -798,6 +798,7 @@ static inline bool drm_drv_uses_atomic_modeset(struct 
> >> drm_device *dev)
> >>
> >>
> >>  int drm_dev_set_unique(struct drm_device *dev, const char *name);
> >> +int drm_dev_set_name(struct drm_device *dev, const char 

Re: [PATCH] drm/amdgpu: Allow to reset to EERPOM table.

2019-09-07 Thread Grodzovsky, Andrey
What about adding new value to existing ras_ctl debugfs file ?

Andrey


From: Alex Deucher 
Sent: 07 September 2019 09:42:47
To: Grodzovsky, Andrey
Cc: amd-gfx list; Zhou1, Tao; Chen, Guchun
Subject: Re: [PATCH] drm/amdgpu: Allow to reset to EERPOM table.

On Fri, Sep 6, 2019 at 11:13 AM Andrey Grodzovsky
 wrote:
>
> The table grows quickly during debug/development effort when
> multiple RAS errors are injected. Allow to avoid this by setting
> table header back to empty if needed.
>

Please make this a debugfs file rather than a module parameter so that
it an be updated at runtime and more easily handled on a per card
basis.

Alex

> Signed-off-by: Andrey Grodzovsky 
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 8 
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 3 ++-
>  3 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 0d11aa8..405c55a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -169,6 +169,7 @@ extern int amdgpu_discovery;
>  extern int amdgpu_mes;
>  extern int amdgpu_noretry;
>  extern int amdgpu_force_asic_type;
> +extern int amdgpu_ras_eeprom_reset;
>
>  #ifdef CONFIG_DRM_AMDGPU_SI
>  extern int amdgpu_si_support;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 5a7f929..6e101a5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -145,6 +145,7 @@ int amdgpu_discovery = -1;
>  int amdgpu_mes = 0;
>  int amdgpu_noretry = 1;
>  int amdgpu_force_asic_type = -1;
> +int amdgpu_ras_eeprom_reset = -1;
>
>  struct amdgpu_mgpu_info mgpu_info = {
> .mutex = __MUTEX_INITIALIZER(mgpu_info.mutex),
> @@ -530,6 +531,13 @@ MODULE_PARM_DESC(ras_mask, "Mask of RAS features to 
> enable (default 0x),
>  module_param_named(ras_mask, amdgpu_ras_mask, uint, 0444);
>
>  /**
> + * DOC: ras_eeprom_reset (int)
> + * Reset EEPROM table to zerro entries.
> + */
> +MODULE_PARM_DESC(ras_eeprom_reset, "Reset RAS EEPROM table to zerro entries 
> (1 = reset, -1 = auto (default - don't reset)");
> +module_param_named(ras_eeprom_reset, amdgpu_ras_eeprom_reset, int, 0444);
> +
> +/**
>   * DOC: si_support (int)
>   * Set SI support driver. This parameter works after set config 
> CONFIG_DRM_AMDGPU_SI. For SI asic, when radeon driver is enabled,
>   * set value 0 to use radeon driver, while set value 1 to use amdgpu driver. 
> The default is using radeon driver when it available,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> index 43dd4ab..75c6fc0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> @@ -140,7 +140,8 @@ int amdgpu_ras_eeprom_init(struct 
> amdgpu_ras_eeprom_control *control)
>
> __decode_table_header_from_buff(hdr, [2]);
>
> -   if (hdr->header == EEPROM_TABLE_HDR_VAL) {
> +   if (amdgpu_ras_eeprom_reset != 1 &&
> +   hdr->header == EEPROM_TABLE_HDR_VAL) {
> control->num_recs = (hdr->tbl_size - 
> EEPROM_TABLE_HEADER_SIZE) /
> EEPROM_TABLE_RECORD_SIZE;
> DRM_DEBUG_DRIVER("Found existing EEPROM table with %d 
> records",
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-07 Thread Joe Perches
On Wed, 2019-09-04 at 08:08 -0400, Sasha Levin wrote:
> it's better to get
> it right rather than to be done quickly :)

That also applies to the initial selection of
patches for the stable trees.




Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-07 Thread Alex Deucher
On Tue, Sep 3, 2019 at 4:16 PM Daniel Vetter  wrote:
>
> On Tue, Sep 3, 2019 at 10:01 PM Sasha Levin  wrote:
> >
> > On Tue, Sep 03, 2019 at 07:03:47PM +0200, Greg KH wrote:
> > >On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote:
> > >> On 2019-09-03 6:23 p.m., Sasha Levin wrote:
> > >> > From: Yu Zhao 
> > >> >
> > >> > [ Upstream commit 89f23b6efef554766177bf51aa754bce14c3e7da ]
> > >>
> > >> Hold your horses!
> > >>
> > >> This commit and c4a32b266da7bb702e60381ca0c35eaddbc89a6c had to be
> > >> reverted, as they caused regressions. See commits
> > >> 25ec429e86bb790e40387a550f0501d0ac55a47c &
> > >> 92b0730eaf2d549fdfb10ecc8b71f34b9f472c12 .
> > >>
> > >>
> > >> This isn't bolstering confidence in how these patches are selected...
> > >
> > >The patch _itself_ said to be backported to the stable trees from 4.2
> > >and newer.  Why wouldn't we be confident in doing this?
> > >
> > >If the patch doesn't want to be backported, then do not add the cc:
> > >stable line to it...
> >
> > This patch was picked because it has a stable tag, which you presumably
> > saw as your Reviewed-by tag is in the patch. This is why it was
> > backported; it doesn't take AI to backport patches tagged for stable...
> >
> > The revert of this patch, however:
> >
> >  1. Didn't have a stable tag.
> >  2. Didn't have a "Fixes:" tag.
> >  3. Didn't have the usual "the reverts commit ..." string added by git
> >  when one does a revert.
> >
> > Which is why we still kick patches for review, even though they had a
> > stable tag, just so people could take a look and confirm we're not
> > missing anything - like we did here.
> >
> > I'm not sure what you expected me to do differently here.
>
> Yeah this looks like fail on the revert side, they need to reference
> the reverted commit somehow ...
>
> Alex, why got this dropped? Is this more fallout from the back
> shuffling you're doing between your internal branches behind the
> firewall, and the public history?

The behind the firewall comments are not really helpful.  There aren't
any "behind the firewall" trees.  Everything is mirrored in public.
Yes it is annoying that we don't have a direct committer tree, but the
only shuffling is between public trees.  The problem is 90% of our
customers want packaged out of tree drivers rather than in tree
drivers because they are using an old distro or a custom distro or
something else so we have to do this dance.  I realize there are other
dances we could do to solve this problem, but they all have their own
set of costs and this is what we have now.  The patch shuffling
doesn't help, but regardless, the same thing could happen even with a
direct committer tree if someone missed the tag when committing.

Alex

>
> Also adding Dave Airlie.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH] drm/amdgpu: Allow to reset to EERPOM table.

2019-09-07 Thread Alex Deucher
On Fri, Sep 6, 2019 at 11:13 AM Andrey Grodzovsky
 wrote:
>
> The table grows quickly during debug/development effort when
> multiple RAS errors are injected. Allow to avoid this by setting
> table header back to empty if needed.
>

Please make this a debugfs file rather than a module parameter so that
it an be updated at runtime and more easily handled on a per card
basis.

Alex

> Signed-off-by: Andrey Grodzovsky 
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 8 
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 3 ++-
>  3 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 0d11aa8..405c55a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -169,6 +169,7 @@ extern int amdgpu_discovery;
>  extern int amdgpu_mes;
>  extern int amdgpu_noretry;
>  extern int amdgpu_force_asic_type;
> +extern int amdgpu_ras_eeprom_reset;
>
>  #ifdef CONFIG_DRM_AMDGPU_SI
>  extern int amdgpu_si_support;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 5a7f929..6e101a5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -145,6 +145,7 @@ int amdgpu_discovery = -1;
>  int amdgpu_mes = 0;
>  int amdgpu_noretry = 1;
>  int amdgpu_force_asic_type = -1;
> +int amdgpu_ras_eeprom_reset = -1;
>
>  struct amdgpu_mgpu_info mgpu_info = {
> .mutex = __MUTEX_INITIALIZER(mgpu_info.mutex),
> @@ -530,6 +531,13 @@ MODULE_PARM_DESC(ras_mask, "Mask of RAS features to 
> enable (default 0x),
>  module_param_named(ras_mask, amdgpu_ras_mask, uint, 0444);
>
>  /**
> + * DOC: ras_eeprom_reset (int)
> + * Reset EEPROM table to zerro entries.
> + */
> +MODULE_PARM_DESC(ras_eeprom_reset, "Reset RAS EEPROM table to zerro entries 
> (1 = reset, -1 = auto (default - don't reset)");
> +module_param_named(ras_eeprom_reset, amdgpu_ras_eeprom_reset, int, 0444);
> +
> +/**
>   * DOC: si_support (int)
>   * Set SI support driver. This parameter works after set config 
> CONFIG_DRM_AMDGPU_SI. For SI asic, when radeon driver is enabled,
>   * set value 0 to use radeon driver, while set value 1 to use amdgpu driver. 
> The default is using radeon driver when it available,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> index 43dd4ab..75c6fc0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> @@ -140,7 +140,8 @@ int amdgpu_ras_eeprom_init(struct 
> amdgpu_ras_eeprom_control *control)
>
> __decode_table_header_from_buff(hdr, [2]);
>
> -   if (hdr->header == EEPROM_TABLE_HDR_VAL) {
> +   if (amdgpu_ras_eeprom_reset != 1 &&
> +   hdr->header == EEPROM_TABLE_HDR_VAL) {
> control->num_recs = (hdr->tbl_size - 
> EEPROM_TABLE_HEADER_SIZE) /
> EEPROM_TABLE_RECORD_SIZE;
> DRM_DEBUG_DRIVER("Found existing EEPROM table with %d 
> records",
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: Allow to reset to EERPOM table.

2019-09-07 Thread Nils Wallménius
Hi Andrey, spotted a typo below, also typo in the title s/EERPOM/EEPROM/

Regards
Nils

Den fre 6 sep. 2019 17:13Andrey Grodzovsky 
skrev:

> The table grows quickly during debug/development effort when
> multiple RAS errors are injected. Allow to avoid this by setting
> table header back to empty if needed.
>
> Signed-off-by: Andrey Grodzovsky 
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 8 
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 3 ++-
>  3 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 0d11aa8..405c55a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -169,6 +169,7 @@ extern int amdgpu_discovery;
>  extern int amdgpu_mes;
>  extern int amdgpu_noretry;
>  extern int amdgpu_force_asic_type;
> +extern int amdgpu_ras_eeprom_reset;
>
>  #ifdef CONFIG_DRM_AMDGPU_SI
>  extern int amdgpu_si_support;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 5a7f929..6e101a5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -145,6 +145,7 @@ int amdgpu_discovery = -1;
>  int amdgpu_mes = 0;
>  int amdgpu_noretry = 1;
>  int amdgpu_force_asic_type = -1;
> +int amdgpu_ras_eeprom_reset = -1;
>
>  struct amdgpu_mgpu_info mgpu_info = {
> .mutex = __MUTEX_INITIALIZER(mgpu_info.mutex),
> @@ -530,6 +531,13 @@ MODULE_PARM_DESC(ras_mask, "Mask of RAS features to
> enable (default 0x),
>  module_param_named(ras_mask, amdgpu_ras_mask, uint, 0444);
>
>  /**
> + * DOC: ras_eeprom_reset (int)
> + * Reset EEPROM table to zerro entries.
> + */
> +MODULE_PARM_DESC(ras_eeprom_reset, "Reset RAS EEPROM table to zerro
> entries (1 = reset, -1 = auto (default - don't reset)");
>

s/zerro/zero/ in two places

+module_param_named(ras_eeprom_reset, amdgpu_ras_eeprom_reset, int, 0444);
> +
> +/**
>   * DOC: si_support (int)
>   * Set SI support driver. This parameter works after set config
> CONFIG_DRM_AMDGPU_SI. For SI asic, when radeon driver is enabled,
>   * set value 0 to use radeon driver, while set value 1 to use amdgpu
> driver. The default is using radeon driver when it available,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> index 43dd4ab..75c6fc0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> @@ -140,7 +140,8 @@ int amdgpu_ras_eeprom_init(struct
> amdgpu_ras_eeprom_control *control)
>
> __decode_table_header_from_buff(hdr, [2]);
>
> -   if (hdr->header == EEPROM_TABLE_HDR_VAL) {
> +   if (amdgpu_ras_eeprom_reset != 1 &&
> +   hdr->header == EEPROM_TABLE_HDR_VAL) {
> control->num_recs = (hdr->tbl_size -
> EEPROM_TABLE_HEADER_SIZE) /
> EEPROM_TABLE_RECORD_SIZE;
> DRM_DEBUG_DRIVER("Found existing EEPROM table with %d
> records",
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx