Re: [PATCH] drm/amd/display: Don't use mpreferred-stack-boundary for clang on DCN201

[Alex Deucher]

On Thu, Sep 30, 2021 at 10:02 AM Harry Wentland  wrote:
>
> We were erroneously setting IS_OLD_GCC for clang since we didn't
> check first whether we're doing a GCC build.
>
> See dcn30/Makefile for reference.
>
> Fixes: 4ac93fa0ec12 ("drm/amd/display: add cyan_skillfish display support")
> Signed-off-by: Harry Wentland 

Reviewed-by: Alex Deucher 

> ---
>  drivers/gpu/drm/amd/display/dc/dcn201/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/Makefile 
> b/drivers/gpu/drm/amd/display/dc/dcn201/Makefile
> index d98d69705117..f68038ceb1b1 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn201/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dcn201/Makefile
> @@ -14,9 +14,12 @@ ifdef CONFIG_PPC64
>  CFLAGS_$(AMDDALPATH)/dc/dcn201/dcn201_resource.o := -mhard-float -maltivec
>  endif
>
> +ifdef CONFIG_CC_IS_GCC
>  ifeq ($(call cc-ifversion, -lt, 0701, y), y)
>  IS_OLD_GCC = 1
>  endif
> +CFLAGS_$(AMDDALPATH)/dc/dcn201/dcn201_resource.o += -mhard-float
> +endif
>
>  ifdef CONFIG_X86
>  ifdef IS_OLD_GCC
> --
> 2.33.0
>

[PATCH] drm/amd/display: Don't use mpreferred-stack-boundary for clang on DCN201

[Harry Wentland]

We were erroneously setting IS_OLD_GCC for clang since we didn't
check first whether we're doing a GCC build.

See dcn30/Makefile for reference.

Fixes: 4ac93fa0ec12 ("drm/amd/display: add cyan_skillfish display support")
Signed-off-by: Harry Wentland 
---
 drivers/gpu/drm/amd/display/dc/dcn201/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/Makefile 
b/drivers/gpu/drm/amd/display/dc/dcn201/Makefile
index d98d69705117..f68038ceb1b1 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn201/Makefile
+++ b/drivers/gpu/drm/amd/display/dc/dcn201/Makefile
@@ -14,9 +14,12 @@ ifdef CONFIG_PPC64
 CFLAGS_$(AMDDALPATH)/dc/dcn201/dcn201_resource.o := -mhard-float -maltivec
 endif
 
+ifdef CONFIG_CC_IS_GCC
 ifeq ($(call cc-ifversion, -lt, 0701, y), y)
 IS_OLD_GCC = 1
 endif
+CFLAGS_$(AMDDALPATH)/dc/dcn201/dcn201_resource.o += -mhard-float
+endif
 
 ifdef CONFIG_X86
 ifdef IS_OLD_GCC
-- 
2.33.0