Re: [PATCH] drm/amd/display: Fix null pointer when setting backlight

[Alex Deucher]

On Wed, Mar 14, 2018 at 9:55 AM, Harry Wentland  wrote:
> Fixes: c894d9f208f9 (drm/amd/display: Fixed dim around 1sec when resume
> from S3)
>
> Signed-off-by: Harry Wentland 

Acked-by: Alex Deucher 

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link.c | 8 +---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c 
> b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index e6d5dcb35e96..eeb04471b2f5 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1960,10 +1960,12 @@ bool dc_link_set_backlight_level(const struct dc_link 
> *link, uint32_t level,
> (abm->funcs->set_backlight_level == NULL))
> return false;
>
> -   if (stream->bl_pwm_level == 0)
> -   frame_ramp = 0;
> +   if (stream) {
> +   if (stream->bl_pwm_level == 0)
> +   frame_ramp = 0;
>
> -   ((struct dc_stream_state *)stream)->bl_pwm_level = level;
> +   ((struct dc_stream_state *)stream)->bl_pwm_level = level;
> +   }
>
> use_smooth_brightness = dmcu->funcs->is_dmcu_initialized(dmcu);
>
> --
> 2.14.1
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/display: Fix null pointer when setting backlight

[Harry Wentland]

Fixes: c894d9f208f9 (drm/amd/display: Fixed dim around 1sec when resume
from S3)

Signed-off-by: Harry Wentland 
---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c 
b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index e6d5dcb35e96..eeb04471b2f5 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -1960,10 +1960,12 @@ bool dc_link_set_backlight_level(const struct dc_link 
*link, uint32_t level,
(abm->funcs->set_backlight_level == NULL))
return false;
 
-   if (stream->bl_pwm_level == 0)
-   frame_ramp = 0;
+   if (stream) {
+   if (stream->bl_pwm_level == 0)
+   frame_ramp = 0;
 
-   ((struct dc_stream_state *)stream)->bl_pwm_level = level;
+   ((struct dc_stream_state *)stream)->bl_pwm_level = level;
+   }
 
use_smooth_brightness = dmcu->funcs->is_dmcu_initialized(dmcu);
 
-- 
2.14.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx