Re: [PATCH] drm/amd/display: Unlock on error path in dm_handle_mst_sideband_msg_ready_event()

[Alex Deucher]

On Fri, Jul 21, 2023 at 10:57 AM Dan Carpenter  wrote:
>
> This error path needs to unlock the "aconnector->handle_mst_msg_ready"
> mutex before returning.
>
> Fixes: bb4fa525f327 ("drm/amd/display: Add polling method to handle MST reply 
> packet")
> Signed-off-by: Dan Carpenter 

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c 
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 1abdec14344e..943959012d04 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -707,7 +707,7 @@ void dm_handle_mst_sideband_msg_ready_event(
>
> if (retry == 3) {
> DRM_ERROR("Failed to ack MST event.\n");
> -   return;
> +   break;
> }
>
> 
> drm_dp_mst_hpd_irq_send_new_request(>mst_mgr);
> --
> 2.39.2
>

[PATCH] drm/amd/display: Unlock on error path in dm_handle_mst_sideband_msg_ready_event()

[Dan Carpenter]

This error path needs to unlock the "aconnector->handle_mst_msg_ready"
mutex before returning.

Fixes: bb4fa525f327 ("drm/amd/display: Add polling method to handle MST reply 
packet")
Signed-off-by: Dan Carpenter 
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
index 1abdec14344e..943959012d04 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -707,7 +707,7 @@ void dm_handle_mst_sideband_msg_ready_event(
 
if (retry == 3) {
DRM_ERROR("Failed to ack MST event.\n");
-   return;
+   break;
}
 

drm_dp_mst_hpd_irq_send_new_request(>mst_mgr);
-- 
2.39.2