RE: [PATCH] drm/amd/pm: remove unused message SMU_MSG_SpareX

2021-01-17 Thread Lazar, Lijo 
[AMD Public Use]

Reviewed-by: Lijo Lazar 

Thanks,
Lijo

-Original Message-
From: amd-gfx  On Behalf Of Kevin Wang
Sent: Saturday, January 16, 2021 5:28 PM
To: amd-gfx@lists.freedesktop.org
Cc: Wang, Kevin(Yang) 
Subject: [PATCH] drm/amd/pm: remove unused message SMU_MSG_SpareX

the SpareX is reserved by SMU firmwared, the driver never use it.

Signed-off-by: Kevin Wang 
---
 drivers/gpu/drm/amd/pm/inc/smu_types.h   | 2 --
 drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 --  
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c  | 2 --
 3 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/inc/smu_types.h 
b/drivers/gpu/drm/amd/pm/inc/smu_types.h
index b76270e8767c..68c87d4b1ce3 100644
--- a/drivers/gpu/drm/amd/pm/inc/smu_types.h
+++ b/drivers/gpu/drm/amd/pm/inc/smu_types.h
@@ -133,8 +133,6 @@
__SMU_DUMMY_MAP(PowerUpSdma), \
__SMU_DUMMY_MAP(SetHardMinIspclkByFreq),  \
__SMU_DUMMY_MAP(SetHardMinVcn),   \
-   __SMU_DUMMY_MAP(Spare1),  \
-   __SMU_DUMMY_MAP(Spare2),  \
__SMU_DUMMY_MAP(SetAllowFclkSwitch),  \
__SMU_DUMMY_MAP(SetMinVideoGfxclkFreq),   \
__SMU_DUMMY_MAP(ActiveProcessNotify), \
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 2f0cb0ea243b..3d639c530e2f 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -81,7 +81,6 @@ static struct cmn2asic_msg_mapping 
vangogh_message_map[SMU_MSG_MAX_COUNT] = {
MSG_MAP(TransferTableDram2Smu,  
PPSMC_MSG_TransferTableDram2Smu,0),
MSG_MAP(GfxDeviceDriverReset,   PPSMC_MSG_GfxDeviceDriverReset, 
0),
MSG_MAP(GetEnabledSmuFeatures,  
PPSMC_MSG_GetEnabledSmuFeatures,0),
-   MSG_MAP(Spare1, PPSMC_MSG_spare1,   
0),
MSG_MAP(SetHardMinSocclkByFreq, 
PPSMC_MSG_SetHardMinSocclkByFreq,   0),
MSG_MAP(SetSoftMinFclk, PPSMC_MSG_SetSoftMinFclk,   
0),
MSG_MAP(SetSoftMinVcn,  PPSMC_MSG_SetSoftMinVcn,
0),
@@ -93,7 +92,6 @@ static struct cmn2asic_msg_mapping 
vangogh_message_map[SMU_MSG_MAX_COUNT] = {
MSG_MAP(SetSoftMaxSocclkByFreq, 
PPSMC_MSG_SetSoftMaxSocclkByFreq,   0),
MSG_MAP(SetSoftMaxFclkByFreq,   PPSMC_MSG_SetSoftMaxFclkByFreq, 
0),
MSG_MAP(SetSoftMaxVcn,  PPSMC_MSG_SetSoftMaxVcn,
0),
-   MSG_MAP(Spare2, PPSMC_MSG_spare2,   
0),
MSG_MAP(SetPowerLimitPercentage,
PPSMC_MSG_SetPowerLimitPercentage,  0),
MSG_MAP(PowerDownJpeg,  PPSMC_MSG_PowerDownJpeg,
0),
MSG_MAP(PowerUpJpeg,PPSMC_MSG_PowerUpJpeg,  
0),
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
index 6c8a8ccd2f84..dfe4eeeb4596 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
@@ -56,8 +56,6 @@ static struct cmn2asic_msg_mapping 
renoir_message_map[SMU_MSG_MAX_COUNT] = {
MSG_MAP(PowerUpSdma,PPSMC_MSG_PowerUpSdma,  
1),
MSG_MAP(SetHardMinIspclkByFreq, 
PPSMC_MSG_SetHardMinIspclkByFreq,   1),
MSG_MAP(SetHardMinVcn,  PPSMC_MSG_SetHardMinVcn,
1),
-   MSG_MAP(Spare1, PPSMC_MSG_spare1,   
1),
-   MSG_MAP(Spare2, PPSMC_MSG_spare2,   
1),
MSG_MAP(SetAllowFclkSwitch, PPSMC_MSG_SetAllowFclkSwitch,   
1),
MSG_MAP(SetMinVideoGfxclkFreq,  
PPSMC_MSG_SetMinVideoGfxclkFreq,1),
MSG_MAP(ActiveProcessNotify,PPSMC_MSG_ActiveProcessNotify,  
1),
--
2.17.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfxdata=04%7C01%7Clijo.lazar%40amd.com%7C78a1c9e606604a9679c708d8ba16149a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637463951300629403%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=lhh60VQFfpQm6EN%2F91Xj2LEOBJqWnGK4Vob%2BybEDhWk%3Dreserved=0
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amd/pm: remove unused message SMU_MSG_SpareX

2021-01-17 Thread Quan, Evan 
[AMD Official Use Only - Internal Distribution Only]

Acked-by: Evan Quan 

-Original Message-
From: amd-gfx  On Behalf Of Kevin Wang
Sent: Saturday, January 16, 2021 7:58 PM
To: amd-gfx@lists.freedesktop.org
Cc: Wang, Kevin(Yang) 
Subject: [PATCH] drm/amd/pm: remove unused message SMU_MSG_SpareX

the SpareX is reserved by SMU firmwared,
the driver never use it.

Signed-off-by: Kevin Wang 
---
 drivers/gpu/drm/amd/pm/inc/smu_types.h   | 2 --
 drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 --
 drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c  | 2 --
 3 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/inc/smu_types.h 
b/drivers/gpu/drm/amd/pm/inc/smu_types.h
index b76270e8767c..68c87d4b1ce3 100644
--- a/drivers/gpu/drm/amd/pm/inc/smu_types.h
+++ b/drivers/gpu/drm/amd/pm/inc/smu_types.h
@@ -133,8 +133,6 @@
 __SMU_DUMMY_MAP(PowerUpSdma), \
 __SMU_DUMMY_MAP(SetHardMinIspclkByFreq),  \
 __SMU_DUMMY_MAP(SetHardMinVcn),   \
-__SMU_DUMMY_MAP(Spare1),  \
-__SMU_DUMMY_MAP(Spare2), \
 __SMU_DUMMY_MAP(SetAllowFclkSwitch),  \
 __SMU_DUMMY_MAP(SetMinVideoGfxclkFreq),   \
 __SMU_DUMMY_MAP(ActiveProcessNotify), \
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 2f0cb0ea243b..3d639c530e2f 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -81,7 +81,6 @@ static struct cmn2asic_msg_mapping 
vangogh_message_map[SMU_MSG_MAX_COUNT] = {
 MSG_MAP(TransferTableDram2Smu,  PPSMC_MSG_TransferTableDram2Smu,0),
 MSG_MAP(GfxDeviceDriverReset,   PPSMC_MSG_GfxDeviceDriverReset,0),
 MSG_MAP(GetEnabledSmuFeatures,  PPSMC_MSG_GetEnabledSmuFeatures,0),
-MSG_MAP(Spare1, PPSMC_MSG_spare1,0),
 MSG_MAP(SetHardMinSocclkByFreq, PPSMC_MSG_SetHardMinSocclkByFreq,0),
 MSG_MAP(SetSoftMinFclk, PPSMC_MSG_SetSoftMinFclk,0),
 MSG_MAP(SetSoftMinVcn,  PPSMC_MSG_SetSoftMinVcn,0),
@@ -93,7 +92,6 @@ static struct cmn2asic_msg_mapping 
vangogh_message_map[SMU_MSG_MAX_COUNT] = {
 MSG_MAP(SetSoftMaxSocclkByFreq, PPSMC_MSG_SetSoftMaxSocclkByFreq,0),
 MSG_MAP(SetSoftMaxFclkByFreq,   PPSMC_MSG_SetSoftMaxFclkByFreq,0),
 MSG_MAP(SetSoftMaxVcn,  PPSMC_MSG_SetSoftMaxVcn,0),
-MSG_MAP(Spare2, PPSMC_MSG_spare2,0),
 MSG_MAP(SetPowerLimitPercentage,PPSMC_MSG_SetPowerLimitPercentage,0),
 MSG_MAP(PowerDownJpeg,  PPSMC_MSG_PowerDownJpeg,0),
 MSG_MAP(PowerUpJpeg,PPSMC_MSG_PowerUpJpeg,0),
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
index 6c8a8ccd2f84..dfe4eeeb4596 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
@@ -56,8 +56,6 @@ static struct cmn2asic_msg_mapping 
renoir_message_map[SMU_MSG_MAX_COUNT] = {
 MSG_MAP(PowerUpSdma,PPSMC_MSG_PowerUpSdma, 
 1),
 MSG_MAP(SetHardMinIspclkByFreq, PPSMC_MSG_SetHardMinIspclkByFreq,  
 1),
 MSG_MAP(SetHardMinVcn,  PPSMC_MSG_SetHardMinVcn,   
 1),
-MSG_MAP(Spare1, PPSMC_MSG_spare1,  
 1),
-MSG_MAP(Spare2, PPSMC_MSG_spare2,  
 1),
 MSG_MAP(SetAllowFclkSwitch, PPSMC_MSG_SetAllowFclkSwitch,  
 1),
 MSG_MAP(SetMinVideoGfxclkFreq,  PPSMC_MSG_SetMinVideoGfxclkFreq,   
 1),
 MSG_MAP(ActiveProcessNotify,PPSMC_MSG_ActiveProcessNotify, 
 1),
--
2.17.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfxdata=04%7C01%7Cevan.quan%40amd.com%7C78a1c9e606604a9679c708d8ba16149a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637463951301273401%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=xlNMR%2B5DMYPbXyuWas6G0avj3am1Pvb8o3RtQA2302U%3Dreserved=0
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/pm: remove unused message SMU_MSG_SpareX

2021-01-16 Thread Kevin Wang 
the SpareX is reserved by SMU firmwared,
the driver never use it.

Signed-off-by: Kevin Wang 
---
 drivers/gpu/drm/amd/pm/inc/smu_types.h   | 2 --
 drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 --
 drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c  | 2 --
 3 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/inc/smu_types.h 
b/drivers/gpu/drm/amd/pm/inc/smu_types.h
index b76270e8767c..68c87d4b1ce3 100644
--- a/drivers/gpu/drm/amd/pm/inc/smu_types.h
+++ b/drivers/gpu/drm/amd/pm/inc/smu_types.h
@@ -133,8 +133,6 @@
__SMU_DUMMY_MAP(PowerUpSdma), \
__SMU_DUMMY_MAP(SetHardMinIspclkByFreq),  \
__SMU_DUMMY_MAP(SetHardMinVcn),   \
-   __SMU_DUMMY_MAP(Spare1),  \
-   __SMU_DUMMY_MAP(Spare2),  \
__SMU_DUMMY_MAP(SetAllowFclkSwitch),  \
__SMU_DUMMY_MAP(SetMinVideoGfxclkFreq),   \
__SMU_DUMMY_MAP(ActiveProcessNotify), \
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 2f0cb0ea243b..3d639c530e2f 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -81,7 +81,6 @@ static struct cmn2asic_msg_mapping 
vangogh_message_map[SMU_MSG_MAX_COUNT] = {
MSG_MAP(TransferTableDram2Smu,  
PPSMC_MSG_TransferTableDram2Smu,0),
MSG_MAP(GfxDeviceDriverReset,   PPSMC_MSG_GfxDeviceDriverReset, 
0),
MSG_MAP(GetEnabledSmuFeatures,  
PPSMC_MSG_GetEnabledSmuFeatures,0),
-   MSG_MAP(Spare1, PPSMC_MSG_spare1,   
0),
MSG_MAP(SetHardMinSocclkByFreq, 
PPSMC_MSG_SetHardMinSocclkByFreq,   0),
MSG_MAP(SetSoftMinFclk, PPSMC_MSG_SetSoftMinFclk,   
0),
MSG_MAP(SetSoftMinVcn,  PPSMC_MSG_SetSoftMinVcn,
0),
@@ -93,7 +92,6 @@ static struct cmn2asic_msg_mapping 
vangogh_message_map[SMU_MSG_MAX_COUNT] = {
MSG_MAP(SetSoftMaxSocclkByFreq, 
PPSMC_MSG_SetSoftMaxSocclkByFreq,   0),
MSG_MAP(SetSoftMaxFclkByFreq,   PPSMC_MSG_SetSoftMaxFclkByFreq, 
0),
MSG_MAP(SetSoftMaxVcn,  PPSMC_MSG_SetSoftMaxVcn,
0),
-   MSG_MAP(Spare2, PPSMC_MSG_spare2,   
0),
MSG_MAP(SetPowerLimitPercentage,
PPSMC_MSG_SetPowerLimitPercentage,  0),
MSG_MAP(PowerDownJpeg,  PPSMC_MSG_PowerDownJpeg,
0),
MSG_MAP(PowerUpJpeg,PPSMC_MSG_PowerUpJpeg,  
0),
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
index 6c8a8ccd2f84..dfe4eeeb4596 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
@@ -56,8 +56,6 @@ static struct cmn2asic_msg_mapping 
renoir_message_map[SMU_MSG_MAX_COUNT] = {
MSG_MAP(PowerUpSdma,PPSMC_MSG_PowerUpSdma,  
1),
MSG_MAP(SetHardMinIspclkByFreq, 
PPSMC_MSG_SetHardMinIspclkByFreq,   1),
MSG_MAP(SetHardMinVcn,  PPSMC_MSG_SetHardMinVcn,
1),
-   MSG_MAP(Spare1, PPSMC_MSG_spare1,   
1),
-   MSG_MAP(Spare2, PPSMC_MSG_spare2,   
1),
MSG_MAP(SetAllowFclkSwitch, PPSMC_MSG_SetAllowFclkSwitch,   
1),
MSG_MAP(SetMinVideoGfxclkFreq,  
PPSMC_MSG_SetMinVideoGfxclkFreq,1),
MSG_MAP(ActiveProcessNotify,PPSMC_MSG_ActiveProcessNotify,  
1),
-- 
2.17.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx