RE: [PATCH] drm/amd/powerplay: fix the coverity warning about negative check for an unsigned value

2020-03-09 Thread Quan, Evan
Reviewed-by: Evan Quan 

-Original Message-
From: Liang, Prike  
Sent: Tuesday, March 10, 2020 8:36 AM
To: amd-gfx@lists.freedesktop.org; Quan, Evan ; Deucher, 
Alexander 
Cc: Liang, Prike 
Subject: [PATCH] drm/amd/powerplay: fix the coverity warning about negative 
check for an unsigned value

There will be a coverity warning because min and max are both unsigned.

Signed-off-by: Prike Liang 
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index d454493..f18e3fa 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -214,9 +214,6 @@ int smu_set_soft_freq_range(struct smu_context *smu, enum 
smu_clk_type clk_type,  {
int ret = 0;
 
-   if (min < 0 && max < 0)
-   return -EINVAL;
-
if (!smu_clk_dpm_is_enabled(smu, clk_type))
return 0;
 
--
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH] drm/amd/powerplay: fix the coverity warning about negative check for an unsigned value

2020-03-09 Thread Prike Liang
There will be a coverity warning because min and max are both unsigned.

Signed-off-by: Prike Liang 
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index d454493..f18e3fa 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -214,9 +214,6 @@ int smu_set_soft_freq_range(struct smu_context *smu, enum 
smu_clk_type clk_type,
 {
int ret = 0;
 
-   if (min < 0 && max < 0)
-   return -EINVAL;
-
if (!smu_clk_dpm_is_enabled(smu, clk_type))
return 0;
 
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx