Re: [PATCH] drm/amd/powerplay: report bootup clock as max supported on dpm disabled

2019-07-17 Thread Deucher, Alexander
Reviewed-by: Alex Deucher 

From: amd-gfx  on behalf of Evan Quan 

Sent: Wednesday, July 17, 2019 5:34 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander; Xu, Feifei; Quan, Evan; Ma, Le
Subject: [PATCH] drm/amd/powerplay: report bootup clock as max supported on dpm 
disabled

With gfxclk or uclk dpm disabled, it's reasonable to report bootup clock
as the max supported.

Change-Id: If8aa7a912e8a34414b0e9c2b46de9b6e316fd9d7
Signed-off-by: Evan Quan 
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 27 ++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index 5d5664f..d370b09 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -137,12 +137,37 @@ int smu_get_dpm_freq_range(struct smu_context *smu, enum 
smu_clk_type clk_type,
 {
 int ret = 0, clk_id = 0;
 uint32_t param = 0;
+   uint32_t clock_limit;

 if (!min && !max)
 return -EINVAL;

-   if (!smu_clk_dpm_is_enabled(smu, clk_type))
+   if (!smu_clk_dpm_is_enabled(smu, clk_type)) {
+   switch (clk_type) {
+   case SMU_MCLK:
+   case SMU_UCLK:
+   clock_limit = smu->smu_table.boot_values.uclk;
+   break;
+   case SMU_GFXCLK:
+   case SMU_SCLK:
+   clock_limit = smu->smu_table.boot_values.gfxclk;
+   break;
+   case SMU_SOCCLK:
+   clock_limit = smu->smu_table.boot_values.socclk;
+   break;
+   default:
+   clock_limit = 0;
+   break;
+   }
+
+   /* clock in Mhz unit */
+   if (min)
+   *min = clock_limit / 100;
+   if (max)
+   *max = clock_limit / 100;
+
 return 0;
+   }

 mutex_lock(>mutex);
 clk_id = smu_clk_get_index(smu, clk_type);
--
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/powerplay: report bootup clock as max supported on dpm disabled

2019-07-17 Thread Evan Quan
With gfxclk or uclk dpm disabled, it's reasonable to report bootup clock
as the max supported.

Change-Id: If8aa7a912e8a34414b0e9c2b46de9b6e316fd9d7
Signed-off-by: Evan Quan 
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 27 ++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index 5d5664f..d370b09 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -137,12 +137,37 @@ int smu_get_dpm_freq_range(struct smu_context *smu, enum 
smu_clk_type clk_type,
 {
int ret = 0, clk_id = 0;
uint32_t param = 0;
+   uint32_t clock_limit;
 
if (!min && !max)
return -EINVAL;
 
-   if (!smu_clk_dpm_is_enabled(smu, clk_type))
+   if (!smu_clk_dpm_is_enabled(smu, clk_type)) {
+   switch (clk_type) {
+   case SMU_MCLK:
+   case SMU_UCLK:
+   clock_limit = smu->smu_table.boot_values.uclk;
+   break;
+   case SMU_GFXCLK:
+   case SMU_SCLK:
+   clock_limit = smu->smu_table.boot_values.gfxclk;
+   break;
+   case SMU_SOCCLK:
+   clock_limit = smu->smu_table.boot_values.socclk;
+   break;
+   default:
+   clock_limit = 0;
+   break;
+   }
+
+   /* clock in Mhz unit */
+   if (min)
+   *min = clock_limit / 100;
+   if (max)
+   *max = clock_limit / 100;
+
return 0;
+   }
 
mutex_lock(>mutex);
clk_id = smu_clk_get_index(smu, clk_type);
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx