RE: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding
> -Original Message-
> From: amd-gfx On Behalf Of Zhu,
> James
> Sent: Tuesday, October 22, 2019 10:49 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhu, James
> Subject: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding
>
> After VCN2.5 firmware (Version ENC: 1.1 Revision: 11),
> VCN2.5 encoding can work properly.
>
> Signed-off-by: James Zhu
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> index d270df8..ff6cc77 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
> @@ -265,9 +265,6 @@ static int vcn_v2_5_hw_init(void *handle)
>
> for (i = 0; i < adev->vcn.num_enc_rings; ++i) {
> ring = >vcn.inst[j].ring_enc[i];
> - /* disable encode rings till the robustness of the FW
> */
> - ring->sched.ready = false;
> - continue;
> r = amdgpu_ring_test_helper(ring);
> if (r)
> goto done;
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding
Hi Christian,
I checked that Arcturus firmware haven't been published yet.
Best Regards!
James Zhu
On 2019-10-22 8:52 a.m., Christian König wrote:
> Have we ever published an older version of the firmware?
>
> I strongly assume the answer is "no" and if that's the case feel free
> to add an Reviewed-by: Christian König .
>
> Regards,
> Christian.
>
> Am 22.10.19 um 16:50 schrieb Liu, Leo:
>> Reviewed-by: Leo Liu
>>
>> -Original Message-
>> From: amd-gfx On Behalf Of
>> Zhu, James
>> Sent: Tuesday, October 22, 2019 10:49 AM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Zhu, James
>> Subject: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding
>>
>> After VCN2.5 firmware (Version ENC: 1.1 Revision: 11),
>> VCN2.5 encoding can work properly.
>>
>> Signed-off-by: James Zhu
>> ---
>> drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
>> b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
>> index d270df8..ff6cc77 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
>> @@ -265,9 +265,6 @@ static int vcn_v2_5_hw_init(void *handle)
>> for (i = 0; i < adev->vcn.num_enc_rings; ++i) {
>> ring = >vcn.inst[j].ring_enc[i];
>> - /* disable encode rings till the robustness of the FW */
>> - ring->sched.ready = false;
>> - continue;
>> r = amdgpu_ring_test_helper(ring);
>> if (r)
>> goto done;
>
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding
Have we ever published an older version of the firmware?
I strongly assume the answer is "no" and if that's the case feel free to
add an Reviewed-by: Christian König .
Regards,
Christian.
Am 22.10.19 um 16:50 schrieb Liu, Leo:
Reviewed-by: Leo Liu
-Original Message-
From: amd-gfx On Behalf Of Zhu, James
Sent: Tuesday, October 22, 2019 10:49 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, James
Subject: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding
After VCN2.5 firmware (Version ENC: 1.1 Revision: 11),
VCN2.5 encoding can work properly.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
index d270df8..ff6cc77 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
@@ -265,9 +265,6 @@ static int vcn_v2_5_hw_init(void *handle)
for (i = 0; i < adev->vcn.num_enc_rings; ++i) {
ring = >vcn.inst[j].ring_enc[i];
- /* disable encode rings till the robustness of the FW */
- ring->sched.ready = false;
- continue;
r = amdgpu_ring_test_helper(ring);
if (r)
goto done;
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding
Reviewed-by: Leo Liu
-Original Message-
From: amd-gfx On Behalf Of Zhu, James
Sent: Tuesday, October 22, 2019 10:49 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, James
Subject: [PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding
After VCN2.5 firmware (Version ENC: 1.1 Revision: 11),
VCN2.5 encoding can work properly.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
index d270df8..ff6cc77 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
@@ -265,9 +265,6 @@ static int vcn_v2_5_hw_init(void *handle)
for (i = 0; i < adev->vcn.num_enc_rings; ++i) {
ring = >vcn.inst[j].ring_enc[i];
- /* disable encode rings till the robustness of the FW */
- ring->sched.ready = false;
- continue;
r = amdgpu_ring_test_helper(ring);
if (r)
goto done;
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amdgpu/vcn: Enable VCN2.5 encoding
After VCN2.5 firmware (Version ENC: 1.1 Revision: 11),
VCN2.5 encoding can work properly.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
index d270df8..ff6cc77 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
@@ -265,9 +265,6 @@ static int vcn_v2_5_hw_init(void *handle)
for (i = 0; i < adev->vcn.num_enc_rings; ++i) {
ring = >vcn.inst[j].ring_enc[i];
- /* disable encode rings till the robustness of the FW */
- ring->sched.ready = false;
- continue;
r = amdgpu_ring_test_helper(ring);
if (r)
goto done;
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
