RE: [PATCH] drm/amdgpu: Correct register used to clear fault status

2024-06-28 Thread Zhou1, Tao 
[AMD Official Use Only - AMD Internal Distribution Only]

Reviewed-by: Tao Zhou 

> -Original Message-
> From: Hawking Zhang 
> Sent: Friday, June 28, 2024 5:04 PM
> To: amd-gfx@lists.freedesktop.org; Zhou1, Tao 
> Cc: Zhang, Hawking 
> Subject: [PATCH] drm/amdgpu: Correct register used to clear fault status
>
> Driver should write to fault_cntl registers to do one-shot address/status 
> clear.
>
> Signed-off-by: Hawking Zhang 
> ---
>  drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
> b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
> index 8d7267a013d2..621761a17ac7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
> @@ -569,7 +569,7 @@ static bool
> mmhub_v1_8_query_utcl2_poison_status(struct amdgpu_device *adev,
>   if (!amdgpu_sriov_vf(adev)) {
>   /* clear page fault status and address */
>   WREG32_P(SOC15_REG_OFFSET(MMHUB, hub_inst,
> -  regVM_L2_PROTECTION_FAULT_STATUS), 1, ~1);
> +  regVM_L2_PROTECTION_FAULT_CNTL), 1, ~1);
>   }
>
>   return fed;
> --
> 2.17.1

[PATCH] drm/amdgpu: Correct register used to clear fault status

2024-06-28 Thread Hawking Zhang 
Driver should write to fault_cntl registers to do
one-shot address/status clear.

Signed-off-by: Hawking Zhang 
---
 drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c 
b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
index 8d7267a013d2..621761a17ac7 100644
--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
@@ -569,7 +569,7 @@ static bool mmhub_v1_8_query_utcl2_poison_status(struct 
amdgpu_device *adev,
if (!amdgpu_sriov_vf(adev)) {
/* clear page fault status and address */
WREG32_P(SOC15_REG_OFFSET(MMHUB, hub_inst,
-regVM_L2_PROTECTION_FAULT_STATUS), 1, ~1);
+regVM_L2_PROTECTION_FAULT_CNTL), 1, ~1);
}
 
return fed;
-- 
2.17.1