[PATCH] drm/amdgpu: Fix memory leak in amdgpu_fence_emit
In the impelementation of amdgpu_fence_emit() if dma_fence_wait() fails and returns an errno, before returning the allocated memory for fence should be released. Fixes: 3d2aca8c8620 ("drm/amdgpu: fix old fence check in amdgpu_fence_emit") Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c index 23085b352cf2..2f59c9270a7e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c @@ -166,8 +166,10 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct dma_fence **f, if (old) { r = dma_fence_wait(old, false); dma_fence_put(old); - if (r) + if (r) { + dma_fence_put(fence); return r; + } } } -- 2.17.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_fence_emit
Am 21.10.19 um 20:09 schrieb Navid Emamdoost: > In the impelementation of amdgpu_fence_emit() if dma_fence_wait() fails > and returns an errno, before returning the allocated memory for fence > should be released. > > Fixes: 3d2aca8c8620 ("drm/amdgpu: fix old fence check in amdgpu_fence_emit") > Signed-off-by: Navid Emamdoost Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > index 23085b352cf2..2f59c9270a7e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > @@ -166,8 +166,10 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct > dma_fence **f, > if (old) { > r = dma_fence_wait(old, false); > dma_fence_put(old); > - if (r) > + if (r) { > + dma_fence_put(fence); > return r; > + } > } > } > ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx