Re: [PATCH] drm/amdgpu: Use correct enum to set powergating state

2018-06-19 Thread Alex Deucher
On Tue, Jun 19, 2018 at 5:16 AM, Stefan Agner  wrote:
> Use enum amd_powergating_state instead of enum amd_clockgating_state.
> The underlying value stays the same, so there is no functional change
> in practise. This fixes a warning seen with clang:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1930:14: warning: implicit
>   conversion from enumeration type 'enum amd_clockgating_state' to
>   different enumeration type 'enum amd_powergating_state'
>   [-Wenum-conversion]
>AMD_CG_STATE_UNGATE);
>^~~
>
> Signed-off-by: Stefan Agner 

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fe76ec1f9737..2a1d19c31922 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1927,7 +1927,7 @@ int amdgpu_device_ip_suspend(struct amdgpu_device *adev)
> if (adev->powerplay.pp_feature & PP_GFXOFF_MASK)
> amdgpu_device_ip_set_powergating_state(adev,
>AMD_IP_BLOCK_TYPE_SMC,
> -  AMD_CG_STATE_UNGATE);
> +  AMD_PG_STATE_UNGATE);
>
> /* ungate SMC block first */
> r = amdgpu_device_ip_set_clockgating_state(adev, 
> AMD_IP_BLOCK_TYPE_SMC,
> --
> 2.17.1
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH] drm/amdgpu: Use correct enum to set powergating state

2018-06-19 Thread Stefan Agner
Use enum amd_powergating_state instead of enum amd_clockgating_state.
The underlying value stays the same, so there is no functional change
in practise. This fixes a warning seen with clang:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1930:14: warning: implicit
  conversion from enumeration type 'enum amd_clockgating_state' to
  different enumeration type 'enum amd_powergating_state'
  [-Wenum-conversion]
   AMD_CG_STATE_UNGATE);
   ^~~

Signed-off-by: Stefan Agner 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index fe76ec1f9737..2a1d19c31922 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1927,7 +1927,7 @@ int amdgpu_device_ip_suspend(struct amdgpu_device *adev)
if (adev->powerplay.pp_feature & PP_GFXOFF_MASK)
amdgpu_device_ip_set_powergating_state(adev,
   AMD_IP_BLOCK_TYPE_SMC,
-  AMD_CG_STATE_UNGATE);
+  AMD_PG_STATE_UNGATE);
 
/* ungate SMC block first */
r = amdgpu_device_ip_set_clockgating_state(adev, AMD_IP_BLOCK_TYPE_SMC,
-- 
2.17.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx