Re: [PATCH] drm/amdgpu: clean up unused variable about ring lru

2020-04-20 Thread Wang, Kevin(Yang) 
[AMD Official Use Only - Internal Distribution Only]




From: Christian König 
Sent: Monday, April 20, 2020 11:45 PM
To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org 

Cc: Deucher, Alexander ; Koenig, Christian 

Subject: Re: [PATCH] drm/amdgpu: clean up unused variable about ring lru

Am 20.04.20 um 17:27 schrieb Kevin Wang:
> clean up unused variable:
> 1. ring_lru_list
> 2. ring_lru_list_lock
>
> related-commit:
> drm/amdgpu: remove ring lru handling
>
> Signed-off-by: Kevin Wang 

Reviewed-by: Christian König 

Found by accident or used some tool? I'm asking because I'm pretty sure
we have more like those.

Thanks,
Christian.

[kevin]:
I found it when I read the driver source code, and then I looked at the git 
history.
no tools to help.

Best Regards,
Kevin


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
>   2 files changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 94dff899248d..e8ab3dde6a66 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -953,9 +953,6 @@ struct amdgpu_device {
>/* link all shadow bo */
>struct list_headshadow_list;
>struct mutexshadow_list_lock;
> - /* keep an lru list of rings by HW IP */
> - struct list_headring_lru_list;
> - spinlock_t  ring_lru_list_lock;
>
>/* record hw reset is performed */
>bool has_hw_reset;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 71ea56e220ae..38eb736091d0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2990,9 +2990,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
>INIT_LIST_HEAD(>shadow_list);
>mutex_init(>shadow_list_lock);
>
> - INIT_LIST_HEAD(>ring_lru_list);
> - spin_lock_init(>ring_lru_list_lock);
> -
>INIT_DELAYED_WORK(>delayed_init_work,
>  amdgpu_device_delayed_init_work_handler);
>INIT_DELAYED_WORK(>gfx.gfx_off_delay_work,

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: clean up unused variable about ring lru

2020-04-20 Thread Christian König 

Am 20.04.20 um 17:27 schrieb Kevin Wang:

clean up unused variable:
1. ring_lru_list
2. ring_lru_list_lock

related-commit:
drm/amdgpu: remove ring lru handling

Signed-off-by: Kevin Wang 


Reviewed-by: Christian König 

Found by accident or used some tool? I'm asking because I'm pretty sure 
we have more like those.


Thanks,
Christian.


---
  drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ---
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
  2 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 94dff899248d..e8ab3dde6a66 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -953,9 +953,6 @@ struct amdgpu_device {
/* link all shadow bo */
struct list_headshadow_list;
struct mutexshadow_list_lock;
-   /* keep an lru list of rings by HW IP */
-   struct list_headring_lru_list;
-   spinlock_t  ring_lru_list_lock;
  
  	/* record hw reset is performed */

bool has_hw_reset;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 71ea56e220ae..38eb736091d0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2990,9 +2990,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
INIT_LIST_HEAD(>shadow_list);
mutex_init(>shadow_list_lock);
  
-	INIT_LIST_HEAD(>ring_lru_list);

-   spin_lock_init(>ring_lru_list_lock);
-
INIT_DELAYED_WORK(>delayed_init_work,
  amdgpu_device_delayed_init_work_handler);
INIT_DELAYED_WORK(>gfx.gfx_off_delay_work,


___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu: clean up unused variable about ring lru

2020-04-20 Thread Kevin Wang 
clean up unused variable:
1. ring_lru_list
2. ring_lru_list_lock

related-commit:
drm/amdgpu: remove ring lru handling

Signed-off-by: Kevin Wang 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 94dff899248d..e8ab3dde6a66 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -953,9 +953,6 @@ struct amdgpu_device {
/* link all shadow bo */
struct list_headshadow_list;
struct mutexshadow_list_lock;
-   /* keep an lru list of rings by HW IP */
-   struct list_headring_lru_list;
-   spinlock_t  ring_lru_list_lock;
 
/* record hw reset is performed */
bool has_hw_reset;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 71ea56e220ae..38eb736091d0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2990,9 +2990,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
INIT_LIST_HEAD(>shadow_list);
mutex_init(>shadow_list_lock);
 
-   INIT_LIST_HEAD(>ring_lru_list);
-   spin_lock_init(>ring_lru_list_lock);
-
INIT_DELAYED_WORK(>delayed_init_work,
  amdgpu_device_delayed_init_work_handler);
INIT_DELAYED_WORK(>gfx.gfx_off_delay_work,
-- 
2.26.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx