RE: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
[AMD Official Use Only] > -Original Message- > From: Alex Deucher > Sent: Friday, August 13, 2021 9:56 PM > To: Quan, Evan > Cc: amd-gfx list ; Deucher, Alexander > ; Chen, Guchun > Subject: Re: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 > polaris12 SKU temporarily > > On Fri, Aug 13, 2021 at 9:54 AM Alex Deucher > wrote: > > > > Acked-by: Alex Deucher > > > > On Fri, Aug 13, 2021 at 4:09 AM Evan Quan wrote: > > > > > > We have a S3 issue on that SKU with BACO enabled. Will bring back > > > this when that root caused. > > > > > Actually it might be worth checking the SSIDs as well assuming this is > platform > specific. [Quan, Evan] Can you share more how to perform that check? Where to get the SSID? BR Evan > > Alex > > > > Change-Id: I56d4830e6275e20a415808896eecbadfe944070b > > > Signed-off-by: Evan Quan > > > --- > > > drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c > > > b/drivers/gpu/drm/amd/amdgpu/vi.c index fe9a7cc8d9eb..7210f80815b8 > > > 100644 > > > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > > > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > > > @@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct > amdgpu_device *adev) > > > case CHIP_POLARIS11: > > > case CHIP_POLARIS12: > > > case CHIP_TOPAZ: > > > - return amdgpu_dpm_is_baco_supported(adev); > > > + /* Disable BACO support for the specific polaris12 SKU > temporarily */ > > > + if ((adev->pdev->device == 0x699F) && > > > + (adev->pdev->revision == 0xC7)) > > > + return false; > > > + else > > > + return amdgpu_dpm_is_baco_supported(adev); > > > default: > > > return false; > > > } > > > -- > > > 2.29.0 > > >
RE: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
[Public] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Quan, Evan Sent: Friday, August 13, 2021 4:10 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Chen, Guchun ; Quan, Evan Subject: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily We have a S3 issue on that SKU with BACO enabled. Will bring back this when that root caused. Change-Id: I56d4830e6275e20a415808896eecbadfe944070b Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index fe9a7cc8d9eb..7210f80815b8 100644 --- a/drivers/gpu/drm/amd/amdgpu/vi.c +++ b/drivers/gpu/drm/amd/amdgpu/vi.c @@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev) case CHIP_POLARIS11: case CHIP_POLARIS12: case CHIP_TOPAZ: - return amdgpu_dpm_is_baco_supported(adev); + /* Disable BACO support for the specific polaris12 SKU temporarily */ + if ((adev->pdev->device == 0x699F) && + (adev->pdev->revision == 0xC7)) + return false; + else + return amdgpu_dpm_is_baco_supported(adev); default: return false; } -- 2.29.0
Re: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
On Fri, Aug 13, 2021 at 9:54 AM Alex Deucher wrote: > > Acked-by: Alex Deucher > > On Fri, Aug 13, 2021 at 4:09 AM Evan Quan wrote: > > > > We have a S3 issue on that SKU with BACO enabled. Will bring back this > > when that root caused. > > Actually it might be worth checking the SSIDs as well assuming this is platform specific. Alex > > Change-Id: I56d4830e6275e20a415808896eecbadfe944070b > > Signed-off-by: Evan Quan > > --- > > drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c > > b/drivers/gpu/drm/amd/amdgpu/vi.c > > index fe9a7cc8d9eb..7210f80815b8 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > > @@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device > > *adev) > > case CHIP_POLARIS11: > > case CHIP_POLARIS12: > > case CHIP_TOPAZ: > > - return amdgpu_dpm_is_baco_supported(adev); > > + /* Disable BACO support for the specific polaris12 SKU > > temporarily */ > > + if ((adev->pdev->device == 0x699F) && > > + (adev->pdev->revision == 0xC7)) > > + return false; > > + else > > + return amdgpu_dpm_is_baco_supported(adev); > > default: > > return false; > > } > > -- > > 2.29.0 > >
Re: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
Acked-by: Alex Deucher On Fri, Aug 13, 2021 at 4:09 AM Evan Quan wrote: > > We have a S3 issue on that SKU with BACO enabled. Will bring back this > when that root caused. > > Change-Id: I56d4830e6275e20a415808896eecbadfe944070b > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c > index fe9a7cc8d9eb..7210f80815b8 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device > *adev) > case CHIP_POLARIS11: > case CHIP_POLARIS12: > case CHIP_TOPAZ: > - return amdgpu_dpm_is_baco_supported(adev); > + /* Disable BACO support for the specific polaris12 SKU > temporarily */ > + if ((adev->pdev->device == 0x699F) && > + (adev->pdev->revision == 0xC7)) > + return false; > + else > + return amdgpu_dpm_is_baco_supported(adev); > default: > return false; > } > -- > 2.29.0 >
[PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
We have a S3 issue on that SKU with BACO enabled. Will bring back this when that root caused. Change-Id: I56d4830e6275e20a415808896eecbadfe944070b Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index fe9a7cc8d9eb..7210f80815b8 100644 --- a/drivers/gpu/drm/amd/amdgpu/vi.c +++ b/drivers/gpu/drm/amd/amdgpu/vi.c @@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev) case CHIP_POLARIS11: case CHIP_POLARIS12: case CHIP_TOPAZ: - return amdgpu_dpm_is_baco_supported(adev); + /* Disable BACO support for the specific polaris12 SKU temporarily */ + if ((adev->pdev->device == 0x699F) && + (adev->pdev->revision == 0xC7)) + return false; + else + return amdgpu_dpm_is_baco_supported(adev); default: return false; } -- 2.29.0
